)]}'
{"id":"openvpn~785","triplet_id":"openvpn~master~I8526aadb5151ddc997c836d5a691bcdfee700938","project":"openvpn","branch":"master","topic":"multisocket","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-10-23 12:03:16.000000000","reason":"Change was submitted"},"1000034":{"account":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"last_update":"2024-10-23 12:03:16.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-10-23 12:03:16.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I8526aadb5151ddc997c836d5a691bcdfee700938","subject":"Fix for msbuild/mingw GHA failures","status":"MERGED","created":"2024-10-23 11:04:53.000000000","updated":"2024-10-23 12:03:16.000000000","submitted":"2024-10-23 12:03:16.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"785-multisocket","meta_rev_id":"2e998e6fc7911dc25d043348d0dfb348544365bd","_number":785,"virtual_id_number":785,"owner":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-10-23 11:04:58.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-10-23 11:04:58.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2024-10-23 11:04:58.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2024-10-23 11:38:55.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"163b00ee7a7f0abade22236a2ab0df8435955bdf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2024-10-23 11:04:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5a2bbab0b09826516b36d1174b868ed8de050435","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-10-23 11:38:55.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2e998e6fc7911dc25d043348d0dfb348544365bd","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-10-23 12:03:16.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3636da3b0f168d8e06a00ec5d1f33e4b9aded262","revisions":{"4a0f196bb5fa62c45bf369b5602aa5dfe7095567":{"kind":"REWORK","_number":1,"created":"2024-10-23 11:04:53.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/85/785/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/85/785/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/785/1 \u0026\u0026 git checkout -b change-785 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/785/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/785/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/785/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/85/785/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/785/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cd8e25a6e9a0fc3687cf8b9df460885db2aee566","subject":"event/multi: add event_arg object to make event handling more generic"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2024-10-23 10:54:36.000000000","tz":120},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2024-10-23 11:03:35.000000000","tz":120},"subject":"Fix for msbuild/mingw GHA failures","message":"Fix for msbuild/mingw GHA failures\n\nCommit (\"event/multi: add event_arg object to make\nevent handling more generic\") accidentally removed\na variable declaration and its usage because of a\nrebase, this fix restore the wiped out\nunsigned int *persistent in multi_tcp_wait().\n\nChange-Id: I8526aadb5151ddc997c836d5a691bcdfee700938\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"3636da3b0f168d8e06a00ec5d1f33e4b9aded262":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-10-23 12:03:16.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/85/785/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/85/785/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/785/2 \u0026\u0026 git checkout -b change-785 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/785/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/785/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/785/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/85/785/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/85/785/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cd8e25a6e9a0fc3687cf8b9df460885db2aee566","subject":"event/multi: add event_arg object to make event handling more generic"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2024-10-23 11:39:23.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-10-23 11:45:59.000000000","tz":120},"subject":"Fix for msbuild/mingw GHA failures","message":"Fix for msbuild/mingw GHA failures\n\nCommit cd8e25a6e9 removed a variable because it looked as if\nused only once anyway (1 assignment, 1 usage) - overlooking that\non _WIN32 it\u0027s changed to NULL, which wasn\u0027t adjusted...\n\nThis fix restores the wiped out \"unsigned int *persistent\" in\nmulti_tcp_wait(), undoing this particular change of the previous\ncommit.\n\nChange-Id: I8526aadb5151ddc997c836d5a691bcdfee700938\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20241023113923.7420-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg29612.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}