)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"d1293acc125ebb50455ea37d7e1e588970cf2ef0","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  101 |     struct nlmsghdr n;"},{"line_number":17,"context_line":"      |                     ^"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"(Above warnings are critical on Fedora 40 as they are turned into errors)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Replacing the macro with a function is also not effective because gcc"},{"line_number":22,"context_line":"will inline it and get confused again."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"cc4a5a68_3ea32735","line":19,"updated":"2024-10-30 13:56:57.000000000","message":"This is misleading. The warning is turned into an error due to -Werror, not due to new GCC version.","commit_id":"f4f58a86ae40cdca26095d884e487a28ae8c3f93"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"969b81c2e8bf3bd74e68c6cb366407f11f12a898","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  101 |     struct nlmsghdr n;"},{"line_number":17,"context_line":"      |                     ^"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"(Above warnings are critical on Fedora 40 as they are turned into errors)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Replacing the macro with a function is also not effective because gcc"},{"line_number":22,"context_line":"will inline it and get confused again."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"cbc959de_21931c3f","line":19,"in_reply_to":"23b0d192_044e4c4d","updated":"2024-10-31 10:17:34.000000000","message":"I decided to drop that sentence at all. We all know that -Werror will make warnings critical.","commit_id":"f4f58a86ae40cdca26095d884e487a28ae8c3f93"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"b358bd77ca650e10fa6fdf93cdef516660a1b022","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  101 |     struct nlmsghdr n;"},{"line_number":17,"context_line":"      |                     ^"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"(Above warnings are critical on Fedora 40 as they are turned into errors)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Replacing the macro with a function is also not effective because gcc"},{"line_number":22,"context_line":"will inline it and get confused again."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"23b0d192_044e4c4d","line":19,"in_reply_to":"cc4a5a68_3ea32735","updated":"2024-10-31 10:06:52.000000000","message":"my intent was to say that this is turned into an error on Fedora by default - the reason resides in Fedora. But I can mention -Werror and drop Fedora.","commit_id":"f4f58a86ae40cdca26095d884e487a28ae8c3f93"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"f2a8f8504b1c561b8f24b66c48cb0e1e3520b907","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"63547dc9_6021ab33","updated":"2024-10-29 17:20:36.000000000","message":"Please fix uncrustify error","commit_id":"09512e30cf7ff0098513e7379944c1c568402614"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"d1293acc125ebb50455ea37d7e1e588970cf2ef0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"02610a1a_cbf4f8ce","updated":"2024-10-30 13:56:57.000000000","message":"Patch fixes the issue. Commit message is not completely right, but we might also fix that on submission.","commit_id":"f4f58a86ae40cdca26095d884e487a28ae8c3f93"}]}
