)]}'
{"id":"openvpn~788","triplet_id":"openvpn~master~I9306a590a10a7d5cba32abe06d269494fec41ba6","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-11-09 12:09:47.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-11-06 13:12:22.000000000","reason":"removed on reply"},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2024-11-09 12:09:47.000000000","reason":"Change was submitted"}},"hashtags":["mailsubmitted"],"change_id":"I9306a590a10a7d5cba32abe06d269494fec41ba6","subject":"sitnl: replace NLMSG_TAIL macro with noinline function","status":"MERGED","created":"2024-10-29 13:44:05.000000000","updated":"2024-11-09 12:09:47.000000000","submitted":"2024-11-09 12:09:47.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"788","meta_rev_id":"796a08079fc3596e56e23733757f2b684e50f8f1","_number":788,"virtual_id_number":788,"owner":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-10-29 13:44:06.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-10-29 13:44:06.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2024-10-29 13:44:06.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"e0e0dde2493bf3f56f30164fcda8e7d3e062e650","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2024-10-29 13:44:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"efd7ad20e12002e37a2d82f0042150aa0ae5e5ef","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2024-10-29 14:45:14.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f2a8f8504b1c561b8f24b66c48cb0e1e3520b907","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-10-29 17:20:36.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"3da8884870e48684ea30bafc50d0a0abb7d48a11","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2024-10-29 21:19:40.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"d1293acc125ebb50455ea37d7e1e588970cf2ef0","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-10-30 13:56:57.000000000","message":"Patch Set 3: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"ddf3688f1153d4b8a419c449ca7ab90c8fe45d3e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2024-10-31 09:18:22.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4},{"id":"b358bd77ca650e10fa6fdf93cdef516660a1b022","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2024-10-31 10:06:52.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"a364f90e7834fa866e5102c7694708a6c8dcaae0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2024-10-31 10:16:09.000000000","message":"Uploaded patch set 5: Commit message was updated.","accounts_in_message":[],"_revision_number":5},{"id":"969b81c2e8bf3bd74e68c6cb366407f11f12a898","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2024-10-31 10:17:34.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"13b398ff29b6b0a62b292126d34f8405395c62da","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-11-06 13:12:22.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"b2c069821318cefb758e30de382faf534bbe6f47","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-11-08 15:19:20.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":5},{"id":"796a08079fc3596e56e23733757f2b684e50f8f1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-11-09 12:09:47.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"648e1606496adc6ec37a9d862810e465dab64dc0","revisions":{"73752d322e68d64a4702a7e1c975a8fe84a46b41":{"kind":"REWORK","_number":1,"created":"2024-10-29 13:44:05.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/88/788/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/788/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/1 \u0026\u0026 git checkout -b change-788 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/88/788/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a7f80d402fb95df3c58a8fc5d12cdb8f39c37d3e","subject":"Refuse clients if username or password is longer than USER_PASS_LEN"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2024-10-29 13:34:13.000000000","tz":60},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2024-10-29 13:44:11.000000000","tz":60},"subject":"sitnl: replace NLMSG_TAIL macro with nlmsg_tail() function","message":"sitnl: replace NLMSG_TAIL macro with nlmsg_tail() function\n\nThe NLMSG_TAIL macro never had any reason to exist, because libnl\nalready provides a function doing exactly the same: nlmsg_tail().\n\nMoreover, this macro was found to confuse gcc when compiling with -O3,\nwhich would result in subsequent warnings like:\n\nnetworking_sitnl.c:143:9: warning: writing 4 bytes into a region of size 0 [-Wstringop-overflow\u003d]\n  143 |         memcpy(RTA_DATA(rta), data, alen);\n      |         ^\nnetworking_sitnl.c:101:21: note: at offset [72, 88] into destination object ‘n’ of size 16\n  101 |     struct nlmsghdr n;\n      |                     ^\n\n(Above warnings are critical on Fedora 40 as they are turned into errors)\n\nDelete the macro, replace it with nlmsg_tail() and get rid of the\nwarnings.\n\nChange-Id: I9306a590a10a7d5cba32abe06d269494fec41ba6\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"09512e30cf7ff0098513e7379944c1c568402614":{"kind":"REWORK","_number":2,"created":"2024-10-29 14:45:14.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/88/788/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/788/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/2 \u0026\u0026 git checkout -b change-788 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/88/788/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a7f80d402fb95df3c58a8fc5d12cdb8f39c37d3e","subject":"Refuse clients if username or password is longer than USER_PASS_LEN"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2024-10-29 13:34:13.000000000","tz":60},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2024-10-29 14:41:23.000000000","tz":60},"subject":"sitnl: replace NLMSG_TAIL macro with noinline function","message":"sitnl: replace NLMSG_TAIL macro with noinline function\n\nThe NLMSG_TAIL macro is confusing gcc when compiling with -O3, leading\nto warnings like:\n\nnetworking_sitnl.c:143:9: warning: writing 4 bytes into a region of size 0 [-Wstringop-overflow\u003d]\n  143 |         memcpy(RTA_DATA(rta), data, alen);\n      |         ^\nnetworking_sitnl.c:101:21: note: at offset [72, 88] into destination object ‘n’ of size 16\n  101 |     struct nlmsghdr n;\n      |                     ^\n\n(Above warnings are critical on Fedora 40 as they are turned into errors)\n\nReplacing the macro with a function is also not effective because gcc\nwill inline it and get confused again.\n\nThe only way out is to write a function that never gets inline\u0027d and\nreplace the macro with it.\n\nTested on linux with gcc and clang.\n\nChange-Id: I9306a590a10a7d5cba32abe06d269494fec41ba6\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"f4f58a86ae40cdca26095d884e487a28ae8c3f93":{"kind":"REWORK","_number":3,"created":"2024-10-29 21:19:40.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/88/788/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/788/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/3 \u0026\u0026 git checkout -b change-788 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/88/788/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a7f80d402fb95df3c58a8fc5d12cdb8f39c37d3e","subject":"Refuse clients if username or password is longer than USER_PASS_LEN"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2024-10-29 21:18:00.000000000","tz":60},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2024-10-29 21:19:34.000000000","tz":60},"subject":"sitnl: replace NLMSG_TAIL macro with noinline function","message":"sitnl: replace NLMSG_TAIL macro with noinline function\n\nThe NLMSG_TAIL macro is confusing gcc when compiling with -O3, leading\nto warnings like:\n\nnetworking_sitnl.c:143:9: warning: writing 4 bytes into a region of size 0 [-Wstringop-overflow\u003d]\n  143 |         memcpy(RTA_DATA(rta), data, alen);\n      |         ^\nnetworking_sitnl.c:101:21: note: at offset [72, 88] into destination object ‘n’ of size 16\n  101 |     struct nlmsghdr n;\n      |                     ^\n\n(Above warnings are critical on Fedora 40 as they are turned into errors)\n\nReplacing the macro with a function is also not effective because gcc\nwill inline it and get confused again.\n\nThe only way out is to write a function that never gets inline\u0027d and\nreplace the macro with it.\n\nTested on linux with gcc and clang.\n\nChange-Id: I9306a590a10a7d5cba32abe06d269494fec41ba6\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"ae1d5be1adce4380ab1e3588f1d751161d1e262f":{"kind":"REWORK","_number":4,"created":"2024-10-31 09:18:22.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/88/788/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/788/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/4 \u0026\u0026 git checkout -b change-788 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/88/788/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a7f80d402fb95df3c58a8fc5d12cdb8f39c37d3e","subject":"Refuse clients if username or password is longer than USER_PASS_LEN"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2024-10-29 21:18:00.000000000","tz":60},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2024-10-31 09:18:13.000000000","tz":60},"subject":"sitnl: replace NLMSG_TAIL macro with noinline function","message":"sitnl: replace NLMSG_TAIL macro with noinline function\n\nThe NLMSG_TAIL macro is confusing gcc when compiling with -O3, leading\nto warnings like:\n\nnetworking_sitnl.c:143:9: warning: writing 4 bytes into a region of size 0 [-Wstringop-overflow\u003d]\n  143 |         memcpy(RTA_DATA(rta), data, alen);\n      |         ^\nnetworking_sitnl.c:101:21: note: at offset [72, 88] into destination object ‘n’ of size 16\n  101 |     struct nlmsghdr n;\n      |                     ^\n\n(Above warnings are critical on Fedora 40 as they are turned into errors)\n\nReplacing the macro with a function is also not effective because gcc\nwill inline it and get confused again.\n\nThe only way out is to write a function that never gets inline\u0027d and\nreplace the macro with it.\n\nTested on linux with gcc and clang.\n\nChange-Id: I9306a590a10a7d5cba32abe06d269494fec41ba6\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"d59457e5bc69ea6d2d542121f87d86233a8cd1ab":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2024-10-31 10:16:09.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/88/788/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/788/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/5 \u0026\u0026 git checkout -b change-788 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/88/788/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a7f80d402fb95df3c58a8fc5d12cdb8f39c37d3e","subject":"Refuse clients if username or password is longer than USER_PASS_LEN"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2024-10-29 21:18:00.000000000","tz":60},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2024-10-31 10:15:48.000000000","tz":60},"subject":"sitnl: replace NLMSG_TAIL macro with noinline function","message":"sitnl: replace NLMSG_TAIL macro with noinline function\n\nThe NLMSG_TAIL macro is confusing gcc when compiling with -O3, leading\nto warnings like:\n\nnetworking_sitnl.c:143:9: warning: writing 4 bytes into a region of size 0 [-Wstringop-overflow\u003d]\n  143 |         memcpy(RTA_DATA(rta), data, alen);\n      |         ^\nnetworking_sitnl.c:101:21: note: at offset [72, 88] into destination object ‘n’ of size 16\n  101 |     struct nlmsghdr n;\n      |                     ^\n\nReplacing the macro with a function is also not effective because gcc\nwill inline it and get confused again.\n\nThe only way out is to write a function that never gets inline\u0027d and\nreplace the macro with it.\n\nTested on linux with gcc and clang.\n\nChange-Id: I9306a590a10a7d5cba32abe06d269494fec41ba6\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"648e1606496adc6ec37a9d862810e465dab64dc0":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":6,"created":"2024-11-09 12:09:47.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/88/788/6","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/788/6","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/6 \u0026\u0026 git checkout -b change-788 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/88/788/6","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/788/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7f0214c9e2ca2991bd8affd5754bf9286b904bf7","subject":"Remove support for compression on send"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2024-11-06 13:17:03.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-11-09 11:23:14.000000000","tz":60},"subject":"sitnl: replace NLMSG_TAIL macro with noinline function","message":"sitnl: replace NLMSG_TAIL macro with noinline function\n\nThe NLMSG_TAIL macro is confusing gcc when compiling with -O3, leading\nto warnings like:\n\nnetworking_sitnl.c:143:9: warning: writing 4 bytes into a region of size 0 [-Wstringop-overflow\u003d]\n  143 |         memcpy(RTA_DATA(rta), data, alen);\n      |         ^\nnetworking_sitnl.c:101:21: note: at offset [72, 88] into destination object ‘n’ of size 16\n  101 |     struct nlmsghdr n;\n      |                     ^\n\nReplacing the macro with a function is also not effective because gcc\nwill inline it and get confused again.\n\nThe only way out is to write a function that never gets inline\u0027d and\nreplace the macro with it.\n\nTested on linux with gcc and clang.\n\nChange-Id: I9306a590a10a7d5cba32abe06d269494fec41ba6\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20241106131705.11069-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg29710.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}