)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"933b29041908eeaea25a1a416ace3d69a5ba5071","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"21b07c5e_a92c63df","updated":"2024-11-29 10:39:54.000000000","message":"I did a quick test and following doesn\u0027t work:\n\n2024-11-29 11:11:30 us\u003d656000 PUSH: Received control message: \u0027PUSH_UPDATE,ifconfig 10.8.0.4 255.255.255.0\u0027\n2024-11-29 11:11:30 us\u003d656000 No option found\n2024-11-29 11:12:48 us\u003d265000 Closing ovpn-dco interface\n2024-11-29 11:12:48 us\u003d265000 NETSH: C:\\Windows\\system32\\netsh.exe interface ipv4 delete dns 20 all\n2024-11-29 11:12:48 us\u003d421000 NETSH: C:\\Windows\\system32\\netsh.exe interface ipv4 delete address 20 10.8.0.2 store\u003dactive\n2024-11-29 11:12:48 us\u003d609000 SIGTERM[hard,] received, process exiting","commit_id":"1bebe2317442a311ed2073f75404c1b83d18fa95"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"2b89891f6ecf66dc3aef49fb78a005113f666d82","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"2c309f54_444a280d","updated":"2025-03-05 12:56:40.000000000","message":"Please rebase to solve conflict with 40518dc66d9d04e6ec7e04439d7a6bc7fd6ac20f in options_util.[ch]","commit_id":"a9a79c7c55d2133e29e219580a9e8ca7ceeb18b9"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"12050863df9e326471147572a7b681c3b95c1db2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fcd16daa_91c4017f","in_reply_to":"2c309f54_444a280d","updated":"2025-03-21 04:58:28.000000000","message":"Done","commit_id":"a9a79c7c55d2133e29e219580a9e8ca7ceeb18b9"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"f60c49234a20c0f50b45cc84b8c43fde1c543b86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"f022651e_0f7ac948","updated":"2025-07-21 18:08:07.000000000","message":"So, I think this works and is sufficently save and efficient, but I\u0027m and old man and like my lawn orderly... so as discussed on IRC, please adjust a few minor points.","commit_id":"bb7b02388e5bcc3a795a53900f24052875fa042a"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"f7ce4a57a76e0f9c079a3f8a769c7f32213d5ec3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"5c0ccca2_78318739","updated":"2025-07-27 12:19:36.000000000","message":"I\u0027m fine with most of the new version, but I\u0027m still not really happy with `apply_push_options()`.  Sorry.","commit_id":"658213cf74a1d2bf0c65709c4d7501a828244049"}],"CMakeLists.txt":[{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"62f8b2728ecea167f111bccf587c85bc1a78de86","unresolved":true,"context_lines":[{"line_number":809,"context_line":"        src/openvpn/env_set.c"},{"line_number":810,"context_line":"        src/openvpn/run_command.c"},{"line_number":811,"context_line":"        )"},{"line_number":812,"context_line":"    "},{"line_number":813,"context_line":"    target_sources(test_push_update_msg PRIVATE"},{"line_number":814,"context_line":"        tests/unit_tests/openvpn/mock_msg.c"},{"line_number":815,"context_line":"        tests/unit_tests/openvpn/mock_get_random.c"}],"source_content_type":"text/x-cmake","patch_set":4,"id":"6208a664_8a387af8","line":812,"updated":"2024-11-27 11:41:18.000000000","message":"nit: whitespace","commit_id":"8dc41435fdc48da8424e525162ba53954c9e9ada"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"c4faa112c0e451231a05b2400042b6e5d2506c1b","unresolved":false,"context_lines":[{"line_number":809,"context_line":"        src/openvpn/env_set.c"},{"line_number":810,"context_line":"        src/openvpn/run_command.c"},{"line_number":811,"context_line":"        )"},{"line_number":812,"context_line":"    "},{"line_number":813,"context_line":"    target_sources(test_push_update_msg PRIVATE"},{"line_number":814,"context_line":"        tests/unit_tests/openvpn/mock_msg.c"},{"line_number":815,"context_line":"        tests/unit_tests/openvpn/mock_get_random.c"}],"source_content_type":"text/x-cmake","patch_set":4,"id":"8f5a6f36_8362c01a","line":812,"in_reply_to":"6208a664_8a387af8","updated":"2024-11-28 15:21:49.000000000","message":"Done","commit_id":"8dc41435fdc48da8424e525162ba53954c9e9ada"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"a4f06a194df31d276c0cbc2c3eaaefd395257e76","unresolved":true,"context_lines":[{"line_number":814,"context_line":"        tests/unit_tests/openvpn/mock_msg.c"},{"line_number":815,"context_line":"        tests/unit_tests/openvpn/mock_get_random.c"},{"line_number":816,"context_line":"\t    src/openvpn/buffer.c"},{"line_number":817,"context_line":"\t    src/openvpn/platform.c"},{"line_number":818,"context_line":"\t    src/openvpn/push_util.c"},{"line_number":819,"context_line":"\t    src/openvpn/options_util.c"},{"line_number":820,"context_line":"\t    src/openvpn/otime.c"}],"source_content_type":"text/x-cmake","patch_set":4,"id":"cd014878_336b1231","line":817,"updated":"2024-11-28 09:52:42.000000000","message":"buffer.c and platform.c are always added by foreach loop above. So they are redundant here.","commit_id":"8dc41435fdc48da8424e525162ba53954c9e9ada"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"ab28dc1909c3d0348172720e097a90916b2ed2fe","unresolved":false,"context_lines":[{"line_number":814,"context_line":"        tests/unit_tests/openvpn/mock_msg.c"},{"line_number":815,"context_line":"        tests/unit_tests/openvpn/mock_get_random.c"},{"line_number":816,"context_line":"\t    src/openvpn/buffer.c"},{"line_number":817,"context_line":"\t    src/openvpn/platform.c"},{"line_number":818,"context_line":"\t    src/openvpn/push_util.c"},{"line_number":819,"context_line":"\t    src/openvpn/options_util.c"},{"line_number":820,"context_line":"\t    src/openvpn/otime.c"}],"source_content_type":"text/x-cmake","patch_set":4,"id":"d57bba5b_c9eabd40","line":817,"in_reply_to":"cd014878_336b1231","updated":"2024-11-28 15:57:36.000000000","message":"Done","commit_id":"8dc41435fdc48da8424e525162ba53954c9e9ada"}],"src/openvpn/init.c":[{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"62f8b2728ecea167f111bccf587c85bc1a78de86","unresolved":true,"context_lines":[{"line_number":2030,"context_line":"        /* possibly add routes */"},{"line_number":2031,"context_line":"        if ((route_order(c-\u003ec1.tuntap) \u003d\u003d ROUTE_AFTER_TUN) \u0026\u0026 (!c-\u003eoptions.route_delay_defined))"},{"line_number":2032,"context_line":"        {"},{"line_number":2033,"context_line":"            int status \u003d do_route(\u0026c-\u003eoptions, c-\u003ec1.route_list, c-\u003ec1.route_ipv6_list,"},{"line_number":2034,"context_line":"                                  c-\u003ec1.tuntap, c-\u003eplugins, c-\u003ec2.es, \u0026c-\u003enet_ctx);"},{"line_number":2035,"context_line":"            *error_flags |\u003d (status ? 0 : ISC_ROUTE_ERRORS);"},{"line_number":2036,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"4862d3bd_9b57ad9f","side":"PARENT","line":2033,"updated":"2024-11-27 11:41:18.000000000","message":"nice catch!","commit_id":"6c636f5387245ceb4809eac765c4b649709b4aa8"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"c4faa112c0e451231a05b2400042b6e5d2506c1b","unresolved":false,"context_lines":[{"line_number":2030,"context_line":"        /* possibly add routes */"},{"line_number":2031,"context_line":"        if ((route_order(c-\u003ec1.tuntap) \u003d\u003d ROUTE_AFTER_TUN) \u0026\u0026 (!c-\u003eoptions.route_delay_defined))"},{"line_number":2032,"context_line":"        {"},{"line_number":2033,"context_line":"            int status \u003d do_route(\u0026c-\u003eoptions, c-\u003ec1.route_list, c-\u003ec1.route_ipv6_list,"},{"line_number":2034,"context_line":"                                  c-\u003ec1.tuntap, c-\u003eplugins, c-\u003ec2.es, \u0026c-\u003enet_ctx);"},{"line_number":2035,"context_line":"            *error_flags |\u003d (status ? 0 : ISC_ROUTE_ERRORS);"},{"line_number":2036,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"bd8dd262_1158ed00","side":"PARENT","line":2033,"in_reply_to":"4862d3bd_9b57ad9f","updated":"2024-11-28 15:21:49.000000000","message":"tnx!","commit_id":"6c636f5387245ceb4809eac765c4b649709b4aa8"}],"src/openvpn/options.c":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"02b0d8925f05fb3a7a8c5a0fdf050aa839fa2726","unresolved":true,"context_lines":[{"line_number":5469,"context_line":"        char *p[MAX_PARMS+1];"},{"line_number":5470,"context_line":"        CLEAR(p);"},{"line_number":5471,"context_line":"        ++line_num;"},{"line_number":5472,"context_line":"        if (!apply_pull_filter(options, line))"},{"line_number":5473,"context_line":"        {"},{"line_number":5474,"context_line":"            return false; /* Cause push/pull error and stop push processing */"},{"line_number":5475,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f6e72862_6ae239a4","line":5472,"updated":"2024-11-21 13:10:07.000000000","message":"```\noptions.c: In function ‘apply_push_options’:\noptions.c:5472:14: error: too few arguments to function ‘apply_pull_filter’\n 5472 |         if (!apply_pull_filter(options, line))\n      |              ^~~~~~~~~~~~~~~~~\nIn file included from options.c:66:\noptions_util.h:34:1: note: declared here\n   34 | apply_pull_filter(const struct options *o,\n      | ^~~~~~~~~~~~~~~~~\n```","commit_id":"413e37b0d5b2c2b0271078dbaf311bcfdbdbc773"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"27b6f602b4ba45a6df7f3045ea0f167eaff80f6b","unresolved":false,"context_lines":[{"line_number":5469,"context_line":"        char *p[MAX_PARMS+1];"},{"line_number":5470,"context_line":"        CLEAR(p);"},{"line_number":5471,"context_line":"        ++line_num;"},{"line_number":5472,"context_line":"        if (!apply_pull_filter(options, line))"},{"line_number":5473,"context_line":"        {"},{"line_number":5474,"context_line":"            return false; /* Cause push/pull error and stop push processing */"},{"line_number":5475,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"63c77cf9_f80c96b7","line":5472,"in_reply_to":"f6e72862_6ae239a4","updated":"2024-11-21 18:30:19.000000000","message":"Done","commit_id":"413e37b0d5b2c2b0271078dbaf311bcfdbdbc773"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"02b0d8925f05fb3a7a8c5a0fdf050aa839fa2726","unresolved":true,"context_lines":[{"line_number":5615,"context_line":"    return options-\u003eforward_compatible ? M_WARN : msglevel;"},{"line_number":5616,"context_line":"}"},{"line_number":5617,"context_line":"bool"},{"line_number":5618,"context_line":"apply_push_options(struct context *c,"},{"line_number":5619,"context_line":"                   struct options *options,"},{"line_number":5620,"context_line":"                   struct buffer *buf,"},{"line_number":5621,"context_line":"                   unsigned int permission_mask,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"09d1a5a6_ed8662d7","line":5618,"updated":"2024-11-21 13:10:07.000000000","message":"```\noptions.c:5456:1: error: conflicting types for ‘apply_push_options’; have ‘_Bool(struct options *, struct buffer *, unsigned int,  unsigned int *, struct env_set *)’\n 5456 | apply_push_options(struct options *options,\n      | ^~~~~~~~~~~~~~~~~~\nIn file included from ssl.h:40,\n                 from options.c:45:\noptions.h:875:6: note: previous declaration of ‘apply_push_options’ with type ‘_Bool(struct context *, struct options *, struct buffer *, unsigned int,  unsigned int *, struct env_set *, _Bool)’\n  875 | bool apply_push_options(struct context *c,\n      |      ^~~~~~~~~~~~~~~~~~\n```","commit_id":"413e37b0d5b2c2b0271078dbaf311bcfdbdbc773"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"27b6f602b4ba45a6df7f3045ea0f167eaff80f6b","unresolved":false,"context_lines":[{"line_number":5615,"context_line":"    return options-\u003eforward_compatible ? M_WARN : msglevel;"},{"line_number":5616,"context_line":"}"},{"line_number":5617,"context_line":"bool"},{"line_number":5618,"context_line":"apply_push_options(struct context *c,"},{"line_number":5619,"context_line":"                   struct options *options,"},{"line_number":5620,"context_line":"                   struct buffer *buf,"},{"line_number":5621,"context_line":"                   unsigned int permission_mask,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b168825e_5aab5102","line":5618,"in_reply_to":"09d1a5a6_ed8662d7","updated":"2024-11-21 18:30:19.000000000","message":"Done","commit_id":"413e37b0d5b2c2b0271078dbaf311bcfdbdbc773"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"58c6eb75c901502cb1e44a86f2b5d677a4675363","unresolved":true,"context_lines":[{"line_number":929,"context_line":""},{"line_number":930,"context_line":"struct pull_filter"},{"line_number":931,"context_line":"{"},{"line_number":932,"context_line":"#define PUF_TYPE_UNDEF  0    /** undefined filter type */"},{"line_number":933,"context_line":"#define PUF_TYPE_ACCEPT 1    /** filter type to accept a matching option */"},{"line_number":934,"context_line":"#define PUF_TYPE_IGNORE 2    /** filter type to ignore a matching option */"},{"line_number":935,"context_line":"#define PUF_TYPE_REJECT 3    /** filter type to reject and trigger SIGUSR1 */"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"0907cbe2_3aee602b","side":"PARENT","line":932,"updated":"2024-11-26 17:31:15.000000000","message":"Needs rebase on top of 6c636f5387245ceb4809eac765c4b649709b4aa8","commit_id":"d52ea247d9dec5262a09f3891db83b79b2ca403e"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"70eba38f0848ad6d84f4b345b9f1c35059e50e73","unresolved":false,"context_lines":[{"line_number":929,"context_line":""},{"line_number":930,"context_line":"struct pull_filter"},{"line_number":931,"context_line":"{"},{"line_number":932,"context_line":"#define PUF_TYPE_UNDEF  0    /** undefined filter type */"},{"line_number":933,"context_line":"#define PUF_TYPE_ACCEPT 1    /** filter type to accept a matching option */"},{"line_number":934,"context_line":"#define PUF_TYPE_IGNORE 2    /** filter type to ignore a matching option */"},{"line_number":935,"context_line":"#define PUF_TYPE_REJECT 3    /** filter type to reject and trigger SIGUSR1 */"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"4631a9b8_d330a116","side":"PARENT","line":932,"in_reply_to":"0907cbe2_3aee602b","updated":"2024-11-27 10:45:33.000000000","message":"Done","commit_id":"d52ea247d9dec5262a09f3891db83b79b2ca403e"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"f60c49234a20c0f50b45cc84b8c43fde1c543b86","unresolved":true,"context_lines":[{"line_number":5564,"context_line":"}"},{"line_number":5565,"context_line":""},{"line_number":5566,"context_line":"bool"},{"line_number":5567,"context_line":"apply_push_options(struct options *options,"},{"line_number":5568,"context_line":"                   struct buffer *buf,"},{"line_number":5569,"context_line":"                   unsigned int permission_mask,"},{"line_number":5570,"context_line":"                   unsigned int *option_types_found,"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"849fb9c1_8109d087","side":"PARENT","line":5567,"updated":"2025-07-21 18:08:07.000000000","message":"please do not move that one around in options.c, this makes comparing old/new harder without good benefit, also breaks git blame...","commit_id":"31aedd7fbfd9d4856a5ae7085d15228ec57fb2a1"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"77d9f65e3e7bf98a92f47d99432a68193fd17cf0","unresolved":false,"context_lines":[{"line_number":5564,"context_line":"}"},{"line_number":5565,"context_line":""},{"line_number":5566,"context_line":"bool"},{"line_number":5567,"context_line":"apply_push_options(struct options *options,"},{"line_number":5568,"context_line":"                   struct buffer *buf,"},{"line_number":5569,"context_line":"                   unsigned int permission_mask,"},{"line_number":5570,"context_line":"                   unsigned int *option_types_found,"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"0bc4e799_eafa8770","side":"PARENT","line":5567,"in_reply_to":"849fb9c1_8109d087","updated":"2025-07-23 17:11:24.000000000","message":"Done","commit_id":"31aedd7fbfd9d4856a5ae7085d15228ec57fb2a1"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"f60c49234a20c0f50b45cc84b8c43fde1c543b86","unresolved":true,"context_lines":[{"line_number":5651,"context_line":"        CLEAR(p);"},{"line_number":5652,"context_line":"        ++line_num;"},{"line_number":5653,"context_line":"        unsigned int push_update_option_flags \u003d 0;"},{"line_number":5654,"context_line":""},{"line_number":5655,"context_line":"        if (!apply_pull_filter(options, line, is_update, \u0026push_update_option_flags))"},{"line_number":5656,"context_line":"        {"},{"line_number":5657,"context_line":"            throw_signal_soft(SIGUSR1, \"Offending option received from server\");"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"25512e6f_b2eb183f","line":5654,"updated":"2025-07-21 18:08:07.000000000","message":"so I would call check_push_update_option_flags() from here, possibly moving the \"while isspace(*line) { line++; }\" part up here as well.  Then we can keep \"apply_pull_filter()\" focused on \"pull filter\", not dealing with a number of extra conditions...  (just \"is_update\", see there)","commit_id":"bb7b02388e5bcc3a795a53900f24052875fa042a"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"77d9f65e3e7bf98a92f47d99432a68193fd17cf0","unresolved":false,"context_lines":[{"line_number":5651,"context_line":"        CLEAR(p);"},{"line_number":5652,"context_line":"        ++line_num;"},{"line_number":5653,"context_line":"        unsigned int push_update_option_flags \u003d 0;"},{"line_number":5654,"context_line":""},{"line_number":5655,"context_line":"        if (!apply_pull_filter(options, line, is_update, \u0026push_update_option_flags))"},{"line_number":5656,"context_line":"        {"},{"line_number":5657,"context_line":"            throw_signal_soft(SIGUSR1, \"Offending option received from server\");"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"010661f3_5e3b560e","line":5654,"in_reply_to":"25512e6f_b2eb183f","updated":"2025-07-23 17:11:24.000000000","message":"Done","commit_id":"bb7b02388e5bcc3a795a53900f24052875fa042a"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"f7ce4a57a76e0f9c079a3f8a769c7f32213d5ec3","unresolved":true,"context_lines":[{"line_number":5521,"context_line":"        int i \u003d 0;"},{"line_number":5522,"context_line":""},{"line_number":5523,"context_line":"        if (is_update || options-\u003epull_filter_list)"},{"line_number":5524,"context_line":"        {"},{"line_number":5525,"context_line":"            /* skip leading spaces matching the behaviour of parse_line */"},{"line_number":5526,"context_line":"            while (isspace(line[i]))"},{"line_number":5527,"context_line":"            {"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"f3fc7445_db3c4290","line":5524,"updated":"2025-07-27 12:19:36.000000000","message":"please get rid of this extra `if()` level.  Both conditions are checked again inside, so this is not really adding anything but an indent level.","commit_id":"658213cf74a1d2bf0c65709c4d7501a828244049"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"72cb39becd62ef0d13d8de8538bc147af7fedb71","unresolved":false,"context_lines":[{"line_number":5521,"context_line":"        int i \u003d 0;"},{"line_number":5522,"context_line":""},{"line_number":5523,"context_line":"        if (is_update || options-\u003epull_filter_list)"},{"line_number":5524,"context_line":"        {"},{"line_number":5525,"context_line":"            /* skip leading spaces matching the behaviour of parse_line */"},{"line_number":5526,"context_line":"            while (isspace(line[i]))"},{"line_number":5527,"context_line":"            {"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"341dde0f_71ee184e","line":5524,"in_reply_to":"f3fc7445_db3c4290","updated":"2025-07-28 10:43:08.000000000","message":"Done","commit_id":"658213cf74a1d2bf0c65709c4d7501a828244049"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"f7ce4a57a76e0f9c079a3f8a769c7f32213d5ec3","unresolved":true,"context_lines":[{"line_number":5529,"context_line":"            }"},{"line_number":5530,"context_line":""},{"line_number":5531,"context_line":"            if ((is_update \u0026\u0026 !check_push_update_option_flags(line, \u0026i, \u0026push_update_option_flags))"},{"line_number":5532,"context_line":"                || (options-\u003epull_filter_list \u0026\u0026 !apply_pull_filter(options, \u0026line[i])))"},{"line_number":5533,"context_line":"            {"},{"line_number":5534,"context_line":"                if (push_update_option_flags \u0026 PUSH_OPT_OPTIONAL)"},{"line_number":5535,"context_line":"                {"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"37cf1615_f21e2c77","line":5532,"updated":"2025-07-27 12:19:36.000000000","message":"I find this very hard to understand, even if it\u0027s a bit more space-efficient than having two `if()` clauses with their own error handling - but the latter would make the whole flow easier to understand.\n\nMaybe just leaving the `option-\u003epull_filter_list` check inside `apply_pull_filter()`  (as it was) would already make this easier to read.  Yes, we\u0027d waste a function call per received push-option, but this is not a critical code path.","commit_id":"658213cf74a1d2bf0c65709c4d7501a828244049"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"72cb39becd62ef0d13d8de8538bc147af7fedb71","unresolved":false,"context_lines":[{"line_number":5529,"context_line":"            }"},{"line_number":5530,"context_line":""},{"line_number":5531,"context_line":"            if ((is_update \u0026\u0026 !check_push_update_option_flags(line, \u0026i, \u0026push_update_option_flags))"},{"line_number":5532,"context_line":"                || (options-\u003epull_filter_list \u0026\u0026 !apply_pull_filter(options, \u0026line[i])))"},{"line_number":5533,"context_line":"            {"},{"line_number":5534,"context_line":"                if (push_update_option_flags \u0026 PUSH_OPT_OPTIONAL)"},{"line_number":5535,"context_line":"                {"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"005048a0_9d87b4c9","line":5532,"in_reply_to":"37cf1615_f21e2c77","updated":"2025-07-28 10:43:08.000000000","message":"Done","commit_id":"658213cf74a1d2bf0c65709c4d7501a828244049"}],"src/openvpn/options.h":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"a4f06a194df31d276c0cbc2c3eaaefd395257e76","unresolved":true,"context_lines":[{"line_number":788,"context_line":""},{"line_number":789,"context_line":"struct pull_filter"},{"line_number":790,"context_line":"{"},{"line_number":791,"context_line":"#define PUF_TYPE_UNDEF  0    /** undefined filter type */"},{"line_number":792,"context_line":"#define PUF_TYPE_ACCEPT 1    /** filter type to accept a matching option */"},{"line_number":793,"context_line":"#define PUF_TYPE_IGNORE 2    /** filter type to ignore a matching option */"},{"line_number":794,"context_line":"#define PUF_TYPE_REJECT 3    /** filter type to reject and trigger SIGUSR1 */"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"654dd17f_91aed2e0","line":791,"updated":"2024-11-28 09:52:42.000000000","message":"You didn\u0027t resolve the conflict correctly when rebasing. Please copy the new code here.","commit_id":"8dc41435fdc48da8424e525162ba53954c9e9ada"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"ab28dc1909c3d0348172720e097a90916b2ed2fe","unresolved":false,"context_lines":[{"line_number":788,"context_line":""},{"line_number":789,"context_line":"struct pull_filter"},{"line_number":790,"context_line":"{"},{"line_number":791,"context_line":"#define PUF_TYPE_UNDEF  0    /** undefined filter type */"},{"line_number":792,"context_line":"#define PUF_TYPE_ACCEPT 1    /** filter type to accept a matching option */"},{"line_number":793,"context_line":"#define PUF_TYPE_IGNORE 2    /** filter type to ignore a matching option */"},{"line_number":794,"context_line":"#define PUF_TYPE_REJECT 3    /** filter type to reject and trigger SIGUSR1 */"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"17c2f5d7_5fb82784","line":791,"in_reply_to":"654dd17f_91aed2e0","updated":"2024-11-28 15:57:36.000000000","message":"you are right, sorry!","commit_id":"8dc41435fdc48da8424e525162ba53954c9e9ada"}],"src/openvpn/options_util.c":[{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"62f8b2728ecea167f111bccf587c85bc1a78de86","unresolved":true,"context_lines":[{"line_number":121,"context_line":"};"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"static bool"},{"line_number":124,"context_line":"check_push_update_option_flags(char **line, unsigned int *flags)"},{"line_number":125,"context_line":"{"},{"line_number":126,"context_line":"    if (!line || !*line || !**line)"},{"line_number":127,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"93ec136c_da93606f","line":124,"updated":"2024-11-27 11:41:18.000000000","message":"Add doxygen what does this function do.","commit_id":"8dc41435fdc48da8424e525162ba53954c9e9ada"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"c4faa112c0e451231a05b2400042b6e5d2506c1b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"};"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"static bool"},{"line_number":124,"context_line":"check_push_update_option_flags(char **line, unsigned int *flags)"},{"line_number":125,"context_line":"{"},{"line_number":126,"context_line":"    if (!line || !*line || !**line)"},{"line_number":127,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"f8c35b78_8f40c7a2","line":124,"in_reply_to":"93ec136c_da93606f","updated":"2024-11-28 15:21:49.000000000","message":"Done","commit_id":"8dc41435fdc48da8424e525162ba53954c9e9ada"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"62f8b2728ecea167f111bccf587c85bc1a78de86","unresolved":true,"context_lines":[{"line_number":135,"context_line":"    if (c \u003d\u003d \u0027?\u0027)"},{"line_number":136,"context_line":"    {"},{"line_number":137,"context_line":"        *flags |\u003d PUSH_OPT_OPTIONAL;"},{"line_number":138,"context_line":"        if (str[1])"},{"line_number":139,"context_line":"        {"},{"line_number":140,"context_line":"            c \u003d *(++str);"},{"line_number":141,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"cacb7fd2_2e6844f7","line":138,"updated":"2024-11-27 11:41:18.000000000","message":"below 8 lines are duplicated 3 times. Maybe define a macro and reuse it, and later undefine? Like\n\n#define ADVANCE_OR_FAIL(ptr) \\\n    do {                     \\\n        if (!(ptr)[1])       \\\n            return false;    \\\n        c \u003d *(++(ptr));      \\\n    } while (0)","commit_id":"8dc41435fdc48da8424e525162ba53954c9e9ada"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"c4faa112c0e451231a05b2400042b6e5d2506c1b","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    if (c \u003d\u003d \u0027?\u0027)"},{"line_number":136,"context_line":"    {"},{"line_number":137,"context_line":"        *flags |\u003d PUSH_OPT_OPTIONAL;"},{"line_number":138,"context_line":"        if (str[1])"},{"line_number":139,"context_line":"        {"},{"line_number":140,"context_line":"            c \u003d *(++str);"},{"line_number":141,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"a0c306fd_1444ca21","line":138,"in_reply_to":"cacb7fd2_2e6844f7","updated":"2024-11-28 15:21:49.000000000","message":"Clever, i like it, I tried but when the compiler optimizes it, the code gets skipped. Anyway, i simplified and now i use it just 2 times and with a slightly different condition so i hope is good enough","commit_id":"8dc41435fdc48da8424e525162ba53954c9e9ada"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"62f8b2728ecea167f111bccf587c85bc1a78de86","unresolved":true,"context_lines":[{"line_number":157,"context_line":"        }"},{"line_number":158,"context_line":"    }"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    if (c \u003d\u003d \u0027-\u0027 \u0026\u0026 !(*flags \u0026 PUSH_OPT_TO_REMOVE))"},{"line_number":161,"context_line":"    {"},{"line_number":162,"context_line":"        *flags |\u003d PUSH_OPT_TO_REMOVE;"},{"line_number":163,"context_line":"        if (str[1])"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"fc0ee113_1823490a","line":160,"updated":"2024-11-27 11:41:18.000000000","message":"you could remove the \"c \u003d\u003d \u0027-\u0027\" check here and move this whole block under the \"if\" condition above","commit_id":"8dc41435fdc48da8424e525162ba53954c9e9ada"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"c4faa112c0e451231a05b2400042b6e5d2506c1b","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        }"},{"line_number":158,"context_line":"    }"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    if (c \u003d\u003d \u0027-\u0027 \u0026\u0026 !(*flags \u0026 PUSH_OPT_TO_REMOVE))"},{"line_number":161,"context_line":"    {"},{"line_number":162,"context_line":"        *flags |\u003d PUSH_OPT_TO_REMOVE;"},{"line_number":163,"context_line":"        if (str[1])"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"a517e1a9_3a38d88f","line":160,"in_reply_to":"fc0ee113_1823490a","updated":"2024-11-28 15:21:49.000000000","message":"I\u0027m not entirely sure that\u0027s what you meant but I simplified","commit_id":"8dc41435fdc48da8424e525162ba53954c9e9ada"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"62f8b2728ecea167f111bccf587c85bc1a78de86","unresolved":true,"context_lines":[{"line_number":218,"context_line":" * In that case the caller must end the push processing."},{"line_number":219,"context_line":" */"},{"line_number":220,"context_line":"bool"},{"line_number":221,"context_line":"apply_pull_filter(const struct options *o, char *line, bool is_update, unsigned int *push_update_option_flags)"},{"line_number":222,"context_line":"{"},{"line_number":223,"context_line":"    struct pull_filter *f;"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"76877514_402d6e34","line":221,"updated":"2024-11-27 11:41:18.000000000","message":"Let\u0027s move doxygen to the header.","commit_id":"8dc41435fdc48da8424e525162ba53954c9e9ada"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"c4faa112c0e451231a05b2400042b6e5d2506c1b","unresolved":false,"context_lines":[{"line_number":218,"context_line":" * In that case the caller must end the push processing."},{"line_number":219,"context_line":" */"},{"line_number":220,"context_line":"bool"},{"line_number":221,"context_line":"apply_pull_filter(const struct options *o, char *line, bool is_update, unsigned int *push_update_option_flags)"},{"line_number":222,"context_line":"{"},{"line_number":223,"context_line":"    struct pull_filter *f;"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":4,"id":"ada8cdcc_81c709fb","line":221,"in_reply_to":"76877514_402d6e34","updated":"2024-11-28 15:21:49.000000000","message":"Done","commit_id":"8dc41435fdc48da8424e525162ba53954c9e9ada"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"f60c49234a20c0f50b45cc84b8c43fde1c543b86","unresolved":true,"context_lines":[{"line_number":195,"context_line":"static bool"},{"line_number":196,"context_line":"check_push_update_option_flags(char **line, unsigned int *flags)"},{"line_number":197,"context_line":"{"},{"line_number":198,"context_line":"    if (!line || !*line || !**line)"},{"line_number":199,"context_line":"    {"},{"line_number":200,"context_line":"        return false;"},{"line_number":201,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"5c5cd074_1394fe2c","line":198,"updated":"2025-07-21 18:08:07.000000000","message":"the use of a double pointer irritates me, because we never move the pointer, instead `memmove()` the buffer...\n\nI think we should just do `(*line)++` instead of the `memmove()` below - possibly also getting rid of the `strlen(str)` thing, or `str` altogether :-) - so keep the pointer, call it from `apply_push_options()` and accept a moving `*line` pointer.\n\nAlso, I\u0027m not sure if \"empty string\" should be treated as `false` or just ignored (return true, that is) - the existing environment where `apply_pull_filter()` is used does not care for \"empty lines\".\n\nA NULL pointer is a programming error that must never happen, so an ASSERT(line) is valid.","commit_id":"bb7b02388e5bcc3a795a53900f24052875fa042a"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"77d9f65e3e7bf98a92f47d99432a68193fd17cf0","unresolved":false,"context_lines":[{"line_number":195,"context_line":"static bool"},{"line_number":196,"context_line":"check_push_update_option_flags(char **line, unsigned int *flags)"},{"line_number":197,"context_line":"{"},{"line_number":198,"context_line":"    if (!line || !*line || !**line)"},{"line_number":199,"context_line":"    {"},{"line_number":200,"context_line":"        return false;"},{"line_number":201,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"47b8a262_12fab17a","line":198,"in_reply_to":"5c5cd074_1394fe2c","updated":"2025-07-23 17:11:24.000000000","message":"Done","commit_id":"bb7b02388e5bcc3a795a53900f24052875fa042a"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"f60c49234a20c0f50b45cc84b8c43fde1c543b86","unresolved":true,"context_lines":[{"line_number":228,"context_line":"    memmove(*line, str, len);"},{"line_number":229,"context_line":"    (*line)[len] \u003d \u0027\\0\u0027;"},{"line_number":230,"context_line":"    str \u003d *line;"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    int count \u003d sizeof(updatable_options)/sizeof(char *);"},{"line_number":233,"context_line":"    for (int i \u003d 0; i \u003c count; ++i)"},{"line_number":234,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"6ffca9a9_893ed859","line":231,"updated":"2025-07-21 18:08:07.000000000","message":"If there is whitespace here (`?  route`) we\u0027ll fail with `pushed option is not updateable: \u0027  route\u0027`, if I\u0027m not misreading it.\n\nI\u0027d document that \"there must not be whitespace between the flag letters and the option\" and then we could add an `if (isspace(**line)) { complain; return false; }` here... the documentation is important, the error handling not so much (as it will hit the `return false` anyway)","commit_id":"bb7b02388e5bcc3a795a53900f24052875fa042a"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"77d9f65e3e7bf98a92f47d99432a68193fd17cf0","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    memmove(*line, str, len);"},{"line_number":229,"context_line":"    (*line)[len] \u003d \u0027\\0\u0027;"},{"line_number":230,"context_line":"    str \u003d *line;"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    int count \u003d sizeof(updatable_options)/sizeof(char *);"},{"line_number":233,"context_line":"    for (int i \u003d 0; i \u003c count; ++i)"},{"line_number":234,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"8e312009_6f3eacc1","line":231,"in_reply_to":"6ffca9a9_893ed859","updated":"2025-07-23 17:11:24.000000000","message":"Done","commit_id":"bb7b02388e5bcc3a795a53900f24052875fa042a"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"f60c49234a20c0f50b45cc84b8c43fde1c543b86","unresolved":true,"context_lines":[{"line_number":249,"context_line":"    {"},{"line_number":250,"context_line":"        if (*flags \u0026 PUSH_OPT_OPTIONAL)"},{"line_number":251,"context_line":"        {"},{"line_number":252,"context_line":"            msg(D_PUSH, \"Pushed option is not updatable: \u0027%s\u0027\", *line);"},{"line_number":253,"context_line":"            return true;"},{"line_number":254,"context_line":"        }"},{"line_number":255,"context_line":"        else"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"bc8b42ab_3cf0ba0c","line":252,"updated":"2025-07-21 18:08:07.000000000","message":"Maybe add an \" Ignoring.\" to the string, so it\u0027s clear \"this is informational, but not an error, and this is how we handle it\"?  Since the other one has \"Restarting\"...","commit_id":"bb7b02388e5bcc3a795a53900f24052875fa042a"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"77d9f65e3e7bf98a92f47d99432a68193fd17cf0","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    {"},{"line_number":250,"context_line":"        if (*flags \u0026 PUSH_OPT_OPTIONAL)"},{"line_number":251,"context_line":"        {"},{"line_number":252,"context_line":"            msg(D_PUSH, \"Pushed option is not updatable: \u0027%s\u0027\", *line);"},{"line_number":253,"context_line":"            return true;"},{"line_number":254,"context_line":"        }"},{"line_number":255,"context_line":"        else"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"a777b4e8_51887b18","line":252,"in_reply_to":"bc8b42ab_3cf0ba0c","updated":"2025-07-23 17:11:24.000000000","message":"Done","commit_id":"bb7b02388e5bcc3a795a53900f24052875fa042a"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"f60c49234a20c0f50b45cc84b8c43fde1c543b86","unresolved":true,"context_lines":[{"line_number":267,"context_line":"{"},{"line_number":268,"context_line":"    struct pull_filter *f;"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    if (!o-\u003epull_filter_list \u0026\u0026 !(is_update))"},{"line_number":271,"context_line":"    {"},{"line_number":272,"context_line":"        return true;"},{"line_number":273,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"ce24fecc_c0a39fcd","line":270,"updated":"2025-07-21 18:08:07.000000000","message":"So, if we call `check_push_update_option_flags()` from outside, we do not need this extra dance, checking o-\u003epull_filter_list twice...","commit_id":"bb7b02388e5bcc3a795a53900f24052875fa042a"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"77d9f65e3e7bf98a92f47d99432a68193fd17cf0","unresolved":false,"context_lines":[{"line_number":267,"context_line":"{"},{"line_number":268,"context_line":"    struct pull_filter *f;"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    if (!o-\u003epull_filter_list \u0026\u0026 !(is_update))"},{"line_number":271,"context_line":"    {"},{"line_number":272,"context_line":"        return true;"},{"line_number":273,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"b521c226_07b2309a","line":270,"in_reply_to":"ce24fecc_c0a39fcd","updated":"2025-07-23 17:11:24.000000000","message":"Done","commit_id":"bb7b02388e5bcc3a795a53900f24052875fa042a"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"f60c49234a20c0f50b45cc84b8c43fde1c543b86","unresolved":true,"context_lines":[{"line_number":273,"context_line":"    }"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    /* skip leading spaces matching the behaviour of parse_line */"},{"line_number":276,"context_line":"    while (isspace(*line))"},{"line_number":277,"context_line":"    {"},{"line_number":278,"context_line":"        line++;"},{"line_number":279,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"8974bb49_5a803112","line":276,"updated":"2025-07-21 18:08:07.000000000","message":"It makes sense to move that upwards to `apply_push_options()`, before calling anything on the line.  So both all functions called do not need to bother about leading whitespace.","commit_id":"bb7b02388e5bcc3a795a53900f24052875fa042a"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"77d9f65e3e7bf98a92f47d99432a68193fd17cf0","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    }"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    /* skip leading spaces matching the behaviour of parse_line */"},{"line_number":276,"context_line":"    while (isspace(*line))"},{"line_number":277,"context_line":"    {"},{"line_number":278,"context_line":"        line++;"},{"line_number":279,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"4d43cf7c_4985502d","line":276,"in_reply_to":"8974bb49_5a803112","updated":"2025-07-23 17:11:24.000000000","message":"Done","commit_id":"bb7b02388e5bcc3a795a53900f24052875fa042a"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"f60c49234a20c0f50b45cc84b8c43fde1c543b86","unresolved":true,"context_lines":[{"line_number":307,"context_line":"            if (is_update \u0026\u0026 (*push_update_option_flags \u0026 PUSH_OPT_OPTIONAL))"},{"line_number":308,"context_line":"            {"},{"line_number":309,"context_line":"                msg(D_PUSH, \"Pushed option removed by filter: \u0027%s\u0027\", line);"},{"line_number":310,"context_line":"                return true;"},{"line_number":311,"context_line":"            }"},{"line_number":312,"context_line":"            else"},{"line_number":313,"context_line":"            {"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"8689afde_5d9ee877","line":310,"updated":"2025-07-21 18:08:07.000000000","message":"This duplication of the messages and `return true` looks a bit silly :-) - I would suggest to do\n\n```\n        /* on PUSH_UPDATE, \"reject\" and \"ignore\" filters are treated the same */\n        else if ( (f-\u003etype \u003d\u003d PUF_TYPE_IGNORE || is_update)\n                   \u0026\u0026 strncmp(line, f-\u003epattern, f-\u003esize) \u003d\u003d 0)\n        {\n            msg(D_PUSH, \"Pushed option removed by filter: \u0027%s\u0027\", line);\n            return true;\n        }\n```","commit_id":"bb7b02388e5bcc3a795a53900f24052875fa042a"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"77d9f65e3e7bf98a92f47d99432a68193fd17cf0","unresolved":false,"context_lines":[{"line_number":307,"context_line":"            if (is_update \u0026\u0026 (*push_update_option_flags \u0026 PUSH_OPT_OPTIONAL))"},{"line_number":308,"context_line":"            {"},{"line_number":309,"context_line":"                msg(D_PUSH, \"Pushed option removed by filter: \u0027%s\u0027\", line);"},{"line_number":310,"context_line":"                return true;"},{"line_number":311,"context_line":"            }"},{"line_number":312,"context_line":"            else"},{"line_number":313,"context_line":"            {"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"a7cb08ef_9c354e3e","line":310,"in_reply_to":"8689afde_5d9ee877","updated":"2025-07-23 17:11:24.000000000","message":"Acknowledged","commit_id":"bb7b02388e5bcc3a795a53900f24052875fa042a"}],"src/openvpn/push.c":[{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"933b29041908eeaea25a1a416ace3d69a5ba5071","unresolved":true,"context_lines":[{"line_number":540,"context_line":"            {"},{"line_number":541,"context_line":"                if (!option_types_found)"},{"line_number":542,"context_line":"                {"},{"line_number":543,"context_line":"                    msg(M_WARN, \"No option found\");"},{"line_number":544,"context_line":"                }"},{"line_number":545,"context_line":"            }"},{"line_number":546,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"8d650f48_e00d63e5","line":543,"updated":"2024-11-29 10:39:54.000000000","message":"This warning is a bit confusing.\n\n2024-11-29 10:58:57 us\u003d140000 PUSH: Received control message: \u0027PUSH_UPDATE,-dns\u0027\n2024-11-29 10:58:57 us\u003d140000 No option found\n\nIt is unclear what exactly does it mean and what user/admin is supposed to do with it.","commit_id":"1bebe2317442a311ed2073f75404c1b83d18fa95"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"0e1c700b7eb91a112f9e2c062eff3c636662b1c3","unresolved":true,"context_lines":[{"line_number":540,"context_line":"            {"},{"line_number":541,"context_line":"                if (!option_types_found)"},{"line_number":542,"context_line":"                {"},{"line_number":543,"context_line":"                    msg(M_WARN, \"No option found\");"},{"line_number":544,"context_line":"                }"},{"line_number":545,"context_line":"            }"},{"line_number":546,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"d1a9ecd3_e048bce9","line":543,"in_reply_to":"8d650f48_e00d63e5","updated":"2024-11-29 17:14:56.000000000","message":"I put it to avoid that in case of a correct message but without updates (something like \"PUSH_UPDATE,,\" or \"PUSH_UPDATE,?something_not_updatable\") there was a useless closing and reopening of the tun, but it is not a real error message, it is more of an info. I\u0027m not even sure it is the correct way to handle it, what do you suggest?","commit_id":"1bebe2317442a311ed2073f75404c1b83d18fa95"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"535e4d2d3c24b06f8425347d59b4732d22994ed1","unresolved":false,"context_lines":[{"line_number":540,"context_line":"            {"},{"line_number":541,"context_line":"                if (!option_types_found)"},{"line_number":542,"context_line":"                {"},{"line_number":543,"context_line":"                    msg(M_WARN, \"No option found\");"},{"line_number":544,"context_line":"                }"},{"line_number":545,"context_line":"            }"},{"line_number":546,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"29711b30_ad673ff1","line":543,"in_reply_to":"b5d51f26_68cd5be8","updated":"2024-12-03 11:06:38.000000000","message":"Ok then!","commit_id":"1bebe2317442a311ed2073f75404c1b83d18fa95"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"2a60b90f6ec049ac566609923def0059fe656175","unresolved":true,"context_lines":[{"line_number":540,"context_line":"            {"},{"line_number":541,"context_line":"                if (!option_types_found)"},{"line_number":542,"context_line":"                {"},{"line_number":543,"context_line":"                    msg(M_WARN, \"No option found\");"},{"line_number":544,"context_line":"                }"},{"line_number":545,"context_line":"            }"},{"line_number":546,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"b5d51f26_68cd5be8","line":543,"in_reply_to":"d1a9ecd3_e048bce9","updated":"2024-12-03 10:42:48.000000000","message":"How about \"No updatable options found in incoming PUSH_UPDATE message\" - I think it is verbose enough to let user/admin know what has happened.","commit_id":"1bebe2317442a311ed2073f75404c1b83d18fa95"}],"src/openvpn/push.h":[{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"62f8b2728ecea167f111bccf587c85bc1a78de86","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"int process_incoming_push_request(struct context *c);"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"int process_incoming_push_update(struct context *c,"},{"line_number":48,"context_line":"                                 unsigned int permission_mask,"},{"line_number":49,"context_line":"                                 unsigned int *option_types_found,"},{"line_number":50,"context_line":"                                 struct buffer *buf);"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"811984a2_89dbae3b","line":47,"updated":"2024-11-27 11:41:18.000000000","message":"Doxygen","commit_id":"8dc41435fdc48da8424e525162ba53954c9e9ada"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"c4faa112c0e451231a05b2400042b6e5d2506c1b","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"int process_incoming_push_request(struct context *c);"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"int process_incoming_push_update(struct context *c,"},{"line_number":48,"context_line":"                                 unsigned int permission_mask,"},{"line_number":49,"context_line":"                                 unsigned int *option_types_found,"},{"line_number":50,"context_line":"                                 struct buffer *buf);"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"276f3131_7f2768f9","line":47,"in_reply_to":"811984a2_89dbae3b","updated":"2024-11-28 15:21:49.000000000","message":"Done","commit_id":"8dc41435fdc48da8424e525162ba53954c9e9ada"}],"src/openvpn/push_util.c":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"f60c49234a20c0f50b45cc84b8c43fde1c543b86","unresolved":false,"context_lines":[{"line_number":20,"context_line":"                               permission_mask,"},{"line_number":21,"context_line":"                               option_types_found,"},{"line_number":22,"context_line":"                               c-\u003ec2.es,"},{"line_number":23,"context_line":"                               true))"},{"line_number":24,"context_line":"        {"},{"line_number":25,"context_line":"            switch (c-\u003eoptions.push_continuation)"},{"line_number":26,"context_line":"            {"}],"source_content_type":"text/x-csrc","patch_set":19,"id":"b8dd5363_84e249de","line":23,"updated":"2025-07-21 18:08:07.000000000","message":"Just for the record - this is the really-old-style OpenVPN formatting, which we no longer use.  That said, I know it\u0027s the same as in `process_incoming_push_reply()`, so it makes sense to keep it the same, and then clang-format will change both at once.","commit_id":"bb7b02388e5bcc3a795a53900f24052875fa042a"}],"tests/unit_tests/openvpn/Makefile.am":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"eb2136502581149b3a1b2cec2ffdf148c8fafb14","unresolved":true,"context_lines":[{"line_number":11,"context_line":"endif"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"test_binaries +\u003d crypto_testdriver packet_id_testdriver auth_token_testdriver ncp_testdriver misc_testdriver \\"},{"line_number":14,"context_line":"\tpkt_testdriver ssl_testdriver user_pass_testdriver push_update_msg_testdriver"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"if HAVE_LD_WRAP_SUPPORT"},{"line_number":17,"context_line":"if !WIN32"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"09ca4a05_8807ae01","line":14,"updated":"2024-11-26 17:40:07.000000000","message":"Please also add this test to CMakeLists.txt","commit_id":"f68ba837c8ba4d9ba804673e15f5478d37638880"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"70eba38f0848ad6d84f4b345b9f1c35059e50e73","unresolved":false,"context_lines":[{"line_number":11,"context_line":"endif"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"test_binaries +\u003d crypto_testdriver packet_id_testdriver auth_token_testdriver ncp_testdriver misc_testdriver \\"},{"line_number":14,"context_line":"\tpkt_testdriver ssl_testdriver user_pass_testdriver push_update_msg_testdriver"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"if HAVE_LD_WRAP_SUPPORT"},{"line_number":17,"context_line":"if !WIN32"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"bbdd5cb5_f48d4c7c","line":14,"in_reply_to":"09ca4a05_8807ae01","updated":"2024-11-27 10:45:33.000000000","message":"Done","commit_id":"f68ba837c8ba4d9ba804673e15f5478d37638880"}]}
