)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"5772b46f2e15d9f27a15d3399d8682aaef548b80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9bbb1e66_2f7247f5","updated":"2025-01-22 09:17:28.000000000","message":"I tested those 3 patches together - looks good. I was able to replace routes, remove routes, change IP address and revert it back. \n\nIt would me nice to make it work also for dco-win (which is a default driver) - at the moment we don\u0027t support reopening dco device - but this could be done later.","commit_id":"4ae969e7ff6239aad6179644e2b742e0ee312b1a"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"68d2f6c321ea24da46ebd38e0582016b04c0c4a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"6aef1cc2_0f97060c","updated":"2025-06-16 06:18:43.000000000","message":"JFTR: We have tested openvpn-gui 2.7alpha1 with push-update patches on top against corporate backend (CloudConnexa) which supports push-update server functionality. Looks good! Adding/removing routes and various DNS options works.","commit_id":"98cf7ca23a4ade53589c437fd7fddd67ee6c0a86"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"926253eb77676ac83f023b63ea8cd8ef278a4fcf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"b0bc63ff_36f66202","updated":"2025-07-21 19:21:15.000000000","message":"Nagging about code duplication...","commit_id":"a879c233e5c1394ebfcda73e65f8b4c386e89f08"}],"src/openvpn/options.c":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"926253eb77676ac83f023b63ea8cd8ef278a4fcf","unresolved":true,"context_lines":[{"line_number":5894,"context_line":"                    msg(msglevel, \"route parameter gateway \u0027%s\u0027 must be a valid address\", p[3]);"},{"line_number":5895,"context_line":"                    goto err;"},{"line_number":5896,"context_line":"                }"},{"line_number":5897,"context_line":"            }"},{"line_number":5898,"context_line":"            if (c-\u003ec1.route_list)"},{"line_number":5899,"context_line":"            {"},{"line_number":5900,"context_line":"                delete_routes_v4(c-\u003ec1.route_list, c-\u003ec1.tuntap,"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"e80b547e_689dbd50","line":5897,"updated":"2025-07-21 19:21:15.000000000","message":"I find this duplication of syntax checking, mmmh, sub-optimal.  We\u0027ll check the syntax anyway in `add_option()` later on...\n\nI could see user complaints about \"I sent a PUSH_UPDATE with one invalid `route` in it, and all my routes were lost\", but honestly, do we really care that much?  (If yes, we could consider moving the syntax check into a small helper, if not, just drop the lines from `rol_check_alloc()` up to this line).","commit_id":"a879c233e5c1394ebfcda73e65f8b4c386e89f08"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"ff288b23d65d41899f7a66a6c641b4f7ffaf92ba","unresolved":false,"context_lines":[{"line_number":5894,"context_line":"                    msg(msglevel, \"route parameter gateway \u0027%s\u0027 must be a valid address\", p[3]);"},{"line_number":5895,"context_line":"                    goto err;"},{"line_number":5896,"context_line":"                }"},{"line_number":5897,"context_line":"            }"},{"line_number":5898,"context_line":"            if (c-\u003ec1.route_list)"},{"line_number":5899,"context_line":"            {"},{"line_number":5900,"context_line":"                delete_routes_v4(c-\u003ec1.route_list, c-\u003ec1.tuntap,"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"edf64e35_8ed4afac","line":5897,"in_reply_to":"e80b547e_689dbd50","updated":"2025-07-23 17:12:03.000000000","message":"idk, i thought it were nice to make some checks before deleting the options. :)","commit_id":"a879c233e5c1394ebfcda73e65f8b4c386e89f08"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"926253eb77676ac83f023b63ea8cd8ef278a4fcf","unresolved":true,"context_lines":[{"line_number":5924,"context_line":"                    goto err;"},{"line_number":5925,"context_line":"                }"},{"line_number":5926,"context_line":"                /* p[3] is metric, if present */"},{"line_number":5927,"context_line":"            }"},{"line_number":5928,"context_line":"            if (c-\u003ec1.route_ipv6_list)"},{"line_number":5929,"context_line":"            {"},{"line_number":5930,"context_line":"                delete_routes_v6(c-\u003ec1.route_ipv6_list, c-\u003ec1.tuntap,"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"e1f5b5bd_f34b1d7f","line":5927,"updated":"2025-07-21 19:21:15.000000000","message":"same here","commit_id":"a879c233e5c1394ebfcda73e65f8b4c386e89f08"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"ff288b23d65d41899f7a66a6c641b4f7ffaf92ba","unresolved":false,"context_lines":[{"line_number":5924,"context_line":"                    goto err;"},{"line_number":5925,"context_line":"                }"},{"line_number":5926,"context_line":"                /* p[3] is metric, if present */"},{"line_number":5927,"context_line":"            }"},{"line_number":5928,"context_line":"            if (c-\u003ec1.route_ipv6_list)"},{"line_number":5929,"context_line":"            {"},{"line_number":5930,"context_line":"                delete_routes_v6(c-\u003ec1.route_ipv6_list, c-\u003ec1.tuntap,"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"6c0edd1d_f8769a03","line":5927,"in_reply_to":"e1f5b5bd_f34b1d7f","updated":"2025-07-23 17:12:03.000000000","message":"Done","commit_id":"a879c233e5c1394ebfcda73e65f8b4c386e89f08"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"926253eb77676ac83f023b63ea8cd8ef278a4fcf","unresolved":true,"context_lines":[{"line_number":6006,"context_line":"                msg(msglevel, \"--dns: unknown option type \u0027%s\u0027 or missing or unknown parameter\", p[1]);"},{"line_number":6007,"context_line":"                goto err;"},{"line_number":6008,"context_line":"            }"},{"line_number":6009,"context_line":""},{"line_number":6010,"context_line":"            gc_free(\u0026options-\u003edns_options.gc);"},{"line_number":6011,"context_line":"            CLEAR(options-\u003edns_options);"},{"line_number":6012,"context_line":"            *update_options_found |\u003d OPT_P_U_DNS;"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"4054ed13_3dac7037","line":6009,"updated":"2025-07-21 19:21:15.000000000","message":"same here... lots of code that needs to be in sync with the add_option() checks...","commit_id":"a879c233e5c1394ebfcda73e65f8b4c386e89f08"},{"author":{"_account_id":1000040,"name":"Marco Baffo","email":"marco@mandelbit.com","username":"mrbff"},"change_message_id":"ff288b23d65d41899f7a66a6c641b4f7ffaf92ba","unresolved":false,"context_lines":[{"line_number":6006,"context_line":"                msg(msglevel, \"--dns: unknown option type \u0027%s\u0027 or missing or unknown parameter\", p[1]);"},{"line_number":6007,"context_line":"                goto err;"},{"line_number":6008,"context_line":"            }"},{"line_number":6009,"context_line":""},{"line_number":6010,"context_line":"            gc_free(\u0026options-\u003edns_options.gc);"},{"line_number":6011,"context_line":"            CLEAR(options-\u003edns_options);"},{"line_number":6012,"context_line":"            *update_options_found |\u003d OPT_P_U_DNS;"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"af06b38c_73d23b39","line":6009,"in_reply_to":"4054ed13_3dac7037","updated":"2025-07-23 17:12:03.000000000","message":"Done","commit_id":"a879c233e5c1394ebfcda73e65f8b4c386e89f08"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"926253eb77676ac83f023b63ea8cd8ef278a4fcf","unresolved":false,"context_lines":[{"line_number":6042,"context_line":"#if defined(TARGET_ANDROID)"},{"line_number":6043,"context_line":"            o-\u003ehttp_proxy_port \u003d 0;"},{"line_number":6044,"context_line":"            o-\u003ehttp_proxy \u003d NULL;"},{"line_number":6045,"context_line":"#endif"},{"line_number":6046,"context_line":"            *update_options_found |\u003d OPT_P_U_DHCP;"},{"line_number":6047,"context_line":"        }"},{"line_number":6048,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":21,"id":"abc555fa_e0e5856c","line":6045,"updated":"2025-07-21 19:21:15.000000000","message":"I note a distinct lack of syntax checking for `dhcp-option` ;-)","commit_id":"a879c233e5c1394ebfcda73e65f8b4c386e89f08"}]}
