)]}'
{"src/openvpn/dco.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"297680b232b53245a81b51f8e56f95698a8f01c8","unresolved":true,"context_lines":[{"line_number":259,"context_line":"        return false;"},{"line_number":260,"context_line":"    }"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"#if defined(TARGET_FREEBSD) || defined(TARGET_WIN32)"},{"line_number":263,"context_line":"    if (!proto_is_udp(ce-\u003eproto))"},{"line_number":264,"context_line":"    {"},{"line_number":265,"context_line":"        msg(msglevel, \"NOTE: TCP transport disables data channel offload on FreeBSD and Windows.\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ea6d8bfb_23476f6c","line":262,"updated":"2024-11-22 14:33:34.000000000","message":"This change seems unrelated?","commit_id":"5f8425324eff155b06488da2b0808f8a09c11eea"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"a1722c91f0dfde9f3aabb16789897023ab8f9f6a","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        return false;"},{"line_number":260,"context_line":"    }"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"#if defined(TARGET_FREEBSD) || defined(TARGET_WIN32)"},{"line_number":263,"context_line":"    if (!proto_is_udp(ce-\u003eproto))"},{"line_number":264,"context_line":"    {"},{"line_number":265,"context_line":"        msg(msglevel, \"NOTE: TCP transport disables data channel offload on FreeBSD and Windows.\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"06f9bbbe_cf17d39c","line":262,"in_reply_to":"d2548157_0fe4db62","updated":"2024-11-22 15:56:18.000000000","message":"Done","commit_id":"5f8425324eff155b06488da2b0808f8a09c11eea"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"895bd22d019829cba53f0ae61d2e6db2cc8ad1bb","unresolved":true,"context_lines":[{"line_number":259,"context_line":"        return false;"},{"line_number":260,"context_line":"    }"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"#if defined(TARGET_FREEBSD) || defined(TARGET_WIN32)"},{"line_number":263,"context_line":"    if (!proto_is_udp(ce-\u003eproto))"},{"line_number":264,"context_line":"    {"},{"line_number":265,"context_line":"        msg(msglevel, \"NOTE: TCP transport disables data channel offload on FreeBSD and Windows.\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d2548157_0fe4db62","line":262,"in_reply_to":"ea6d8bfb_23476f6c","updated":"2024-11-22 15:06:58.000000000","message":"I would rather change commit message. The idea of this commit to enable DCO on mode server if the driver version supports it and disable for TCP protocol or unsupported driver version.","commit_id":"5f8425324eff155b06488da2b0808f8a09c11eea"}],"src/openvpn/dco_win.h":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"19a30a75896f42f78bf239e895866f2c8b3c7af3","unresolved":true,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"bool"},{"line_number":52,"context_line":"dco_win_supports_multipeer();"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"#else /* if defined(ENABLE_DCO) \u0026\u0026 defined(_WIN32) */"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"static inline void"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"b4eda8c8_bea9b960","line":53,"updated":"2024-12-29 14:43:52.000000000","message":"There is a `void` missing here.  MinGW complains\n\n```\ndco_win.h:52:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]\n   52 | dco_win_supports_multipeer();\n      | ^~~~~~~~~~~~~~~~~~~~~~~~~~\n```","commit_id":"bfe40cb759e20570fa867cfde777664479155cba"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"735a4eda725b3bde0580d4f4ce43ada4227ba8d3","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"bool"},{"line_number":52,"context_line":"dco_win_supports_multipeer();"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"#else /* if defined(ENABLE_DCO) \u0026\u0026 defined(_WIN32) */"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"static inline void"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"897bd504_e7979fd0","line":53,"in_reply_to":"b4eda8c8_bea9b960","updated":"2024-12-30 09:53:48.000000000","message":"Acknowledged","commit_id":"bfe40cb759e20570fa867cfde777664479155cba"}]}