)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"deaba3d470f767e822267859efa77d64d1399200","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Lev Stipakov \u003clev@openvpn.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-11-19 16:26:05 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"mudp.c: keep offset value when reset buffer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"dco-win requires control packets to be prepended"},{"line_number":10,"context_line":"with sockaddr. For that, an offset value in buffer"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e9f0fd7c_69e29b82","line":7,"updated":"2024-11-22 14:41:26.000000000","message":"\"resetting\"","commit_id":"52c62f1af3a272dfc396a99c315ce98b93f576b6"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"50defc64372d918cb5f03a5aa86138d080c0d453","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Lev Stipakov \u003clev@openvpn.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-11-19 16:26:05 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"mudp.c: keep offset value when reset buffer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"dco-win requires control packets to be prepended"},{"line_number":10,"context_line":"with sockaddr. For that, an offset value in buffer"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"535895da_8fa8d201","line":7,"in_reply_to":"e9f0fd7c_69e29b82","updated":"2024-11-22 15:35:43.000000000","message":"Acknowledged","commit_id":"52c62f1af3a272dfc396a99c315ce98b93f576b6"}],"src/openvpn/mudp.c":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"deaba3d470f767e822267859efa77d64d1399200","unresolved":true,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    struct context *c \u003d \u0026m-\u003etop;"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    /* dco-win server requres prepend with sockaddr, so preserve offset */"},{"line_number":58,"context_line":"    buf_init(\u0026c-\u003ec2.buffers-\u003eaux_buf, buf.offset);"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    buf_copy(\u0026c-\u003ec2.buffers-\u003eaux_buf, \u0026buf);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fcb8e952_68fe37ee","line":57,"updated":"2024-11-22 14:41:26.000000000","message":"\"requires\"","commit_id":"52c62f1af3a272dfc396a99c315ce98b93f576b6"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"50defc64372d918cb5f03a5aa86138d080c0d453","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    struct context *c \u003d \u0026m-\u003etop;"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    /* dco-win server requres prepend with sockaddr, so preserve offset */"},{"line_number":58,"context_line":"    buf_init(\u0026c-\u003ec2.buffers-\u003eaux_buf, buf.offset);"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    buf_copy(\u0026c-\u003ec2.buffers-\u003eaux_buf, \u0026buf);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c06e65ab_3f487764","line":57,"in_reply_to":"fcb8e952_68fe37ee","updated":"2024-11-22 15:35:43.000000000","message":"Acknowledged","commit_id":"52c62f1af3a272dfc396a99c315ce98b93f576b6"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"deaba3d470f767e822267859efa77d64d1399200","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    struct context *c \u003d \u0026m-\u003etop;"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    /* dco-win server requres prepend with sockaddr, so preserve offset */"},{"line_number":58,"context_line":"    buf_init(\u0026c-\u003ec2.buffers-\u003eaux_buf, buf.offset);"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    buf_copy(\u0026c-\u003ec2.buffers-\u003eaux_buf, \u0026buf);"},{"line_number":61,"context_line":"    m-\u003ehmac_reply \u003d c-\u003ec2.buffers-\u003eaux_buf;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"dfafbbbe_9d592c2d","line":58,"updated":"2024-11-22 14:41:26.000000000","message":"buf_init can fail (buf_reset_len cannot). Do we need error handling here?","commit_id":"52c62f1af3a272dfc396a99c315ce98b93f576b6"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"33cdc2a6e4a437cc8bea923cfc35f73eb3d1e0f6","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    struct context *c \u003d \u0026m-\u003etop;"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    /* dco-win server requres prepend with sockaddr, so preserve offset */"},{"line_number":58,"context_line":"    buf_init(\u0026c-\u003ec2.buffers-\u003eaux_buf, buf.offset);"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    buf_copy(\u0026c-\u003ec2.buffers-\u003eaux_buf, \u0026buf);"},{"line_number":61,"context_line":"    m-\u003ehmac_reply \u003d c-\u003ec2.buffers-\u003eaux_buf;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"36daad7c_ce89715f","line":58,"in_reply_to":"7b8a5279_1096f128","updated":"2024-11-22 15:36:19.000000000","message":"Acknowledged","commit_id":"52c62f1af3a272dfc396a99c315ce98b93f576b6"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"50defc64372d918cb5f03a5aa86138d080c0d453","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    struct context *c \u003d \u0026m-\u003etop;"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    /* dco-win server requres prepend with sockaddr, so preserve offset */"},{"line_number":58,"context_line":"    buf_init(\u0026c-\u003ec2.buffers-\u003eaux_buf, buf.offset);"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    buf_copy(\u0026c-\u003ec2.buffers-\u003eaux_buf, \u0026buf);"},{"line_number":61,"context_line":"    m-\u003ehmac_reply \u003d c-\u003ec2.buffers-\u003eaux_buf;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7b8a5279_1096f128","line":58,"in_reply_to":"dfafbbbe_9d592c2d","updated":"2024-11-22 15:35:43.000000000","message":"Will wrap it into ASSERT.","commit_id":"52c62f1af3a272dfc396a99c315ce98b93f576b6"},{"author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"b2bf1f3a0b246ebbace1e8f451959dd1a8e80833","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    struct context *c \u003d \u0026m-\u003etop;"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    /* dco-win server requires prepend with sockaddr, so preserve offset */"},{"line_number":58,"context_line":"    ASSERT(buf_init(\u0026c-\u003ec2.buffers-\u003eaux_buf, buf.offset));"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    buf_copy(\u0026c-\u003ec2.buffers-\u003eaux_buf, \u0026buf);"},{"line_number":61,"context_line":"    m-\u003ehmac_reply \u003d c-\u003ec2.buffers-\u003eaux_buf;"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"ef68c003_57b839a6","line":58,"updated":"2025-01-30 08:44:52.000000000","message":"under what circumstance do we expect this ASSERT to be triggered?\nI am always scared to introduce new ASSERTs because a temporary condition may lead the server to \"assert-out\" and this may not be nice.","commit_id":"a41fd8dabf8c5d233c43724d8bf82792d42e3d57"},{"author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"68f16ebabbc12166fd246fbe84b70fb2d7650f5d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    struct context *c \u003d \u0026m-\u003etop;"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    /* dco-win server requires prepend with sockaddr, so preserve offset */"},{"line_number":58,"context_line":"    ASSERT(buf_init(\u0026c-\u003ec2.buffers-\u003eaux_buf, buf.offset));"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    buf_copy(\u0026c-\u003ec2.buffers-\u003eaux_buf, \u0026buf);"},{"line_number":61,"context_line":"    m-\u003ehmac_reply \u003d c-\u003ec2.buffers-\u003eaux_buf;"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"7a94e11c_e3978f10","line":58,"in_reply_to":"5d94cc70_a4b520cc","updated":"2025-01-30 09:14:26.000000000","message":"Acknowledged","commit_id":"a41fd8dabf8c5d233c43724d8bf82792d42e3d57"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"98b77425c8ac3d1e256643af58d659d130ce9552","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    struct context *c \u003d \u0026m-\u003etop;"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    /* dco-win server requires prepend with sockaddr, so preserve offset */"},{"line_number":58,"context_line":"    ASSERT(buf_init(\u0026c-\u003ec2.buffers-\u003eaux_buf, buf.offset));"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    buf_copy(\u0026c-\u003ec2.buffers-\u003eaux_buf, \u0026buf);"},{"line_number":61,"context_line":"    m-\u003ehmac_reply \u003d c-\u003ec2.buffers-\u003eaux_buf;"}],"source_content_type":"text/x-csrc","patch_set":12,"id":"5d94cc70_a4b520cc","line":58,"in_reply_to":"ef68c003_57b839a6","updated":"2025-01-30 09:01:25.000000000","message":"buf_init() can in fail if there is not enough capacity, but it should not be the case. In fact, all buf_init() calls except one are wrapped into ASSERT.","commit_id":"a41fd8dabf8c5d233c43724d8bf82792d42e3d57"}]}
