)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"d8d9513d1220178c2ab609c1f405f17524e91bc0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"9c66f22e_b6f4c8f8","updated":"2025-02-20 07:23:04.000000000","message":"the code looks good and the tests confirm \"it works\".  I have a few minor nits, though.","commit_id":"b06b0b49eb0c33135dccdcb415055dab922ccf27"}],"src/openvpn/dco_win.c":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"d8d9513d1220178c2ab609c1f405f17524e91bc0","unresolved":true,"context_lines":[{"line_number":641,"context_line":"}"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"static void"},{"line_number":644,"context_line":"dco_handle_overlapped_success(dco_context_t *dco, bool queued)"},{"line_number":645,"context_line":"{"},{"line_number":646,"context_line":"    DWORD bytes_read \u003d 0;"},{"line_number":647,"context_line":"    BOOL res \u003d GetOverlappedResult(dco-\u003ett-\u003ehand, \u0026dco-\u003eov, \u0026bytes_read, FALSE);"}],"source_content_type":"text/x-csrc","patch_set":20,"id":"5d25f041_1b79d04b","line":644,"updated":"2025-02-20 07:23:04.000000000","message":"can you add a comment what this function does?  As a non-windows programmer I find `Overlapped` a foreign concept","commit_id":"b06b0b49eb0c33135dccdcb415055dab922ccf27"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"7a62d40575c270ed47c59d1334dfb3e53431767a","unresolved":true,"context_lines":[{"line_number":641,"context_line":"}"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"static void"},{"line_number":644,"context_line":"dco_handle_overlapped_success(dco_context_t *dco, bool queued)"},{"line_number":645,"context_line":"{"},{"line_number":646,"context_line":"    DWORD bytes_read \u003d 0;"},{"line_number":647,"context_line":"    BOOL res \u003d GetOverlappedResult(dco-\u003ett-\u003ehand, \u0026dco-\u003eov, \u0026bytes_read, FALSE);"}],"source_content_type":"text/x-csrc","patch_set":20,"id":"cf098fa0_497af99a","line":644,"in_reply_to":"5d25f041_1b79d04b","updated":"2025-02-20 08:06:41.000000000","message":"Will do.","commit_id":"b06b0b49eb0c33135dccdcb415055dab922ccf27"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"a444498c02d2e81a25c020788af2f0b0bdcfe06c","unresolved":false,"context_lines":[{"line_number":641,"context_line":"}"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"static void"},{"line_number":644,"context_line":"dco_handle_overlapped_success(dco_context_t *dco, bool queued)"},{"line_number":645,"context_line":"{"},{"line_number":646,"context_line":"    DWORD bytes_read \u003d 0;"},{"line_number":647,"context_line":"    BOOL res \u003d GetOverlappedResult(dco-\u003ett-\u003ehand, \u0026dco-\u003eov, \u0026bytes_read, FALSE);"}],"source_content_type":"text/x-csrc","patch_set":20,"id":"e3d1fe13_65c90d31","line":644,"in_reply_to":"cf098fa0_497af99a","updated":"2025-02-20 08:08:42.000000000","message":"Done","commit_id":"b06b0b49eb0c33135dccdcb415055dab922ccf27"}],"src/openvpn/mudp.c":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"d8d9513d1220178c2ab609c1f405f17524e91bc0","unresolved":true,"context_lines":[{"line_number":406,"context_line":"        multi_process_file_closed(m, mpp_flags);"},{"line_number":407,"context_line":"    }"},{"line_number":408,"context_line":"#endif"},{"line_number":409,"context_line":"#if defined(ENABLE_DCO) \u0026\u0026 (defined(TARGET_LINUX) || defined(TARGET_FREEBSD) || defined(TARGET_WIN32))"},{"line_number":410,"context_line":"    else if (status \u0026 DCO_READ)"},{"line_number":411,"context_line":"    {"},{"line_number":412,"context_line":"        if (!IS_SIG(\u0026m-\u003etop))"}],"source_content_type":"text/x-csrc","patch_set":20,"id":"d7e9b590_0c316b58","line":409,"updated":"2025-02-20 07:23:04.000000000","message":"this is a minor nitpick, but I find this line very long and hard to read now - can you wrap it?\n\n```\n#if defined(ENABLE_DCO) \\\n    \u0026\u0026 (defined(TARGET_LINUX) || defined(TARGET_FREEBSD) || defined(TARGET_WIN32))\n```","commit_id":"b06b0b49eb0c33135dccdcb415055dab922ccf27"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"7a62d40575c270ed47c59d1334dfb3e53431767a","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        multi_process_file_closed(m, mpp_flags);"},{"line_number":407,"context_line":"    }"},{"line_number":408,"context_line":"#endif"},{"line_number":409,"context_line":"#if defined(ENABLE_DCO) \u0026\u0026 (defined(TARGET_LINUX) || defined(TARGET_FREEBSD) || defined(TARGET_WIN32))"},{"line_number":410,"context_line":"    else if (status \u0026 DCO_READ)"},{"line_number":411,"context_line":"    {"},{"line_number":412,"context_line":"        if (!IS_SIG(\u0026m-\u003etop))"}],"source_content_type":"text/x-csrc","patch_set":20,"id":"835acd5c_18103b81","line":409,"in_reply_to":"d7e9b590_0c316b58","updated":"2025-02-20 08:06:41.000000000","message":"Done","commit_id":"b06b0b49eb0c33135dccdcb415055dab922ccf27"}],"src/openvpn/multi.c":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"d8d9513d1220178c2ab609c1f405f17524e91bc0","unresolved":true,"context_lines":[{"line_number":3228,"context_line":"}"},{"line_number":3229,"context_line":"#endif"},{"line_number":3230,"context_line":""},{"line_number":3231,"context_line":"#if defined(ENABLE_DCO) \u0026\u0026 (defined(TARGET_LINUX) || defined(TARGET_FREEBSD) || defined(TARGET_WIN32))"},{"line_number":3232,"context_line":"static void"},{"line_number":3233,"context_line":"process_incoming_del_peer(struct multi_context *m, struct multi_instance *mi,"},{"line_number":3234,"context_line":"                          dco_context_t *dco)"}],"source_content_type":"text/x-csrc","patch_set":20,"id":"3e9bcdb0_2f4ec1a0","line":3231,"updated":"2025-02-20 07:23:04.000000000","message":"same thing","commit_id":"b06b0b49eb0c33135dccdcb415055dab922ccf27"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"7a62d40575c270ed47c59d1334dfb3e53431767a","unresolved":false,"context_lines":[{"line_number":3228,"context_line":"}"},{"line_number":3229,"context_line":"#endif"},{"line_number":3230,"context_line":""},{"line_number":3231,"context_line":"#if defined(ENABLE_DCO) \u0026\u0026 (defined(TARGET_LINUX) || defined(TARGET_FREEBSD) || defined(TARGET_WIN32))"},{"line_number":3232,"context_line":"static void"},{"line_number":3233,"context_line":"process_incoming_del_peer(struct multi_context *m, struct multi_instance *mi,"},{"line_number":3234,"context_line":"                          dco_context_t *dco)"}],"source_content_type":"text/x-csrc","patch_set":20,"id":"899c1243_9d323748","line":3231,"in_reply_to":"3e9bcdb0_2f4ec1a0","updated":"2025-02-20 08:06:41.000000000","message":"Done","commit_id":"b06b0b49eb0c33135dccdcb415055dab922ccf27"}]}