)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"3d7dda52b871b6349eb8fd234017e9c7abbb9942","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1b41c379_ab594a91","updated":"2024-12-09 10:00:17.000000000","message":"Looked and the code and tested, it indeed sets DNS server address on a adapter specific key in the registry.","commit_id":"e886adfdf7439cc4928422e6cb52a606758c8709"}],"src/openvpnserv/interactive.c":[{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"e7a24c257263bc03d33eb335b6ddd333d79964b3","unresolved":true,"context_lines":[{"line_number":1745,"context_line":"        ? \"SYSTEM\\\\CurrentControlSet\\\\Services\\\\Tcpip6\\\\Parameters\\\\Interfaces\""},{"line_number":1746,"context_line":"        : \"SYSTEM\\\\CurrentControlSet\\\\Services\\\\Tcpip\\\\Parameters\\\\Interfaces\";"},{"line_number":1747,"context_line":""},{"line_number":1748,"context_line":"    LSTATUS err \u003d RegOpenKeyExA(HKEY_LOCAL_MACHINE, itfs_key, 0, KEY_ALL_ACCESS, key);"},{"line_number":1749,"context_line":"    if (err)"},{"line_number":1750,"context_line":"    {"},{"line_number":1751,"context_line":"        *key \u003d INVALID_HANDLE_VALUE;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"7e06254d_29fcb9b6","line":1748,"updated":"2024-12-04 17:56:22.000000000","message":"Here we use RegOpenKeyExA, and in the function below RegOpenKeyExW","commit_id":"e886adfdf7439cc4928422e6cb52a606758c8709"},{"author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"change_message_id":"74c670c44e539e765ec06aba6e3c6cbed591d600","unresolved":false,"context_lines":[{"line_number":1745,"context_line":"        ? \"SYSTEM\\\\CurrentControlSet\\\\Services\\\\Tcpip6\\\\Parameters\\\\Interfaces\""},{"line_number":1746,"context_line":"        : \"SYSTEM\\\\CurrentControlSet\\\\Services\\\\Tcpip\\\\Parameters\\\\Interfaces\";"},{"line_number":1747,"context_line":""},{"line_number":1748,"context_line":"    LSTATUS err \u003d RegOpenKeyExA(HKEY_LOCAL_MACHINE, itfs_key, 0, KEY_ALL_ACCESS, key);"},{"line_number":1749,"context_line":"    if (err)"},{"line_number":1750,"context_line":"    {"},{"line_number":1751,"context_line":"        *key \u003d INVALID_HANDLE_VALUE;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e62ec35c_ab8dd0b6","line":1748,"in_reply_to":"7e06254d_29fcb9b6","updated":"2024-12-04 22:12:35.000000000","message":"Yes, it is no problem. I always switch between A and W with the registry functions depending on either the subkey string (second argument) or in which format the data is that I write or which format I want when I read. It is mostly motivated by the possibility of the data containing non-ASCII characters.","commit_id":"e886adfdf7439cc4928422e6cb52a606758c8709"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"a1a600684d9f3b5130459fd851729cb93d8f7f2e","unresolved":false,"context_lines":[{"line_number":1745,"context_line":"        ? \"SYSTEM\\\\CurrentControlSet\\\\Services\\\\Tcpip6\\\\Parameters\\\\Interfaces\""},{"line_number":1746,"context_line":"        : \"SYSTEM\\\\CurrentControlSet\\\\Services\\\\Tcpip\\\\Parameters\\\\Interfaces\";"},{"line_number":1747,"context_line":""},{"line_number":1748,"context_line":"    LSTATUS err \u003d RegOpenKeyExA(HKEY_LOCAL_MACHINE, itfs_key, 0, KEY_ALL_ACCESS, key);"},{"line_number":1749,"context_line":"    if (err)"},{"line_number":1750,"context_line":"    {"},{"line_number":1751,"context_line":"        *key \u003d INVALID_HANDLE_VALUE;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"8ee2951f_d0d9d3e3","line":1748,"in_reply_to":"e62ec35c_ab8dd0b6","updated":"2024-12-05 11:46:51.000000000","message":"I see, it is just before we always either explicitly used W version or macro which is resolved into W. But since we pass DNS as a char string we use A version.","commit_id":"e886adfdf7439cc4928422e6cb52a606758c8709"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"947eefc61b470e97522f801bcac7bdde7610a1c5","unresolved":true,"context_lines":[{"line_number":1926,"context_line":"                RtlIpv4AddressToStringA(\u0026msg-\u003eaddr[i].ipv4, addrs + offset);"},{"line_number":1927,"context_line":"            }"},{"line_number":1928,"context_line":"            offset +\u003d strlen(addrs);"},{"line_number":1929,"context_line":"        }"},{"line_number":1930,"context_line":""},{"line_number":1931,"context_line":"        err \u003d SetNameServers(iid, msg-\u003efamily, addrs);"},{"line_number":1932,"context_line":"        if (err)"}],"source_content_type":"text/x-csrc","patch_set":13,"id":"34e70988_8404e3c3","line":1929,"updated":"2025-03-12 10:54:44.000000000","message":"I am a bit worried about this static buffer and no overflow check - if we ever increase the dns_cfg_message_t to `addr[8]`, will we remember to also increase the `CHAR addrs[256]` here?","commit_id":"8fecfc2a16debe469e7f0ab52622d689f38dd533"}]}