)]}'
{"id":"openvpn~827","triplet_id":"openvpn~master~I74a9eec4954f3f9d208792b6b34357571f76ae4c","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-12-11 18:44:13.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2024-12-11 17:13:20.000000000","reason":"\u003cGERRIT_ACCOUNT_1000002\u003e replied on the change","reason_account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-12-11 18:44:13.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I74a9eec4954f3f9d208792b6b34357571f76ae4c","subject":"forward: Fix potential unaligned access in drop_if_recursive_routing","status":"MERGED","created":"2024-12-10 11:44:32.000000000","updated":"2024-12-11 18:44:13.000000000","submitted":"2024-12-11 18:44:13.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"827","meta_rev_id":"d9c2ac527cfc6b77c1713c671c9bee3330c27545","_number":827,"virtual_id_number":827,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-12-10 11:44:33.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-12-10 11:44:33.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2024-12-11 14:23:26.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"1f9f7cbf16a18f93462c8480c387f051e5fbb415","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-12-10 11:44:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5ac033bcd649168d77e97e8dcb95dc9304da8bb9","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-12-11 14:23:26.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"64f59d9bd8be7cd15bd96629f2a284bcd263ef4d","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-12-11 14:25:53.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e0bf7c1406b07f2df8de1d0f23e4ca74f1454fb1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-12-11 16:28:32.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"faae2cd38dd3c1b93b6cd58b0399ee44996befe3","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-12-11 16:29:37.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"17ad0c77253e68010e584cb6bcf837f0f19bffa4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-12-11 16:57:20.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a1074c2f0d9ffc9c9a9ba19cd1d19f9d06d594c9","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-12-11 17:13:20.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"d9c2ac527cfc6b77c1713c671c9bee3330c27545","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-12-11 18:44:13.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"387c2076af14a0f1ba97b6ca0175d81d1e8391a5","revisions":{"c807bd87a9990b20efb967e07308fd559e2980d3":{"kind":"REWORK","_number":1,"created":"2024-12-10 11:44:32.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/27/827/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/27/827/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/827/1 \u0026\u0026 git checkout -b change-827 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/827/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/827/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/827/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/27/827/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/827/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ae82631be17ca8c49d356510c9e7709ddcf19db3","subject":"Fix memory leak in ntlm_support"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-12-10 11:42:27.000000000","tz":0},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-12-10 11:44:10.000000000","tz":0},"subject":"forward: Fix potential unaligned access in drop_if_recursive_routing","message":"forward: Fix potential unaligned access in drop_if_recursive_routing\n\nASAN error:\nforward.c:1433:13: runtime error: member access within\nmisaligned address 0x51e00002f52e for type\n\u0027const struct in6_addr\u0027, which requires 4 byte alignment\n\nChange-Id: I74a9eec4954f3f9d208792b6b34357571f76ae4c\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"a0f28ef84ce980120aaf892a16769dd7ca0d124a":{"kind":"REWORK","_number":2,"created":"2024-12-11 16:28:32.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/27/827/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/27/827/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/827/2 \u0026\u0026 git checkout -b change-827 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/827/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/827/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/827/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/27/827/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/827/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ae82631be17ca8c49d356510c9e7709ddcf19db3","subject":"Fix memory leak in ntlm_support"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-12-10 11:42:27.000000000","tz":0},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-12-11 16:28:09.000000000","tz":0},"subject":"forward: Fix potential unaligned access in drop_if_recursive_routing","message":"forward: Fix potential unaligned access in drop_if_recursive_routing\n\nASAN error:\nforward.c:1433:13: runtime error: member access within\nmisaligned address 0x51e00002f52e for type\n\u0027const struct in6_addr\u0027, which requires 4 byte alignment\n\nv2: Use memcmp instead of memcpy\n\nChange-Id: I74a9eec4954f3f9d208792b6b34357571f76ae4c\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"5194e5bb00a3ed42cdf2f458f82d7835adcef80c":{"kind":"REWORK","_number":3,"created":"2024-12-11 16:57:20.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/27/827/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/27/827/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/827/3 \u0026\u0026 git checkout -b change-827 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/827/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/827/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/827/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/27/827/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/827/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ae82631be17ca8c49d356510c9e7709ddcf19db3","subject":"Fix memory leak in ntlm_support"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-12-10 11:42:27.000000000","tz":0},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-12-11 16:56:54.000000000","tz":0},"subject":"forward: Fix potential unaligned access in drop_if_recursive_routing","message":"forward: Fix potential unaligned access in drop_if_recursive_routing\n\nASAN error:\nforward.c:1433:13: runtime error: member access within\nmisaligned address 0x51e00002f52e for type\n\u0027const struct in6_addr\u0027, which requires 4 byte alignment\n\nv2: Use memcmp instead of memcpy\n\nChange-Id: I74a9eec4954f3f9d208792b6b34357571f76ae4c\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"387c2076af14a0f1ba97b6ca0175d81d1e8391a5":{"kind":"REWORK","_number":4,"created":"2024-12-11 18:44:13.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/27/827/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/27/827/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/827/4 \u0026\u0026 git checkout -b change-827 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/827/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/827/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/827/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/27/827/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/827/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ae82631be17ca8c49d356510c9e7709ddcf19db3","subject":"Fix memory leak in ntlm_support"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-12-11 17:13:48.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-12-11 17:17:16.000000000","tz":60},"subject":"forward: Fix potential unaligned access in drop_if_recursive_routing","message":"forward: Fix potential unaligned access in drop_if_recursive_routing\n\nASAN error:\n   forward.c:1433:13: runtime error: member access within misaligned\n   address 0x51e00002f52e for type \u0027const struct in6_addr\u0027, which\n   requires 4 byte alignment\n\nreplace IN6_ARE_ADDR_EQUAL() which uses 32bit compares on Linux - alignment\nsensitive - with our own OPENVPN_IN6_ARE_ADDR_EQUAL() macro, which always\ndoes memcpy() and does not care for alignment.\n\nv2: Use memcmp instead of memcpy\n\nChange-Id: I74a9eec4954f3f9d208792b6b34357571f76ae4c\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20241211171349.8892-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30074.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}