)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ffce36c87807a775beae7032ca1ccc058d8cf93e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"babe52f3_fc578bf8","updated":"2024-12-10 17:35:16.000000000","message":"Some nitpicks","commit_id":"d3073cbcb21734d960a27c7e09c3c8fb2ff8c508"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"badc5efa44017b1586b33150580dcab8e0b5770b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b6ce8c43_9d3421cc","updated":"2024-12-27 12:19:13.000000000","message":"I have verified most of these changes with t_server_null tests (will try to put some of these in a patch for default test set). I haven\u0027t managed to trigger the NCP client-side message.","commit_id":"52fb8a7b218ccac22ca7fe757bb1c69413549470"}],"doc/man-sections/protocol-options.rst":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ffce36c87807a775beae7032ca1ccc058d8cf93e","unresolved":true,"context_lines":[{"line_number":178,"context_line":"  Chacha20-Poly1305 if the underlying SSL library (and its configuration)"},{"line_number":179,"context_line":"  supports it."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"  Starting with OpenVPN 2.7 the special keyword DEFAULT can be used in the"},{"line_number":182,"context_line":"  string and is replaced by the default ciphers.  This can be used add"},{"line_number":183,"context_line":"  an additional allowed cipher to the allowed ciphers, e.g."},{"line_number":184,"context_line":"  :code:`DEFAULT:AES-192-CBC` to use the default ciphers but also allow"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f75330f_045154c7","line":181,"updated":"2024-12-10 17:35:16.000000000","message":"Probably makes sense to use ``DEFAULT`` here.","commit_id":"d3073cbcb21734d960a27c7e09c3c8fb2ff8c508"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"0eb8aebb5097b3c0686a7ebd9ecf56fd06310762","unresolved":false,"context_lines":[{"line_number":178,"context_line":"  Chacha20-Poly1305 if the underlying SSL library (and its configuration)"},{"line_number":179,"context_line":"  supports it."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"  Starting with OpenVPN 2.7 the special keyword DEFAULT can be used in the"},{"line_number":182,"context_line":"  string and is replaced by the default ciphers.  This can be used add"},{"line_number":183,"context_line":"  an additional allowed cipher to the allowed ciphers, e.g."},{"line_number":184,"context_line":"  :code:`DEFAULT:AES-192-CBC` to use the default ciphers but also allow"}],"source_content_type":"text/x-rst","patch_set":1,"id":"51d7502e_31b1c083","line":181,"in_reply_to":"5f75330f_045154c7","updated":"2024-12-19 18:05:32.000000000","message":"Done","commit_id":"d3073cbcb21734d960a27c7e09c3c8fb2ff8c508"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"dc311a32b42a244da89d96e317a17dc32d02dc16","unresolved":true,"context_lines":[{"line_number":179,"context_line":"  supports it."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"  Starting with OpenVPN 2.7 the special keyword :code:`DEFAULT` can be used"},{"line_number":182,"context_line":"  in the string and is replaced by the default ciphers.  This can be used add"},{"line_number":183,"context_line":"  an additional allowed cipher to the allowed ciphers, e.g."},{"line_number":184,"context_line":"  :code:`DEFAULT:AES-192-CBC` to use the default ciphers but also allow"},{"line_number":185,"context_line":"  :code:`AES-192-CBC`."}],"source_content_type":"text/x-rst","patch_set":2,"id":"4c40e0f4_68200bc3","line":182,"updated":"2024-12-23 17:19:03.000000000","message":"\"used to add\"","commit_id":"b7da0560a3745337f21aafad2d9a86e6e10ac1d3"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"cb72c95a96ce02bd0e5bdc6023d2572dd780f766","unresolved":false,"context_lines":[{"line_number":179,"context_line":"  supports it."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"  Starting with OpenVPN 2.7 the special keyword :code:`DEFAULT` can be used"},{"line_number":182,"context_line":"  in the string and is replaced by the default ciphers.  This can be used add"},{"line_number":183,"context_line":"  an additional allowed cipher to the allowed ciphers, e.g."},{"line_number":184,"context_line":"  :code:`DEFAULT:AES-192-CBC` to use the default ciphers but also allow"},{"line_number":185,"context_line":"  :code:`AES-192-CBC`."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5ea6674a_c7c1e0f3","line":182,"in_reply_to":"4c40e0f4_68200bc3","updated":"2024-12-23 19:52:26.000000000","message":"Acknowledged","commit_id":"b7da0560a3745337f21aafad2d9a86e6e10ac1d3"}],"src/openvpn/multi.c":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ffce36c87807a775beae7032ca1ccc058d8cf93e","unresolved":true,"context_lines":[{"line_number":1902,"context_line":"    else if (tls_multi-\u003eremote_ciphername)"},{"line_number":1903,"context_line":"    {"},{"line_number":1904,"context_line":"        msg(M_INFO, \"PUSH: No common cipher between server and client. \""},{"line_number":1905,"context_line":"            \"Server data-ciphers: \u0027%s\u0027%s, client supports cipher \u0027%s\u0027\","},{"line_number":1906,"context_line":"            o-\u003encp_ciphers_conf, ncp_expanded_ciphers(o, \u0026gc),"},{"line_number":1907,"context_line":"            tls_multi-\u003eremote_ciphername);"},{"line_number":1908,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9501c1ac_eab351db","line":1905,"updated":"2024-12-10 17:35:16.000000000","message":"make consistent with the other case. Either \u0027%s%s\u0027 or \u0027%s\u0027%s, but not both.","commit_id":"d3073cbcb21734d960a27c7e09c3c8fb2ff8c508"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"0eb8aebb5097b3c0686a7ebd9ecf56fd06310762","unresolved":false,"context_lines":[{"line_number":1902,"context_line":"    else if (tls_multi-\u003eremote_ciphername)"},{"line_number":1903,"context_line":"    {"},{"line_number":1904,"context_line":"        msg(M_INFO, \"PUSH: No common cipher between server and client. \""},{"line_number":1905,"context_line":"            \"Server data-ciphers: \u0027%s\u0027%s, client supports cipher \u0027%s\u0027\","},{"line_number":1906,"context_line":"            o-\u003encp_ciphers_conf, ncp_expanded_ciphers(o, \u0026gc),"},{"line_number":1907,"context_line":"            tls_multi-\u003eremote_ciphername);"},{"line_number":1908,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d1714501_fb5ceee1","line":1905,"in_reply_to":"9501c1ac_eab351db","updated":"2024-12-19 18:05:32.000000000","message":"Done","commit_id":"d3073cbcb21734d960a27c7e09c3c8fb2ff8c508"}],"src/openvpn/ssl_ncp.c":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ffce36c87807a775beae7032ca1ccc058d8cf93e","unresolved":true,"context_lines":[{"line_number":534,"context_line":"}"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"/**"},{"line_number":537,"context_line":" * Replaces the string DEFAULT with the string \\param replace. The"},{"line_number":538,"context_line":" * @param o         Options struct to modify and to use the gc from"},{"line_number":539,"context_line":" * @param replace   string used to replace the DEFAULT string"},{"line_number":540,"context_line":" */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c25085e2_a57ade0c","line":537,"updated":"2024-12-10 17:35:16.000000000","message":"\\p","commit_id":"d3073cbcb21734d960a27c7e09c3c8fb2ff8c508"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"0eb8aebb5097b3c0686a7ebd9ecf56fd06310762","unresolved":false,"context_lines":[{"line_number":534,"context_line":"}"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"/**"},{"line_number":537,"context_line":" * Replaces the string DEFAULT with the string \\param replace. The"},{"line_number":538,"context_line":" * @param o         Options struct to modify and to use the gc from"},{"line_number":539,"context_line":" * @param replace   string used to replace the DEFAULT string"},{"line_number":540,"context_line":" */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"711f6f13_504c6970","line":537,"in_reply_to":"c25085e2_a57ade0c","updated":"2024-12-19 18:05:32.000000000","message":"Done","commit_id":"d3073cbcb21734d960a27c7e09c3c8fb2ff8c508"}],"src/openvpn/ssl_ncp.h":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ffce36c87807a775beae7032ca1ccc058d8cf93e","unresolved":true,"context_lines":[{"line_number":171,"context_line":" *  (AES-256-GCM:CHACHA20-POLY1305) if o-\u003encp_ciphers_conf"},{"line_number":172,"context_line":" *  and o-\u003encp_ciphers differ, otherwise an empty string"},{"line_number":173,"context_line":" *"},{"line_number":174,"context_line":" *  The returned string will be allocated in the passed \\param gc"},{"line_number":175,"context_line":" *"},{"line_number":176,"context_line":" */"},{"line_number":177,"context_line":"const char *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1d04131f_fb1c7b2c","line":174,"updated":"2024-12-10 17:35:16.000000000","message":"If you want to format a word as param use \\p, \\param is for documenting parameters.","commit_id":"d3073cbcb21734d960a27c7e09c3c8fb2ff8c508"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"0eb8aebb5097b3c0686a7ebd9ecf56fd06310762","unresolved":false,"context_lines":[{"line_number":171,"context_line":" *  (AES-256-GCM:CHACHA20-POLY1305) if o-\u003encp_ciphers_conf"},{"line_number":172,"context_line":" *  and o-\u003encp_ciphers differ, otherwise an empty string"},{"line_number":173,"context_line":" *"},{"line_number":174,"context_line":" *  The returned string will be allocated in the passed \\param gc"},{"line_number":175,"context_line":" *"},{"line_number":176,"context_line":" */"},{"line_number":177,"context_line":"const char *"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0e004a12_dc41d0f5","line":174,"in_reply_to":"1d04131f_fb1c7b2c","updated":"2024-12-19 18:05:32.000000000","message":"I will use \\c since \\c and \\p are the same according to documentation and seem to use \\c rather than \\p in OpenVPN 2.x","commit_id":"d3073cbcb21734d960a27c7e09c3c8fb2ff8c508"}],"tests/unit_tests/openvpn/test_ncp.c":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ffce36c87807a775beae7032ca1ccc058d8cf93e","unresolved":true,"context_lines":[{"line_number":353,"context_line":"}"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"static void"},{"line_number":356,"context_line":"test_ncp_expand(void **state)"},{"line_number":357,"context_line":"{"},{"line_number":358,"context_line":"    bool have_chacha \u003d cipher_valid(\"CHACHA20-POLY1305\");"},{"line_number":359,"context_line":"    struct options o \u003d {0};"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"87f080cb_fef0e6b6","line":356,"updated":"2024-12-10 17:35:16.000000000","message":"I would suggest to add a testcase here where ncp_cipher_conf contains DEFAULT but is not equal to DEFAULT.","commit_id":"d3073cbcb21734d960a27c7e09c3c8fb2ff8c508"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"0eb8aebb5097b3c0686a7ebd9ecf56fd06310762","unresolved":false,"context_lines":[{"line_number":353,"context_line":"}"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"static void"},{"line_number":356,"context_line":"test_ncp_expand(void **state)"},{"line_number":357,"context_line":"{"},{"line_number":358,"context_line":"    bool have_chacha \u003d cipher_valid(\"CHACHA20-POLY1305\");"},{"line_number":359,"context_line":"    struct options o \u003d {0};"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b36dcfd7_095812e3","line":356,"in_reply_to":"87f080cb_fef0e6b6","updated":"2024-12-19 18:05:32.000000000","message":"added","commit_id":"d3073cbcb21734d960a27c7e09c3c8fb2ff8c508"}]}