)]}'
{"id":"openvpn~828","triplet_id":"openvpn~master~Ia1c5209022d3ab4c0dac6438c41891c7d059f812","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-12-31 16:51:13.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-12-27 12:19:13.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}},"hashtags":["mailsubmitted"],"change_id":"Ia1c5209022d3ab4c0dac6438c41891c7d059f812","subject":"Allow DEFAULT in data-ciphers and report both expanded and user set option","status":"MERGED","created":"2024-12-10 12:18:04.000000000","updated":"2024-12-31 16:51:13.000000000","submitted":"2024-12-31 16:51:13.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":14,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"828","meta_rev_id":"e55a247ceb2ba216072caf09febec592996db1bf","_number":828,"virtual_id_number":828,"owner":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-12-10 12:18:04.000000000","updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-12-10 12:18:04.000000000","updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"d2ffb19848bed22149b3a1c787481176bf9d9137","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-12-10 12:18:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ffce36c87807a775beae7032ca1ccc058d8cf93e","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-12-10 17:35:16.000000000","message":"Patch Set 1: Code-Review-1\n\n(6 comments)","accounts_in_message":[],"_revision_number":1},{"id":"0eb8aebb5097b3c0686a7ebd9ecf56fd06310762","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-12-19 18:05:32.000000000","message":"Patch Set 1:\n\n(5 comments)","accounts_in_message":[],"_revision_number":1},{"id":"639a172e5ced3c76402c8ac2e8c1666e4cd625e3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-12-19 18:05:50.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"dc311a32b42a244da89d96e317a17dc32d02dc16","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-12-23 17:19:03.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"cb72c95a96ce02bd0e5bdc6023d2572dd780f766","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-12-23 19:52:26.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"3e525589cf19f15aa027b90100ce416d47d57a9f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-12-23 19:55:19.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"badc5efa44017b1586b33150580dcab8e0b5770b","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-12-27 12:19:13.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"63fb1fe8a152bebdcadb447c31d61283aa21c6a4","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-12-27 12:46:42.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":3},{"id":"e55a247ceb2ba216072caf09febec592996db1bf","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-12-31 16:51:13.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"6a7931a4a89cb35be7b799942e7fa03fde2cdc63","revisions":{"d3073cbcb21734d960a27c7e09c3c8fb2ff8c508":{"kind":"REWORK","_number":1,"created":"2024-12-10 12:18:04.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/28/828/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/28/828/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/828/1 \u0026\u0026 git checkout -b change-828 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/828/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/828/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/828/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/28/828/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/828/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ae82631be17ca8c49d356510c9e7709ddcf19db3","subject":"Fix memory leak in ntlm_support"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-12-10 11:53:14.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-12-10 12:12:50.000000000","tz":60},"subject":"Allow DEFAULT in data-ciphers and report both expanded and user set option","message":"Allow DEFAULT in data-ciphers and report both expanded and user set option\n\nThis adds support for parsing DEFAULT in data-ciphers, the idea is that people\ncan modify the default without repeating the default ciphers.\n\nIn the past we have seem that people will use data-ciphers BF-CBC or\ndata-ciphers AES-128-CBC when getting the warning that the cipher is not\nsupported by the server.  This commit aims to provide a better way for\nthese situation as we still want people to rely on default cipher selection\nfrom OpenVPN when possible.\n\nChange-Id: Ia1c5209022d3ab4c0dac6438c41891c7d059f812\n"},"branch":"refs/heads/master"},"b7da0560a3745337f21aafad2d9a86e6e10ac1d3":{"kind":"REWORK","_number":2,"created":"2024-12-19 18:05:50.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/28/828/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/28/828/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/828/2 \u0026\u0026 git checkout -b change-828 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/828/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/828/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/828/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/28/828/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/828/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"baa9192851006e2dbb90b410011e61ecf2e01870","subject":"Use XOR instead of concatenation for calculation of IV from implicit IV"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-12-10 11:53:14.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-12-19 18:04:44.000000000","tz":60},"subject":"Allow DEFAULT in data-ciphers and report both expanded and user set option","message":"Allow DEFAULT in data-ciphers and report both expanded and user set option\n\nThis adds support for parsing DEFAULT in data-ciphers, the idea is that people\ncan modify the default without repeating the default ciphers.\n\nIn the past we have seem that people will use data-ciphers BF-CBC or\ndata-ciphers AES-128-CBC when getting the warning that the cipher is not\nsupported by the server.  This commit aims to provide a better way for\nthese situation as we still want people to rely on default cipher selection\nfrom OpenVPN when possible.\n\nChange-Id: Ia1c5209022d3ab4c0dac6438c41891c7d059f812\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"52fb8a7b218ccac22ca7fe757bb1c69413549470":{"kind":"REWORK","_number":3,"created":"2024-12-23 19:55:19.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/28/828/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/28/828/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/828/3 \u0026\u0026 git checkout -b change-828 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/828/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/828/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/828/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/28/828/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/828/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f0c26b02a7e394287052d524ef6d6bc738635692","subject":"Move initialisation of implicit IVs to init_key_ctx_bi methods"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-12-10 11:53:14.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-12-23 19:54:59.000000000","tz":60},"subject":"Allow DEFAULT in data-ciphers and report both expanded and user set option","message":"Allow DEFAULT in data-ciphers and report both expanded and user set option\n\nThis adds support for parsing DEFAULT in data-ciphers, the idea is that people\ncan modify the default without repeating the default ciphers.\n\nIn the past we have seem that people will use data-ciphers BF-CBC or\ndata-ciphers AES-128-CBC when getting the warning that the cipher is not\nsupported by the server.  This commit aims to provide a better way for\nthese situation as we still want people to rely on default cipher selection\nfrom OpenVPN when possible.\n\nChange-Id: Ia1c5209022d3ab4c0dac6438c41891c7d059f812\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"6a7931a4a89cb35be7b799942e7fa03fde2cdc63":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2024-12-31 16:51:13.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/28/828/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/28/828/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/828/4 \u0026\u0026 git checkout -b change-828 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/828/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/828/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/828/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/28/828/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/28/828/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1452625bc364cb5847daedaad238c7a5eb3eff5e","subject":"dco-win: simplify do_close_link_socket()"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-12-27 12:46:32.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-12-31 16:42:52.000000000","tz":60},"subject":"Allow DEFAULT in data-ciphers and report both expanded and user set option","message":"Allow DEFAULT in data-ciphers and report both expanded and user set option\n\nThis adds support for parsing DEFAULT in data-ciphers, the idea is that people\ncan modify the default without repeating the default ciphers.\n\nIn the past we have seem that people will use data-ciphers BF-CBC or\ndata-ciphers AES-128-CBC when getting the warning that the cipher is not\nsupported by the server.  This commit aims to provide a better way for\nthese situation as we still want people to rely on default cipher selection\nfrom OpenVPN when possible.\n\nChange-Id: Ia1c5209022d3ab4c0dac6438c41891c7d059f812\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20241227124632.110920-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30245.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}