)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"7696de825af26e82cee663ee33ed433e1127d49d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dd1ecf2f_649b8030","updated":"2025-01-23 12:59:59.000000000","message":"I can see what you are aiming for, but do not like the way this is done today - it\u0027s basically duplicating the same code + same message multiple times in otherwise not DCO related code.\n\nCan we print the message *inside* `dco_get_peer_stats()` (\u003d one single place), to start with?  And maybe some more clever way to register the `SIGUSR1`?","commit_id":"c5474896af9e1f075123fb7b743af86f2a680367"},{"author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"change_message_id":"19eca9a8406890741538eeee19f12a52320e2198","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"683a68fd_940e6b40","in_reply_to":"dd1ecf2f_649b8030","updated":"2025-01-23 16:50:30.000000000","message":"As you suggested on irc I added a boolean parameter to dco_get_peer_stats(_multi)(). Anyway I\u0027m not sure how can I raise the signal differently.","commit_id":"c5474896af9e1f075123fb7b743af86f2a680367"}],"src/openvpn/sig.c":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"93a076e9818b8337bcb5ab700f345ea5d065c6b6","unresolved":true,"context_lines":[{"line_number":492,"context_line":"        const int stats_request \u003d dco_get_peer_stats(c);"},{"line_number":493,"context_line":"        if (stats_request \u003c 0)"},{"line_number":494,"context_line":"        {"},{"line_number":495,"context_line":"            msg(M_WARN, \"Error requesting peer %d DCO stats (%s). Restarting the session\","},{"line_number":496,"context_line":"                c-\u003ec2.tls_multi-\u003edco_peer_id, strerror(-stats_request));"},{"line_number":497,"context_line":"            register_signal(c-\u003esig, SIGUSR1, \"dco peer stats error\");"},{"line_number":498,"context_line":"            return;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2680885b_1241b5c7","line":495,"updated":"2025-01-23 12:59:15.000000000","message":"Might to give some user understandable reason/guidance. I would not know what to expect here. Is this normal? Is this a problem? Do I have to worry and look to debug some deeper underlying problem?","commit_id":"c5474896af9e1f075123fb7b743af86f2a680367"},{"author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"change_message_id":"19eca9a8406890741538eeee19f12a52320e2198","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        const int stats_request \u003d dco_get_peer_stats(c);"},{"line_number":493,"context_line":"        if (stats_request \u003c 0)"},{"line_number":494,"context_line":"        {"},{"line_number":495,"context_line":"            msg(M_WARN, \"Error requesting peer %d DCO stats (%s). Restarting the session\","},{"line_number":496,"context_line":"                c-\u003ec2.tls_multi-\u003edco_peer_id, strerror(-stats_request));"},{"line_number":497,"context_line":"            register_signal(c-\u003esig, SIGUSR1, \"dco peer stats error\");"},{"line_number":498,"context_line":"            return;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"990397a3_da23205f","line":495,"in_reply_to":"2680885b_1241b5c7","updated":"2025-01-23 16:50:30.000000000","message":"Done","commit_id":"c5474896af9e1f075123fb7b743af86f2a680367"}]}