)]}'
{"id":"openvpn~831","triplet_id":"openvpn~master~Ib118426c5a69256894040c69856a4003d9f4637c","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-03-08 08:39:16.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-03-08 08:39:16.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-03-05 15:17:08.000000000","reason":"removed on reply"},"1000041":{"account":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"last_update":"2025-03-08 08:39:16.000000000","reason":"Change was submitted"}},"hashtags":["mailsubmitted"],"change_id":"Ib118426c5a69256894040c69856a4003d9f4637c","subject":"Handle missing DCO peer by restarting the session","status":"MERGED","created":"2024-12-10 16:53:29.000000000","updated":"2025-03-08 08:39:16.000000000","submitted":"2025-03-08 08:39:16.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"831","meta_rev_id":"476087e71d118f21a2d6b0a02f0f7af6d297876e","_number":831,"virtual_id_number":831,"owner":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-12-10 16:53:30.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-12-10 16:53:30.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2024-12-10 16:53:30.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-01-23 12:59:59.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"0d4bc6be178c55ba292ad3e3d68f10897c6c92b3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2024-12-10 16:53:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"93a076e9818b8337bcb5ab700f345ea5d065c6b6","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-01-23 12:59:15.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7696de825af26e82cee663ee33ed433e1127d49d","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-01-23 12:59:59.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6a02f0526c863563cc956f05e51e142343d0a664","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2025-01-23 16:43:25.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"19eca9a8406890741538eeee19f12a52320e2198","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2025-01-23 16:50:30.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"6435e505ae762899b16244061c8677b4ecba1f6b","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-03-05 15:17:08.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"2c82891314e1b877c847ea25aa2b97f729d582df","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"real_author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-03-05 15:17:54.000000000","message":"Patch Set 3: Patch Set 2 was rebased on behalf of \u003cGERRIT_ACCOUNT_1000041\u003e\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"}],"_revision_number":3},{"id":"19422bc8403e2472d38b3c46fbf4d8fe91c76bc7","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-03-05 17:17:42.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":3},{"id":"476087e71d118f21a2d6b0a02f0f7af6d297876e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-03-08 08:39:16.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"6f9ba8bfd259742ee19b173898a9bfd20e22fcf3","revisions":{"c5474896af9e1f075123fb7b743af86f2a680367":{"kind":"REWORK","_number":1,"created":"2024-12-10 16:53:29.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/31/831/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/31/831/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/31/831/1 \u0026\u0026 git checkout -b change-831 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/31/831/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/31/831/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/31/831/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/31/831/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/31/831/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ae82631be17ca8c49d356510c9e7709ddcf19db3","subject":"Fix memory leak in ntlm_support"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2024-10-31 15:13:12.000000000","tz":60},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2024-12-10 16:49:59.000000000","tz":60},"subject":"Handle missing DCO peer by restarting the session","message":"Handle missing DCO peer by restarting the session\n\nOccasionally, CMD_DEL_PEER is not delivered to userspace, preventing the\nopenvpn process from registering the event. To handle this case, we\ncheck if calls to the DCO module return an error, and, if so, send a\nSIGUSR1 signal to reset the session.\n\nChange-Id: Ib118426c5a69256894040c69856a4003d9f4637c\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"9d122fbfd51e84fed46e0424ac11dbfece9cd401":{"kind":"REWORK","_number":2,"created":"2025-01-23 16:43:25.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/31/831/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/31/831/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/31/831/2 \u0026\u0026 git checkout -b change-831 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/31/831/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/31/831/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/31/831/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/31/831/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/31/831/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5cea4bc75e1b87ec7225a89b7cf5cadb85e77e8a","subject":"IPv6 MADDR LOG: Wrap IPv6 addresses in square brackets and print port when the port is specified"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2024-10-31 15:13:12.000000000","tz":60},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-01-23 15:59:05.000000000","tz":60},"subject":"Handle missing DCO peer by restarting the session","message":"Handle missing DCO peer by restarting the session\n\nOccasionally, CMD_DEL_PEER is not delivered to userspace, preventing the\nopenvpn process from registering the event. To handle this case, we\ncheck if calls to the Linux DCO module return an error, and, if so, send\na SIGUSR1 signal to reset the session.\n\nMost DCO commands that return an error already trigger a SIGUSR1 signal\nor even call _exit(1). This commit extends that behavior to include\ndco_get_peer_stats_multi() and dco_get_peer_stats().\n\nChange-Id: Ib118426c5a69256894040c69856a4003d9f4637c\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"e89cd687e834d3a31526cc98830216f02adac7da":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-03-05 15:17:54.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"real_uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/31/831/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/31/831/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/31/831/3 \u0026\u0026 git checkout -b change-831 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/31/831/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/31/831/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/31/831/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/31/831/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/31/831/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fed37d003d9cbc9e7c3ea5fdd0f0a287f4cee538","subject":"Add more \u0027intentional fallthrough\u0027 comments"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2024-10-31 15:13:12.000000000","tz":60},"committer":{"name":"ralf_lici","email":"ralf@mandelbit.com","date":"2025-03-05 15:17:54.000000000","tz":0},"subject":"Handle missing DCO peer by restarting the session","message":"Handle missing DCO peer by restarting the session\n\nOccasionally, CMD_DEL_PEER is not delivered to userspace, preventing the\nopenvpn process from registering the event. To handle this case, we\ncheck if calls to the Linux DCO module return an error, and, if so, send\na SIGUSR1 signal to reset the session.\n\nMost DCO commands that return an error already trigger a SIGUSR1 signal\nor even call _exit(1). This commit extends that behavior to include\ndco_get_peer_stats_multi() and dco_get_peer_stats().\n\nChange-Id: Ib118426c5a69256894040c69856a4003d9f4637c\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master","description":"Rebase"},"6f9ba8bfd259742ee19b173898a9bfd20e22fcf3":{"kind":"REWORK","_number":4,"created":"2025-03-08 08:39:16.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/31/831/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/31/831/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/31/831/4 \u0026\u0026 git checkout -b change-831 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/31/831/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/31/831/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/31/831/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/31/831/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/31/831/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7e5535289908af23bed244e7f0417358f2f316bc","subject":"Rename occurences of \u0027struct link_socket\u0027 from \u0027ls\u0027 to \u0027sock\u0027"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-03-05 17:17:30.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-03-08 08:33:48.000000000","tz":60},"subject":"Handle missing DCO peer by restarting the session","message":"Handle missing DCO peer by restarting the session\n\nOccasionally, CMD_DEL_PEER is not delivered to userspace, preventing the\nopenvpn process from registering the event. To handle this case, we\ncheck if calls to the Linux DCO module return an error, and, if so, send\na SIGUSR1 signal to reset the session.\n\nMost DCO commands that return an error already trigger a SIGUSR1 signal\nor even call _exit(1). This commit extends that behavior to include\ndco_get_peer_stats_multi() and dco_get_peer_stats().\n\nChange-Id: Ib118426c5a69256894040c69856a4003d9f4637c\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20250305171730.250444-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31022.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}