)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"7c377eddfaee2d48b524c71552b408cfc0c7e9f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"877a22d4_f39c135c","updated":"2025-01-17 13:57:45.000000000","message":"Change seems relatively straight-forward. But obviously this will potentially confuse existing scripts out there. Maybe you could add a change for Changes.rst, that describes the behavioral changes. So that we do not forget to communicate this.","commit_id":"c80f7625c77101090b72f35b8c0d737178f84289"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"f0da4ae58473e8fd85b379219bbec5bc728f2afc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6bec2adc_311bee30","updated":"2025-01-21 16:48:30.000000000","message":"That seems to be precisely the discussion we had in Karlsruhe - breaking existing script hooks just because the new approach is considered \"better\" is not going to make anyone happy.  So I\u0027m fairly sure we decided that we do not want to do that, at least not for 2.7.0, not before users and distros have had a chance to adjust.\n\nAlso, whatever the server pushes (`dhcp-option dns` or `dns`) should populate the old options, for the same reason - otherwise moving the server to new-style options (\"ah, the client sends IV_DNS\") will break existing setups.","commit_id":"c80f7625c77101090b72f35b8c0d737178f84289"},{"author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"change_message_id":"efb993ce78d1d3152c880d1c81005d5d96d0b7fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"884d597a_5182a698","in_reply_to":"877a22d4_f39c135c","updated":"2025-01-20 19:12:32.000000000","message":"Maybe it\u0027s not clear from the commit message, but this concerns only the dns related env variables. The foreign_option_* ones will still be set when dhcp-options are pushed, and no dns options at the same time. Does this address your concerns?","commit_id":"c80f7625c77101090b72f35b8c0d737178f84289"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"c15d86e59911e1c6df05feb2ec944f78fb4ba3ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a0ebfd8e_21fe0f5a","in_reply_to":"884d597a_5182a698","updated":"2025-01-21 13:37:00.000000000","message":"Yeah, if we still set `foreign_options_*` that should mean it will work fine with servers that only push dhcp-option.","commit_id":"c80f7625c77101090b72f35b8c0d737178f84289"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"b6c35693699611ae17dcab2dd3f286a871b53973","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7930c32f_edab9266","updated":"2025-03-08 16:53:26.000000000","message":"Not sure I understand this - isn\u0027t this exactly what we discussed in the meeting a week ago that we are not going to do, that is, \"break --up scripts setting up DNS\"?\n\nThe suggested approach was\n  - if --dns script is active (which is to be made a configure opt-in decision, so distributions can make it always-on and compile-yourself users can actively turn it on if they want it) *then* do not publish these env variables to --up\n  - if --dns script is not active, leave --up scripts alone","commit_id":"3d8024bd6be9f786cb633fcdeb8176afa7c669cd"},{"author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"change_message_id":"c098b6e94d20b870b8df9622021726f5e1cf8504","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"bd8fb58b_f3ffbcba","in_reply_to":"647bd4fb_798fa3d8","updated":"2025-03-14 04:24:36.000000000","message":"Done","commit_id":"3d8024bd6be9f786cb633fcdeb8176afa7c669cd"},{"author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"change_message_id":"1756b5aa38ae680411c8d9e4fe9ee80d2a147ceb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"647bd4fb_798fa3d8","in_reply_to":"7930c32f_edab9266","updated":"2025-03-12 04:04:56.000000000","message":"My takeaway was that we discuss again after I implemented the review comments. Let\u0027s have the discussion in IRC instead, as I suspect some back and forth until we come to a conclusion that covers all cases. Easier that way, I think.","commit_id":"3d8024bd6be9f786cb633fcdeb8176afa7c669cd"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"f69b730755fae0f71bd5c7e4a0657d3012fc9b64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"81784c42_61683494","updated":"2025-03-12 13:38:44.000000000","message":"reread code, and make commit message more clear that this is only about `--dns` related vars - those are new, we\u0027re not breaking anyone\u0027s legacy `--up` scripts relying on foreign_option env vars.","commit_id":"6e5f33c3378acf5308303a0da3e8e17265308d9c"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"1908f022f8c6b54f9c88f7f5c4fe5873dac65693","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"f3695be1_9edd2d98","updated":"2025-03-18 09:05:49.000000000","message":"I like that tuntap_options_copy_dns() is removed (including warnings about dhcp required) but I think this is separate from publishing dns vars to scripts. Could we split it into two - one patch deals with copying options and warnings and another one deals with env vars? Or am I missing something here?","commit_id":"7cb1d9ff276ef7558b587e184387c4441288e97a"}]}