)]}'
{"id":"openvpn~842","triplet_id":"openvpn~master~I76e2e616c6ffe436a9627fa71aaace74030b2f4a","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-03-09 16:42:24.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-03-09 16:42:24.000000000","reason":"Change was submitted"},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2025-03-09 16:42:24.000000000","reason":"Change was submitted"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2025-03-09 16:42:24.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I76e2e616c6ffe436a9627fa71aaace74030b2f4a","subject":"dco: pass remoteaddr only for UDP peers","status":"MERGED","created":"2024-12-13 17:09:29.000000000","updated":"2025-03-09 16:42:24.000000000","submitted":"2025-03-09 16:42:24.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"842","meta_rev_id":"4c25c624a10fa3bd219bad1e4ebe0a5fab627e75","_number":842,"virtual_id_number":842,"owner":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"value":0,"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-12-13 17:09:29.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-12-13 17:09:29.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2024-12-13 17:09:29.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2024-12-16 13:16:19.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"state":"REVIEWER"},{"updated":"2025-03-09 15:29:58.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"3b388b00a26b99aca64051e20395b921a5ab8b3d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2024-12-13 17:09:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"11fa7686215157c4d499a6b9adf1196fc869cd3f","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2024-12-16 13:16:19.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f913082a70d359e0b51f50abb396e58c10e15a87","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-01-17 15:46:03.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0148007e1ca25e4c1bf77853dca89ac358c0069d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-02-21 11:05:54.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+2, Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"4edc1ef18d655d5641e8d59b0a59b858009fb24d","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-02-21 20:41:55.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"4a526512173475cb9fb484ac211b6f12d65c4290","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-03-09 15:29:58.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"4c25c624a10fa3bd219bad1e4ebe0a5fab627e75","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-03-09 16:42:24.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"90d7881e32ec371874c020f756bd35d1959e9698","revisions":{"aad8f68c3d31b95265a131ff46c68f92e69f7e13":{"kind":"REWORK","_number":1,"created":"2024-12-13 17:09:29.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/42/842/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/42/842/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/842/1 \u0026\u0026 git checkout -b change-842 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/842/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/842/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/842/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/42/842/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/842/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"baa9192851006e2dbb90b410011e61ecf2e01870","subject":"Use XOR instead of concatenation for calculation of IV from implicit IV"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2024-12-13 12:50:08.000000000","tz":60},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2024-12-13 17:09:40.000000000","tz":60},"subject":"dco: pass remoteaddr only for UDP peers","message":"dco: pass remoteaddr only for UDP peers\n\nTCP connected sockets do not need any remote addr\nbecause the destination is fixed.\nFor this reason we can avoid sending the remote addr\nalong the peer-new dco call.\n\nThis change is important on Linux because the new \u0027ovpn\u0027\nkernel module is stricter when it comes to accepting\nnetlink messages and will reject calls with TCP sockets\nif a remote address is specified.\n\nChange-Id: I76e2e616c6ffe436a9627fa71aaace74030b2f4a\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"5a462dbf56e84072aca7986d5323d14ae53277bb":{"kind":"REWORK","_number":2,"created":"2025-02-21 11:05:54.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/42/842/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/42/842/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/842/2 \u0026\u0026 git checkout -b change-842 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/842/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/842/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/842/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/42/842/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/842/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bca57c1d9c82c890f1b16586b416fabd4f9b1e56","subject":"dco-win: support for iroutes"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2024-12-13 12:50:08.000000000","tz":60},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-02-21 11:05:29.000000000","tz":60},"subject":"dco: pass remoteaddr only for UDP peers","message":"dco: pass remoteaddr only for UDP peers\n\nTCP connected sockets do not need any remote addr\nbecause the destination is fixed.\nFor this reason we can avoid sending the remote addr\nalong the peer-new dco call.\n\nThis change is important on Linux because the new \u0027ovpn\u0027\nkernel module is stricter when it comes to accepting\nnetlink messages and will reject calls with TCP sockets\nif a remote address is specified.\n\nChange-Id: I76e2e616c6ffe436a9627fa71aaace74030b2f4a\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"90d7881e32ec371874c020f756bd35d1959e9698":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2025-03-09 16:42:24.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/42/842/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/42/842/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/842/3 \u0026\u0026 git checkout -b change-842 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/842/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/842/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/842/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/42/842/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/842/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cedddc1d7419de4cf8c403efeb03fd9277fee40d","subject":"Remove various unused function parameters"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-03-09 15:30:17.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-03-09 15:32:28.000000000","tz":60},"subject":"dco: pass remoteaddr only for UDP peers","message":"dco: pass remoteaddr only for UDP peers\n\nTCP connected sockets do not need any remote addr\nbecause the destination is fixed.\nFor this reason we can avoid sending the remote addr\nalong the peer-new dco call.\n\nThis change is important on Linux because the new \u0027ovpn\u0027\nkernel module is stricter when it comes to accepting\nnetlink messages and will reject calls with TCP sockets\nif a remote address is specified.\n\nChange-Id: I76e2e616c6ffe436a9627fa71aaace74030b2f4a\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250309153017.5163-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31078.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}