)]}'
{"id":"openvpn~844","triplet_id":"openvpn~master~I806757a8c6f9a589665624f176391b5f7b87f581","project":"openvpn","branch":"master","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-12-20 17:12:37.000000000","reason":"Reviewer was added"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2024-12-21 15:23:08.000000000","reason":"\u003cGERRIT_ACCOUNT_1000041\u003e replied on the change","reason_account":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"}},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-12-20 17:12:37.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{"1000041":{"account":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"last_update":"2024-12-21 15:23:08.000000000","reason":"\u003cGERRIT_ACCOUNT_1000041\u003e replied on the change","reason_account":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"}}},"hashtags":[],"change_id":"I806757a8c6f9a589665624f176391b5f7b87f581","subject":"Fix float support in P2P topology","status":"NEW","created":"2024-12-20 17:12:37.000000000","updated":"2025-01-07 11:41:00.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"dbbf91f8157b82767862ebd6f7eba926cdcc328d","_number":844,"virtual_id_number":844,"owner":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-12-20 17:12:37.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-12-20 17:12:37.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2024-12-20 17:12:37.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2024-12-20 21:56:39.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"CC"}],"messages":[{"id":"24ab81483bc007ac7df2851355a2eb7aafca3fbc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2024-12-20 17:12:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"26ae51594b7447d382477fac1ca2de0f0eec31c8","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-12-20 21:56:39.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"85d1cbd99244998c8632fb89a095d70d03466b48","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2024-12-21 15:23:08.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"40bc1d3454e4c415c1f162c67dffc45085f4b7b6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2025-01-07 09:51:15.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5f0e833b85721813a9030b9b36115127ec2e3461","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2025-01-07 09:53:32.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"dbbf91f8157b82767862ebd6f7eba926cdcc328d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2025-01-07 11:41:00.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"d0731ea9c1f4f520058ec6f3e7d62a66d2197ef8","revisions":{"6f35e2e567e3cdf87b0c95c32fe2774fee850e98":{"kind":"REWORK","_number":1,"created":"2024-12-20 17:12:37.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/44/844/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/44/844/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/844/1 \u0026\u0026 git checkout -b change-844 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/844/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/844/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/844/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/44/844/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/844/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"baa9192851006e2dbb90b410011e61ecf2e01870","subject":"Use XOR instead of concatenation for calculation of IV from implicit IV"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2024-12-20 17:01:00.000000000","tz":60},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2024-12-20 17:11:35.000000000","tz":60},"subject":"Fix float support in P2P topology","message":"Fix float support in P2P topology\n\nFix the handling of floating operations in P2P topology, where new UDP\nendpoints were previously ignored. When floating occurs, this update\nprocesses the new endpoints and updates the address if the `--float`\noption is specified or `--remote` is omitted.\n\nSince the same code path is used for clients in MP topology, this change\nalso enables processing of server floating operations from the client\nperspective.\n\nChange-Id: I806757a8c6f9a589665624f176391b5f7b87f581\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"b1570b7afd59983083d8f9fa2a2bb346367df1dc":{"kind":"REWORK","_number":2,"created":"2025-01-07 09:51:15.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/44/844/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/44/844/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/844/2 \u0026\u0026 git checkout -b change-844 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/844/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/844/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/844/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/44/844/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/844/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"baa9192851006e2dbb90b410011e61ecf2e01870","subject":"Use XOR instead of concatenation for calculation of IV from implicit IV"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2024-12-20 17:01:00.000000000","tz":60},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-01-07 09:50:24.000000000","tz":60},"subject":"Fix float support in P2P topology","message":"Fix float support in P2P topology\n\nFix the handling of floating operations in P2P topology, where new UDP\nendpoints were previously ignored. When floating occurs, this update\nprocesses the new endpoints and updates the address if the `--float`\noption is specified or `--remote` is omitted.\n\nSince the same code path is used for clients in MP topology, this change\nalso enables processing of server floating operations from the client\nperspective.\n\nChange-Id: I806757a8c6f9a589665624f176391b5f7b87f581\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"d0731ea9c1f4f520058ec6f3e7d62a66d2197ef8":{"kind":"REWORK","_number":3,"created":"2025-01-07 11:41:00.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/44/844/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/44/844/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/844/3 \u0026\u0026 git checkout -b change-844 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/844/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/844/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/844/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/44/844/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/844/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"baa9192851006e2dbb90b410011e61ecf2e01870","subject":"Use XOR instead of concatenation for calculation of IV from implicit IV"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2024-12-20 17:01:00.000000000","tz":60},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-01-07 11:40:45.000000000","tz":60},"subject":"Fix float support in P2P topology","message":"Fix float support in P2P topology\n\nFix the handling of floating operations in P2P topology, where new UDP\nendpoints were previously ignored. When floating occurs, this update\nprocesses the new endpoints and updates the address if the `--float`\noption is specified or `--remote` is omitted.\n\nSince the same code path is used for clients in MP topology, this change\nalso enables processing of server floating operations from the client\nperspective.\n\nChange-Id: I806757a8c6f9a589665624f176391b5f7b87f581\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}],"submit_requirements":[{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}},{"name":"checks~ChecksSubmitRule","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["checks~ChecksSubmitRule"]}}]}