)]}'
{"id":"openvpn~851","triplet_id":"openvpn~master~Iea477ac96b0dbaee24ca8d097a2e1958f70c5dd3","project":"openvpn","branch":"master","topic":"tchar-removal","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-01-27 09:36:04.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-01-27 09:36:04.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iea477ac96b0dbaee24ca8d097a2e1958f70c5dd3","subject":"openvpnserv: Fix some inconsistent usages of TEXT()","status":"MERGED","created":"2025-01-08 12:58:40.000000000","updated":"2025-01-27 09:36:04.000000000","submitted":"2025-01-27 09:36:04.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"851-tchar-removal","meta_rev_id":"49c93b2e6e54d04148f84825a4c84b9166a8105f","_number":851,"virtual_id_number":851,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-08 12:58:42.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-01-08 12:58:42.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-01-27 09:08:30.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"state":"REVIEWER"}],"messages":[{"id":"cb416eade9ce43fc59a18561c58b7bd23bbf3438","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-01-08 12:58:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"498382b545ef9ce33a9571925bc5ad04468d3ba0","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-01-27 09:08:30.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"49c93b2e6e54d04148f84825a4c84b9166a8105f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-01-27 09:36:04.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"02412106f406538db6f84fdea223b0972a3e3f41","revisions":{"cf72e261acfae6f7c3c7b02a1cd1cb871af4c0dc":{"kind":"REWORK","_number":1,"created":"2025-01-08 12:58:40.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/51/851/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/51/851/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/851/1 \u0026\u0026 git checkout -b change-851 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/851/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/851/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/851/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/51/851/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/851/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6a7931a4a89cb35be7b799942e7fa03fde2cdc63","subject":"Allow DEFAULT in data-ciphers and report both expanded and user set option"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-01-07 17:24:16.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-01-07 17:37:38.000000000","tz":60},"subject":"openvpnserv: Fix some inconsistent usages of TEXT()","message":"openvpnserv: Fix some inconsistent usages of TEXT()\n\nIn general you can\u0027t use multiple strings as argument\nto TEXT() since it just adds a L in front of the argument.\nSo if you specifiy multiple arguments the later argument\nstrings do not get the L.\n\nThis does not seem to directly cause problems with our\nASCII strings, but make the usage consistent with all\nthe other code. That will help in case we remove the\nusage of TEXT().\n\nAlso include tapctl/basic.h in openvpnserv to make\nthe macro environment consistent with tapctl and\nopenvpnmsica.\n\nChange-Id: Iea477ac96b0dbaee24ca8d097a2e1958f70c5dd3\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"02412106f406538db6f84fdea223b0972a3e3f41":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2025-01-27 09:36:04.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/51/851/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/51/851/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/851/2 \u0026\u0026 git checkout -b change-851 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/851/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/851/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/851/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/51/851/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/851/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2a50daf5fe6c924c8d945b3d0455c9e282cd769f","subject":"tls_crypt_v2_write_client_key_file: Fix missing-field-initializers compiler warning"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-01-27 09:11:02.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-01-27 09:33:35.000000000","tz":60},"subject":"openvpnserv: Fix some inconsistent usages of TEXT()","message":"openvpnserv: Fix some inconsistent usages of TEXT()\n\nIn general you can\u0027t use multiple strings as argument\nto TEXT() since it just adds a L in front of the argument.\nSo if you specifiy multiple arguments the later argument\nstrings do not get the L.\n\nThis does not seem to directly cause problems with our\nASCII strings, but make the usage consistent with all\nthe other code. That will help in case we remove the\nusage of TEXT().\n\nAlso include tapctl/basic.h in openvpnserv to make\nthe macro environment consistent with tapctl and\nopenvpnmsica.\n\nChange-Id: Iea477ac96b0dbaee24ca8d097a2e1958f70c5dd3\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Lev Stipakov \u003clstipakov@gmail.com\u003e\nMessage-Id: \u003c20250127091102.26983-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30603.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}