)]}'
{"id":"openvpn~854","triplet_id":"openvpn~master~Ib3a166ead912beb2a591105c84d96d342664c05f","project":"openvpn","branch":"master","topic":"tchar-removal","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-03-19 17:48:15.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-03-19 17:48:15.000000000","reason":"Change was submitted"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2025-03-19 17:48:15.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ib3a166ead912beb2a591105c84d96d342664c05f","subject":"Post tchar.h removal cleanup","status":"MERGED","created":"2025-01-08 12:58:40.000000000","updated":"2025-03-19 17:48:15.000000000","submitted":"2025-03-19 17:48:15.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":3,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"854-tchar-removal","meta_rev_id":"a700c7fe0bfb263b3767f7e035d9b424eb55e35f","_number":854,"virtual_id_number":854,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-08 12:58:43.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-01-08 12:58:43.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-01-09 10:19:00.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"state":"CC"},{"updated":"2025-01-27 09:55:29.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"state":"REVIEWER"},{"updated":"2025-03-19 14:22:11.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"41f7db619b9cc499dca5f03074a3bbf6037dd14e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-01-08 12:58:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9dcb4e762549c0f6f535d728791d279eb95ecaf7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-01-08 13:02:38.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8cb13a78e5c82e8d922d885cba47e08f81913911","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-01-09 10:19:00.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"0a393228796bdc53af8d05fc9b23e5f5d7fb6a64","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-01-27 09:55:29.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e7a2d9fd2fbcd62fcf6212f9d1442221e208b09a","tag":"autogenerated:gerrit:setWorkInProgress","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-01-30 17:57:26.000000000","message":"Set Work In Progress","accounts_in_message":[],"_revision_number":2},{"id":"25d42ad88758f26b969648d59f86400bbcc26296","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-03-18 12:13:57.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"e122b558d3976a9427c2be908feb5c80a3363909","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-03-18 12:17:59.000000000","message":"Patch Set 3:\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":3},{"id":"829762b78b70f4b02f7c5a71f1999dd6d4bbcc29","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-03-18 12:19:58.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"da2e3d22dcdd641e2b09998e257293efc70c19d7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-03-19 13:07:00.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4},{"id":"7e0531c846380579e03d354a6c1154e5599348c3","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-03-19 14:22:11.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"a700c7fe0bfb263b3767f7e035d9b424eb55e35f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-03-19 17:48:15.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"6bb20fa8bebc29d8b3103662ffba4904d03e852d","revisions":{"2dce6b31f0feed0b518aa0460202d20eb7f49f1f":{"kind":"REWORK","_number":1,"created":"2025-01-08 12:58:40.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/54/854/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/54/854/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/1 \u0026\u0026 git checkout -b change-854 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/54/854/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4602d813254d2c952da0e1e92f8a26ffef9f82d5","subject":"Apply text-removal.sh script to Windows codebase"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-01-08 12:55:27.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-01-08 12:57:00.000000000","tz":60},"subject":"Post tchar.h removal cleanup","message":"Post tchar.h removal cleanup\n\nChange-Id: Ib3a166ead912beb2a591105c84d96d342664c05f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"782c4575f48ead3aad74d3b09db9ab9c63a3888b":{"kind":"REWORK","_number":2,"created":"2025-01-08 13:02:38.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/54/854/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/54/854/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/2 \u0026\u0026 git checkout -b change-854 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/54/854/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4602d813254d2c952da0e1e92f8a26ffef9f82d5","subject":"Apply text-removal.sh script to Windows codebase"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-01-08 12:55:27.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-01-08 13:02:25.000000000","tz":60},"subject":"Post tchar.h removal cleanup","message":"Post tchar.h removal cleanup\n\nChange-Id: Ib3a166ead912beb2a591105c84d96d342664c05f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"c08294b8077f303b365d05d8157704fd43026e33":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-03-18 12:13:57.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/54/854/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/54/854/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/3 \u0026\u0026 git checkout -b change-854 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/54/854/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"41e42c322b91f93add9ddc5b2ab716030f2c74e8","subject":"Apply text-removal.sh script to Windows codebase"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-01-08 12:55:27.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-03-18 12:12:54.000000000","tz":60},"subject":"Post tchar.h removal cleanup","message":"Post tchar.h removal cleanup\n\nChange-Id: Ib3a166ead912beb2a591105c84d96d342664c05f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"d7c97821700c4497db1354faee70044c1e6404d7":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-03-19 13:07:00.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/54/854/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/54/854/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/4 \u0026\u0026 git checkout -b change-854 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/54/854/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f134eeb9c09a124127f64d64191e16a9ed7e105d","subject":"openvpnserv: Clean up use of TEXT() from DNS patches"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-01-08 12:50:56.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-03-19 13:06:16.000000000","tz":60},"subject":"Post tchar.h removal cleanup","message":"Post tchar.h removal cleanup\n\nRemove some unused defines.\n\nChange-Id: Ib3a166ead912beb2a591105c84d96d342664c05f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"6bb20fa8bebc29d8b3103662ffba4904d03e852d":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2025-03-19 17:48:15.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/54/854/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/54/854/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/5 \u0026\u0026 git checkout -b change-854 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/54/854/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/854/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f134eeb9c09a124127f64d64191e16a9ed7e105d","subject":"openvpnserv: Clean up use of TEXT() from DNS patches"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-03-19 14:22:24.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-03-19 17:45:43.000000000","tz":60},"subject":"Post tchar.h removal cleanup","message":"Post tchar.h removal cleanup\n\nRemove some unused defines.\n\nChange-Id: Ib3a166ead912beb2a591105c84d96d342664c05f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250319142234.25046-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31172.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}