)]}'
{"id":"openvpn~855","triplet_id":"openvpn~master~I81cbecd19018290d85c6c77fba7769f040d66233","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-02-01 18:37:51.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-02-01 18:37:51.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I81cbecd19018290d85c6c77fba7769f040d66233","subject":"Improve error reporting from AF_UNIX tun/tap support","status":"MERGED","created":"2025-01-09 14:42:42.000000000","updated":"2025-02-01 18:37:51.000000000","submitted":"2025-02-01 18:37:51.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"855","meta_rev_id":"10977ca928d0eeb596226c3209f0d3b0891406c5","_number":855,"virtual_id_number":855,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-09 14:42:42.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-01-09 14:42:42.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-01-10 07:26:20.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"1f6da60c213dd5f2af8099d5c89bacb84d904541","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-01-09 14:42:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3c59a73d35aefd0185aab104e5cc69cbd05fa475","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-01-09 15:05:41.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"29dd2b2eb710e9fca245825ad43c8354fe53ae75","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-01-10 07:26:20.000000000","message":"Patch Set 2: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"3300917f3d42eef8bb88811b938db53d173a795f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-01-26 15:11:01.000000000","message":"Uploaded patch set 3.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":3},{"id":"9b747d287c86a8f092bec6bec467687e8903151a","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-02-01 12:19:35.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"10977ca928d0eeb596226c3209f0d3b0891406c5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-02-01 18:37:51.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"800e8abdecd6cab62fd2074594b4e08aa72d0d82","revisions":{"0b843016e8963db78a88e1283ae37bb25a43fa91":{"kind":"REWORK","_number":1,"created":"2025-01-09 14:42:42.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/55/855/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/55/855/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/855/1 \u0026\u0026 git checkout -b change-855 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/855/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/855/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/855/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/55/855/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/855/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6a7931a4a89cb35be7b799942e7fa03fde2cdc63","subject":"Allow DEFAULT in data-ciphers and report both expanded and user set option"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-09 14:28:20.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-09 14:42:34.000000000","tz":60},"subject":"Improve error reporting from AF_UNIX tun/tap support","message":"Improve error reporting from AF_UNIX tun/tap support\n\nWhen having a non-existent lwipovpn binary or similar problems, the\nerror reporting would often only report read error that were harder to\nidentify the real problem.  Add the openvpn_waitpid_check method\nthat checks for error conditions and reports a better message in cases\nof problems.\n\nChange-Id: I81cbecd19018290d85c6c77fba7769f040d66233\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"67e975bfaa9b8d1bddf6eeb21532def952403006":{"kind":"REWORK","_number":2,"created":"2025-01-09 15:05:41.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/55/855/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/55/855/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/855/2 \u0026\u0026 git checkout -b change-855 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/855/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/855/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/855/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/55/855/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/855/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6a7931a4a89cb35be7b799942e7fa03fde2cdc63","subject":"Allow DEFAULT in data-ciphers and report both expanded and user set option"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-09 14:28:20.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-09 15:05:12.000000000","tz":60},"subject":"Improve error reporting from AF_UNIX tun/tap support","message":"Improve error reporting from AF_UNIX tun/tap support\n\nWhen having a non-existent lwipovpn binary or similar problems, the\nerror reporting would often only report read error that were harder to\nidentify the real problem.  Add the openvpn_waitpid_check method\nthat checks for error conditions and reports a better message in cases\nof problems.\n\nChange-Id: I81cbecd19018290d85c6c77fba7769f040d66233\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"42a966110208ff52e479f1a35642f8b9ba7f4378":{"kind":"REWORK","_number":3,"created":"2025-01-26 15:11:01.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/55/855/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/55/855/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/855/3 \u0026\u0026 git checkout -b change-855 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/855/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/855/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/855/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/55/855/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/855/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2a50daf5fe6c924c8d945b3d0455c9e282cd769f","subject":"tls_crypt_v2_write_client_key_file: Fix missing-field-initializers compiler warning"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-09 14:28:20.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-26 15:10:45.000000000","tz":60},"subject":"Improve error reporting from AF_UNIX tun/tap support","message":"Improve error reporting from AF_UNIX tun/tap support\n\nWhen having a non-existent lwipovpn binary or similar problems, the\nerror reporting would often only report read error that were harder to\nidentify the real problem.  Add the openvpn_waitpid_check method\nthat checks for error conditions and reports a better message in cases\nof problems.\n\nChange-Id: I81cbecd19018290d85c6c77fba7769f040d66233\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"800e8abdecd6cab62fd2074594b4e08aa72d0d82":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-02-01 18:37:51.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/55/855/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/55/855/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/855/4 \u0026\u0026 git checkout -b change-855 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/855/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/855/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/855/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/55/855/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/55/855/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bfa5f0bdfe89d181f7b5f7af2ba34ab9357a1d13","subject":"mudp.c: keep offset value when resetting buffer"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-02-01 12:20:06.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-02-01 18:34:09.000000000","tz":60},"subject":"Improve error reporting from AF_UNIX tun/tap support","message":"Improve error reporting from AF_UNIX tun/tap support\n\nWhen having a non-existent lwipovpn binary or similar problems, the\nerror reporting would often only report read error that were harder to\nidentify the real problem.  Add the openvpn_waitpid_check method\nthat checks for error conditions and reports a better message in cases\nof problems.\n\nChange-Id: I81cbecd19018290d85c6c77fba7769f040d66233\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250201122006.32098-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30782.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}