)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"66badaaec42f13cff6895e1c21befeadd30b541a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f359a610_2f4bff34","updated":"2025-01-13 09:29:01.000000000","message":"I confirm that dco on Linux does not care about the order because iroutes are just basic system routes. At first glance the change looks reasonable and without side effects.\n\nMaybe Arne can confirm that changing the tls state before doing iroutes should not matter?","commit_id":"c02304e26938d251b6a1fe50ff0c98e9a46d942e"}],"src/openvpn/multi.c":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"12b9e64c6b8d74f368fc039ee76411c9f4f84ff0","unresolved":true,"context_lines":[{"line_number":2466,"context_line":"    }"},{"line_number":2467,"context_line":""},{"line_number":2468,"context_line":"    /*"},{"line_number":2469,"context_line":"     * For routed tunnels, set up internal route to endpoint"},{"line_number":2470,"context_line":"     * plus add all iroute routes."},{"line_number":2471,"context_line":"     */"},{"line_number":2472,"context_line":"    if (TUNNEL_TYPE(mi-\u003econtext.c1.tuntap) \u003d\u003d DEV_TYPE_TUN)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"00ae9e6f_68b015e1","line":2469,"updated":"2025-01-13 09:54:39.000000000","message":"There should be some documentation in the source code why the order matters, that is completely missing. This knowlege that windows needs the iroutes at a certain point is not obvious at all.","commit_id":"c02304e26938d251b6a1fe50ff0c98e9a46d942e"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"6ff30e15014562d5f9389390c71bebe2d0ae0673","unresolved":false,"context_lines":[{"line_number":2466,"context_line":"    }"},{"line_number":2467,"context_line":""},{"line_number":2468,"context_line":"    /*"},{"line_number":2469,"context_line":"     * For routed tunnels, set up internal route to endpoint"},{"line_number":2470,"context_line":"     * plus add all iroute routes."},{"line_number":2471,"context_line":"     */"},{"line_number":2472,"context_line":"    if (TUNNEL_TYPE(mi-\u003econtext.c1.tuntap) \u003d\u003d DEV_TYPE_TUN)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a5a970af_c286d289","line":2469,"in_reply_to":"00ae9e6f_68b015e1","updated":"2025-01-14 12:47:40.000000000","message":"Acknowledged","commit_id":"c02304e26938d251b6a1fe50ff0c98e9a46d942e"}]}