)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"419bf9d5ded494a7ec8814bd34eadf3e65b61af3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"55e1beec_4bb795c9","updated":"2025-01-29 18:22:58.000000000","message":"Looks good!","commit_id":"614c983fbbbd042659bc997baa125bdcd4194695"}],"tests/unit_tests/openvpn/test_ssl.c":[{"author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"419bf9d5ded494a7ec8814bd34eadf3e65b61af3","unresolved":true,"context_lines":[{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    }"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    gc_free(\u0026gc);"},{"line_number":371,"context_line":"}"},{"line_number":372,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"aaf1046f_c7682d5e","line":369,"updated":"2025-01-29 18:22:58.000000000","message":"Nitpick: Did you mean to put 2 blank lines here?","commit_id":"614c983fbbbd042659bc997baa125bdcd4194695"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"a52811b52c4f1d8e0637d7f1e4d103167962c026","unresolved":false,"context_lines":[{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    }"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    gc_free(\u0026gc);"},{"line_number":371,"context_line":"}"},{"line_number":372,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e66a4309_4a9d386f","line":369,"in_reply_to":"aaf1046f_c7682d5e","updated":"2025-02-13 13:49:06.000000000","message":"Acknowledged","commit_id":"614c983fbbbd042659bc997baa125bdcd4194695"},{"author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"419bf9d5ded494a7ec8814bd34eadf3e65b61af3","unresolved":true,"context_lines":[{"line_number":400,"context_line":"    ASSERT(buf_p);"},{"line_number":401,"context_line":"    memcpy(buf_p, BPTR(\u0026src), BLEN(\u0026src));"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    ASSERT(buf_init(\u0026encrypt_workspace, frame.buf.headroom)); \\"},{"line_number":404,"context_line":"    openvpn_encrypt(\u0026buf, encrypt_workspace, co);"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    /* decrypt */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"90415ab6_73c373e1","line":403,"range":{"start_line":403,"start_character":62,"end_line":403,"end_character":63},"updated":"2025-01-29 18:22:58.000000000","message":"Why a line continuation?","commit_id":"614c983fbbbd042659bc997baa125bdcd4194695"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"a52811b52c4f1d8e0637d7f1e4d103167962c026","unresolved":false,"context_lines":[{"line_number":400,"context_line":"    ASSERT(buf_p);"},{"line_number":401,"context_line":"    memcpy(buf_p, BPTR(\u0026src), BLEN(\u0026src));"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    ASSERT(buf_init(\u0026encrypt_workspace, frame.buf.headroom)); \\"},{"line_number":404,"context_line":"    openvpn_encrypt(\u0026buf, encrypt_workspace, co);"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    /* decrypt */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"4e2068e4_57e78179","line":403,"range":{"start_line":403,"start_character":62,"end_line":403,"end_character":63},"in_reply_to":"90415ab6_73c373e1","updated":"2025-02-13 13:49:06.000000000","message":"Acknowledged","commit_id":"614c983fbbbd042659bc997baa125bdcd4194695"},{"author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"419bf9d5ded494a7ec8814bd34eadf3e65b61af3","unresolved":true,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    int expected_epoch \u003d epoch ? 4 : 0;"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    /* Ensure that we are still on the initial key (unit test uses 4)"},{"line_number":433,"context_line":"     * or that it is 0 when epoch is not in use */"},{"line_number":434,"context_line":"    assert_int_equal(co-\u003ekey_ctx_bi.encrypt.epoch, expected_epoch);"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    encrypt_one_packet(co, 1000);"},{"line_number":437,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a772ba34_52699165","line":434,"range":{"start_line":432,"start_character":1,"end_line":434,"end_character":67},"updated":"2025-01-29 18:22:58.000000000","message":"I was confused where the 4 comes from. I guess the previous test sets it that way?","commit_id":"614c983fbbbd042659bc997baa125bdcd4194695"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"a52811b52c4f1d8e0637d7f1e4d103167962c026","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    int expected_epoch \u003d epoch ? 4 : 0;"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    /* Ensure that we are still on the initial key (unit test uses 4)"},{"line_number":433,"context_line":"     * or that it is 0 when epoch is not in use */"},{"line_number":434,"context_line":"    assert_int_equal(co-\u003ekey_ctx_bi.encrypt.epoch, expected_epoch);"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    encrypt_one_packet(co, 1000);"},{"line_number":437,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"cc1a1597_b1c4bf02","line":434,"range":{"start_line":432,"start_character":1,"end_line":434,"end_character":67},"in_reply_to":"a772ba34_52699165","updated":"2025-02-13 13:49:06.000000000","message":"Acknowledged","commit_id":"614c983fbbbd042659bc997baa125bdcd4194695"}]}