)]}'
{"id":"openvpn~871","triplet_id":"openvpn~master~Ib8adf7b31cae02e2de3d45da23b76a2d79f13e20","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-01-27 11:40:10.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-01-21 15:56:36.000000000","reason":"removed on reply"}},"hashtags":["mailsubmitted"],"change_id":"Ib8adf7b31cae02e2de3d45da23b76a2d79f13e20","subject":"Remove comparing username to NULL in tls_lock_username","status":"MERGED","created":"2025-01-20 12:12:28.000000000","updated":"2025-01-27 11:40:10.000000000","submitted":"2025-01-27 11:40:10.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"871","meta_rev_id":"2c9956c27b79e88f6e7b31f25e777850e541a7fe","_number":871,"virtual_id_number":871,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-20 12:12:30.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-01-20 12:12:30.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"06fc85d5bbf10ca3c1b1d79a43bf29a333420b16","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-01-20 12:12:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0cf6ae6ecee4a3ea7b377c2b92132d3c75531803","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-01-21 15:56:36.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"1c3e9287fb891924540c5c4079a1fa1e80498b33","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-01-21 16:13:40.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":1},{"id":"9f20b09154b8325fd1866a36ed62790ee6be5c63","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-01-27 10:40:42.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"2c9956c27b79e88f6e7b31f25e777850e541a7fe","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-01-27 11:40:10.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"d9af13e8c222cba41000202908663a6d1e2cd028","revisions":{"6a6d04b68603db2e53c9c08796844f699085fb39":{"kind":"REWORK","_number":1,"created":"2025-01-20 12:12:28.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/71/871/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/71/871/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/871/1 \u0026\u0026 git checkout -b change-871 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/871/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/871/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/871/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/71/871/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/871/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5cea4bc75e1b87ec7225a89b7cf5cadb85e77e8a","subject":"IPv6 MADDR LOG: Wrap IPv6 addresses in square brackets and print port when the port is specified"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-20 07:35:04.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-20 12:12:11.000000000","tz":60},"subject":"Remove comparing username to NULL in tls_lock_username","message":"Remove comparing username to NULL in tls_lock_username\n\ntls_lock_username is only called in a single place and that place\ncalls this is function with up-\u003eusername, which is always defined.\n\nChange-Id: Ib8adf7b31cae02e2de3d45da23b76a2d79f13e20\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"fcde976a4f728778a2b5781b926c1f8dce6e80c6":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-01-27 10:40:42.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/71/871/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/71/871/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/871/2 \u0026\u0026 git checkout -b change-871 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/871/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/871/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/871/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/71/871/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/871/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"02412106f406538db6f84fdea223b0972a3e3f41","subject":"openvpnserv: Fix some inconsistent usages of TEXT()"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-20 07:35:04.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-27 10:40:33.000000000","tz":60},"subject":"Remove comparing username to NULL in tls_lock_username","message":"Remove comparing username to NULL in tls_lock_username\n\ntls_lock_username is only called in a single place and that place\ncalls this is function with up-\u003eusername, which is always defined.\n\nChange-Id: Ib8adf7b31cae02e2de3d45da23b76a2d79f13e20\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"d9af13e8c222cba41000202908663a6d1e2cd028":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2025-01-27 11:40:10.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/71/871/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/71/871/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/871/3 \u0026\u0026 git checkout -b change-871 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/871/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/871/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/871/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/71/871/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/871/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"02412106f406538db6f84fdea223b0972a3e3f41","subject":"openvpnserv: Fix some inconsistent usages of TEXT()"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-21 16:12:47.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-01-27 11:35:40.000000000","tz":60},"subject":"Remove comparing username to NULL in tls_lock_username","message":"Remove comparing username to NULL in tls_lock_username\n\ntls_lock_username is only called in a single place and that place\ncalls this is function with up-\u003eusername, which is always defined.\n\nChange-Id: Ib8adf7b31cae02e2de3d45da23b76a2d79f13e20\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20250121161247.37883-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30520.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}