)]}'
{"id":"openvpn~873","triplet_id":"openvpn~master~Ie1e2eb54d516b3ae87c5ca56fe8edd77ee2be4de","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-01-27 12:23:59.000000000","reason":"\u003cGERRIT_ACCOUNT_1000003\u003e replied on the change","reason_account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-01-27 12:18:52.000000000","reason":"\u003cGERRIT_ACCOUNT_1000002\u003e replied on the change","reason_account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-01-21 13:28:25.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}},"hashtags":[],"change_id":"Ie1e2eb54d516b3ae87c5ca56fe8edd77ee2be4de","subject":"Print warnings/errors when numerical parameters cannot be parsed","status":"MERGED","created":"2025-01-21 12:03:04.000000000","updated":"2025-01-27 13:39:25.000000000","submitted":"2025-01-27 13:39:25.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":10,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"873","meta_rev_id":"afa752c540f5c9d2df9dd3f7dafd1ebe88b92291","_number":873,"virtual_id_number":873,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}],"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-21 12:03:04.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-01-21 12:03:04.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-01-27 10:07:40.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"dd57c20ba22d9bede6c443d55be3dcdfbba60a1d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-01-21 12:03:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"58f7f6d9875f82e09cc09445e89c14982f30b72d","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-01-21 13:28:25.000000000","message":"Patch Set 1: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f9e29892ec59cfaacc14f3f49de8e1241c51328a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-01-21 14:10:54.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":2},{"id":"ad9ed0b89a14b994c63bff0a6db02b0f043e9822","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-01-21 14:40:43.000000000","message":"Patch Set 2: -Code-Review","accounts_in_message":[],"_revision_number":2},{"id":"2e552775d2fd1b6c07bd90a3d4dd765fee2e810e","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-01-21 14:53:17.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"9a49b0e676989a949b3e1c589867ae67b7dca9b2","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-01-22 12:04:32.000000000","message":"Patch Set 2: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"64f693ed7f7eeebec3f14599f987fbc38d25b8c0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-01-22 13:28:22.000000000","message":"Uploaded patch set 3.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":3},{"id":"2fa5d04f6b56ed31723f62c3bfceff4602384c49","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-01-22 15:58:10.000000000","message":"Patch Set 3: -Code-Review\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"422c672d4c519da6290518e5107e4a266a3ff971","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-01-24 17:42:09.000000000","message":"Patch Set 3: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"27f67244524f6a9ea76ad27a30ec2363ad44835a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-01-26 15:18:49.000000000","message":"Uploaded patch set 4.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":4},{"id":"659508123caf40373a2893a8b0edeb2fda417adb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-01-26 17:11:13.000000000","message":"Uploaded patch set 5.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":5},{"id":"447f3f7e790b20759a7a2e14ea83e911991459e0","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-01-27 10:07:40.000000000","message":"Patch Set 5: Code-Review-2\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"c6742aab31064d087cb0884a34765980163f9010","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-01-27 10:18:20.000000000","message":"Uploaded patch set 6.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":6},{"id":"eea36f7b9087466d4cf5a5b20c19025add47a699","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-01-27 11:30:31.000000000","message":"Patch Set 6: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":6},{"id":"7800acb498a73820a96e49bc0b74057afcd87920","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-01-27 12:01:41.000000000","message":"Uploaded patch set 7.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":7},{"id":"8ac5615daf612a0107f699cf338847fcfad7da4e","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-01-27 12:18:52.000000000","message":"Patch Set 7: Code-Review+2","accounts_in_message":[],"_revision_number":7},{"id":"7bd8c483035d528b1cf230bf6f326e32fc011516","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-01-27 12:23:59.000000000","message":"Patch Set 7: -Code-Review","accounts_in_message":[],"_revision_number":7},{"id":"c8d1b8cb580062ffd7b81381acd4a9925c508b0a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-01-27 12:51:53.000000000","message":"Uploaded patch set 8: Patch Set 7 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":8},{"id":"afa752c540f5c9d2df9dd3f7dafd1ebe88b92291","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-01-27 13:39:25.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":9}],"current_revision_number":9,"current_revision":"40518dc66d9d04e6ec7e04439d7a6bc7fd6ac20f","revisions":{"bc116a607afc9e8dcfe1a9882cfc592b889c4454":{"kind":"REWORK","_number":1,"created":"2025-01-21 12:03:04.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/73/873/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/73/873/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/1 \u0026\u0026 git checkout -b change-873 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/73/873/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1a52dec60a2b94620eae7f4eb8b85f408fdcd506","subject":"Implement override-username"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-21 11:55:36.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-21 12:02:44.000000000","tz":60},"subject":"Print warnings/errors when numerical parameters cannot be parsed","message":"Print warnings/errors when numerical parameters cannot be parsed\n\nUsing the atoi method is a best effort method that parses as much of the\ninput string as possible as integer and ignores the rest or return 0\nif the string cannot be parsed. This is lead to unexpected results.\n\nChange the behaviour by printing a warning in these cases instead. When\nparsing a configuration, these warnings will error out since the msglevel\nis M_USAGE in this case. Example:\n\n    ./src/openvpn/openvpn --resolv-retry 198jj\n    Options error: Cannot parse argument \u0027198jj\u0027 as non-negative integer\n\nReported-By: Anqi Chen \u003cchen.anqi3@northeastern.edu\u003e\nReported-By: Cristina Nita-Rotaru \u003cc.nitarotaru@northeastern.edu\u003e\nChange-Id: Ie1e2eb54d516b3ae87c5ca56fe8edd77ee2be4de\n"},"branch":"refs/heads/master"},"848250e8a0835e73b179100f2615bdf7cd8884bf":{"kind":"REWORK","_number":2,"created":"2025-01-21 14:10:54.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/73/873/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/73/873/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/2 \u0026\u0026 git checkout -b change-873 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/73/873/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1a52dec60a2b94620eae7f4eb8b85f408fdcd506","subject":"Implement override-username"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-21 11:55:36.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-21 14:10:06.000000000","tz":60},"subject":"Print warnings/errors when numerical parameters cannot be parsed","message":"Print warnings/errors when numerical parameters cannot be parsed\n\nUsing the atoi method is a best effort method that parses as much of the\ninput string as possible as integer and ignores the rest or return 0\nif the string cannot be parsed. This is lead to unexpected results.\n\nChange the behaviour by printing a warning in these cases instead. When\nparsing a configuration, these warnings will error out since the msglevel\nis M_USAGE in this case. Example:\n\n    ./src/openvpn/openvpn --resolv-retry 198jj\n    Options error: Cannot parse argument \u0027198jj\u0027 as non-negative integer\n\nReported-By: Anqi Chen \u003cchen.anqi3@northeastern.edu\u003e\nReported-By: Cristina Nita-Rotaru \u003cc.nitarotaru@northeastern.edu\u003e\nChange-Id: Ie1e2eb54d516b3ae87c5ca56fe8edd77ee2be4de\n"},"branch":"refs/heads/master"},"246e43f3830e22e6632ec91c480441792b8d4a2a":{"kind":"REWORK","_number":3,"created":"2025-01-22 13:28:22.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/73/873/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/73/873/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/3 \u0026\u0026 git checkout -b change-873 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/73/873/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1a52dec60a2b94620eae7f4eb8b85f408fdcd506","subject":"Implement override-username"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-21 11:55:36.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-22 13:27:58.000000000","tz":60},"subject":"Print warnings/errors when numerical parameters cannot be parsed","message":"Print warnings/errors when numerical parameters cannot be parsed\n\nUsing the atoi method is a best effort method that parses as much of the\ninput string as possible as integer and ignores the rest or return 0\nif the string cannot be parsed. This is lead to unexpected results.\n\nChange the behaviour by printing a warning in these cases instead. When\nparsing a configuration, these warnings will error out since the msglevel\nis M_USAGE in this case. Example:\n\n    ./src/openvpn/openvpn --resolv-retry 198jj\n    Options error: Cannot parse argument \u0027198jj\u0027 as non-negative integer\n\nReported-By: Anqi Chen \u003cchen.anqi3@northeastern.edu\u003e\nReported-By: Cristina Nita-Rotaru \u003cc.nitarotaru@northeastern.edu\u003e\nChange-Id: Ie1e2eb54d516b3ae87c5ca56fe8edd77ee2be4de\n"},"branch":"refs/heads/master"},"fe59e8adb22aa60593c870e9aeb0e8721ca51a42":{"kind":"REWORK","_number":4,"created":"2025-01-26 15:18:49.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/73/873/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/73/873/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/4 \u0026\u0026 git checkout -b change-873 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/73/873/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2a50daf5fe6c924c8d945b3d0455c9e282cd769f","subject":"tls_crypt_v2_write_client_key_file: Fix missing-field-initializers compiler warning"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-21 11:55:36.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-26 15:18:32.000000000","tz":60},"subject":"Print warnings/errors when numerical parameters cannot be parsed","message":"Print warnings/errors when numerical parameters cannot be parsed\n\nUsing the atoi method is a best effort method that parses as much of the\ninput string as possible as integer and ignores the rest or return 0\nif the string cannot be parsed. This is lead to unexpected results.\n\nChange the behaviour by printing a warning in these cases instead. When\nparsing a configuration, these warnings will error out since the msglevel\nis M_USAGE in this case. Example:\n\n    ./src/openvpn/openvpn --resolv-retry 198jj\n    Options error: Cannot parse argument \u0027198jj\u0027 as non-negative integer\n\nReported-By: Anqi Chen \u003cchen.anqi3@northeastern.edu\u003e\nReported-By: Cristina Nita-Rotaru \u003cc.nitarotaru@northeastern.edu\u003e\nChange-Id: Ie1e2eb54d516b3ae87c5ca56fe8edd77ee2be4de\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"8bc647f6be96007aebe90e7b3d8fc21e781c381f":{"kind":"REWORK","_number":5,"created":"2025-01-26 17:11:13.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/73/873/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/73/873/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/5 \u0026\u0026 git checkout -b change-873 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/73/873/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2a50daf5fe6c924c8d945b3d0455c9e282cd769f","subject":"tls_crypt_v2_write_client_key_file: Fix missing-field-initializers compiler warning"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-21 11:55:36.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-26 17:11:01.000000000","tz":60},"subject":"Print warnings/errors when numerical parameters cannot be parsed","message":"Print warnings/errors when numerical parameters cannot be parsed\n\nUsing the atoi method is a best effort method that parses as much of the\ninput string as possible as integer and ignores the rest or return 0\nif the string cannot be parsed. This is lead to unexpected results.\n\nChange the behaviour by printing a warning in these cases instead. When\nparsing a configuration, these warnings will error out since the msglevel\nis M_USAGE in this case. Example:\n\n    ./src/openvpn/openvpn --resolv-retry 198jj\n    Options error: Cannot parse argument \u0027198jj\u0027 as non-negative integer\n\nReported-By: Anqi Chen \u003cchen.anqi3@northeastern.edu\u003e\nReported-By: Cristina Nita-Rotaru \u003cc.nitarotaru@northeastern.edu\u003e\nChange-Id: Ie1e2eb54d516b3ae87c5ca56fe8edd77ee2be4de\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"ed40007823a202e67ab36bd88f27df2945a1ec32":{"kind":"REWORK","_number":6,"created":"2025-01-27 10:18:20.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/73/873/6","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/73/873/6","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/6 \u0026\u0026 git checkout -b change-873 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/73/873/6","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"02412106f406538db6f84fdea223b0972a3e3f41","subject":"openvpnserv: Fix some inconsistent usages of TEXT()"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-21 11:55:36.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-27 10:17:53.000000000","tz":60},"subject":"Print warnings/errors when numerical parameters cannot be parsed","message":"Print warnings/errors when numerical parameters cannot be parsed\n\nUsing the atoi method is a best effort method that parses as much of the\ninput string as possible as integer and ignores the rest or return 0\nif the string cannot be parsed. This is lead to unexpected results.\n\nChange the behaviour by printing a warning in these cases instead. When\nparsing a configuration, these warnings will error out since the msglevel\nis M_USAGE in this case. Example:\n\n    ./src/openvpn/openvpn --resolv-retry 198jj\n    Options error: Cannot parse argument \u0027198jj\u0027 as non-negative integer\n\nReported-By: Anqi Chen \u003cchen.anqi3@northeastern.edu\u003e\nReported-By: Cristina Nita-Rotaru \u003cc.nitarotaru@northeastern.edu\u003e\nChange-Id: Ie1e2eb54d516b3ae87c5ca56fe8edd77ee2be4de\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"166949af1bfe49cd98f1a694e9d35b523f97bd2b":{"kind":"REWORK","_number":7,"created":"2025-01-27 12:01:41.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/73/873/7","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/73/873/7","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/7 \u0026\u0026 git checkout -b change-873 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/73/873/7","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"02412106f406538db6f84fdea223b0972a3e3f41","subject":"openvpnserv: Fix some inconsistent usages of TEXT()"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-21 11:55:36.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-27 12:00:52.000000000","tz":60},"subject":"Print warnings/errors when numerical parameters cannot be parsed","message":"Print warnings/errors when numerical parameters cannot be parsed\n\nUsing the atoi method is a best effort method that parses as much of the\ninput string as possible as integer and ignores the rest or return 0\nif the string cannot be parsed. This is lead to unexpected results.\n\nChange the behaviour by printing a warning in these cases instead. When\nparsing a configuration, these warnings will error out since the msglevel\nis M_USAGE in this case. Example:\n\n    ./src/openvpn/openvpn --resolv-retry 198jj\n    Options error: Cannot parse argument \u0027198jj\u0027 as non-negative integer\n\nReported-By: Anqi Chen \u003cchen.anqi3@northeastern.edu\u003e\nReported-By: Cristina Nita-Rotaru \u003cc.nitarotaru@northeastern.edu\u003e\nChange-Id: Ie1e2eb54d516b3ae87c5ca56fe8edd77ee2be4de\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"b9532912a15903469205e23f87f5884a4f11d20b":{"kind":"TRIVIAL_REBASE","_number":8,"created":"2025-01-27 12:51:53.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/73/873/8","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/73/873/8","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/8 \u0026\u0026 git checkout -b change-873 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/73/873/8","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d9af13e8c222cba41000202908663a6d1e2cd028","subject":"Remove comparing username to NULL in tls_lock_username"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-21 11:55:36.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-27 12:51:39.000000000","tz":60},"subject":"Print warnings/errors when numerical parameters cannot be parsed","message":"Print warnings/errors when numerical parameters cannot be parsed\n\nUsing the atoi method is a best effort method that parses as much of the\ninput string as possible as integer and ignores the rest or return 0\nif the string cannot be parsed. This is lead to unexpected results.\n\nChange the behaviour by printing a warning in these cases instead. When\nparsing a configuration, these warnings will error out since the msglevel\nis M_USAGE in this case. Example:\n\n    ./src/openvpn/openvpn --resolv-retry 198jj\n    Options error: Cannot parse argument \u0027198jj\u0027 as non-negative integer\n\nReported-By: Anqi Chen \u003cchen.anqi3@northeastern.edu\u003e\nReported-By: Cristina Nita-Rotaru \u003cc.nitarotaru@northeastern.edu\u003e\nChange-Id: Ie1e2eb54d516b3ae87c5ca56fe8edd77ee2be4de\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"40518dc66d9d04e6ec7e04439d7a6bc7fd6ac20f":{"kind":"NO_CODE_CHANGE","_number":9,"created":"2025-01-27 13:39:25.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/73/873/9","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/73/873/9","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/9 \u0026\u0026 git checkout -b change-873 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/73/873/9","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/73/873/9 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d9af13e8c222cba41000202908663a6d1e2cd028","subject":"Remove comparing username to NULL in tls_lock_username"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-01-27 12:25:31.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-01-27 12:28:00.000000000","tz":60},"subject":"Print warnings/errors when numerical parameters cannot be parsed","message":"Print warnings/errors when numerical parameters cannot be parsed\n\nUsing the atoi method is a best effort method that parses as much of the\ninput string as possible as integer and ignores the rest or return 0\nif the string cannot be parsed. This is lead to unexpected results.\n\nChange the behaviour by printing a warning in these cases instead. When\nparsing a configuration, these warnings will error out since the msglevel\nis M_USAGE in this case. Example:\n\n    ./src/openvpn/openvpn --resolv-retry 198jj\n    Options error: Cannot parse argument \u0027198jj\u0027 as non-negative integer\n\nReported-By: Anqi Chen \u003cchen.anqi3@northeastern.edu\u003e\nReported-By: Cristina Nita-Rotaru \u003cc.nitarotaru@northeastern.edu\u003e\nChange-Id: Ie1e2eb54d516b3ae87c5ca56fe8edd77ee2be4de\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250127122531.13105-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30627.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}