)]}'
{"id":"openvpn~875","triplet_id":"openvpn~master~I0542df021ae0ba9c982335fed7bbd10ed326dd0f","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-01-24 14:00:58.000000000","reason":"Change was submitted"},"1000034":{"account":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"last_update":"2025-01-24 14:00:58.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-01-24 14:00:58.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I0542df021ae0ba9c982335fed7bbd10ed326dd0f","subject":"Fix PASS_BY_VALUE issue in options_postprocess_mutate_le()","status":"MERGED","created":"2025-01-24 12:43:04.000000000","updated":"2025-01-24 14:00:58.000000000","submitted":"2025-01-24 14:00:58.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"875","meta_rev_id":"8a12d4f6290ca8d76ca3a358d952e195c781c31a","_number":875,"virtual_id_number":875,"owner":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-24 12:43:05.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-01-24 12:43:05.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-01-24 12:43:05.000000000","updated_by":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-01-24 12:58:14.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"30df2e59679489be96a0b3f1ef68fed5ca041e74","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2025-01-24 12:43:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"09134f904ea921bfb7c69d916f5180c52a4ca872","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-01-24 12:58:14.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"8a12d4f6290ca8d76ca3a358d952e195c781c31a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-01-24 14:00:58.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8a0f297e068b6701acceafc5af92eddd18a4151b","revisions":{"18e97fbf3f8d5150bb2e70007fc2265a4eadbd82":{"kind":"REWORK","_number":1,"created":"2025-01-24 12:43:04.000000000","uploader":{"_account_id":1000034,"name":"its_Giaan","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/75/875/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/75/875/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/875/1 \u0026\u0026 git checkout -b change-875 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/875/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/875/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/875/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/75/875/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/875/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8466c2ca3faf0dc143262ea2a76bfe3e2aff9f51","subject":"allow user to specify \u0027local\u0027 multiple times in config files"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-01-24 12:08:48.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-01-24 12:42:54.000000000","tz":60},"subject":"Fix PASS_BY_VALUE issue in options_postprocess_mutate_le()","message":"Fix PASS_BY_VALUE issue in options_postprocess_mutate_le()\n\nFix issue reported by Coverity:\nCID 1641424: Performance inefficiencies (PASS_BY_VALUE)\n    Passing parameter ce of type \"struct connection_entry\"\n    (size 208 bytes) by value, which exceeds the low\n    threshold of 128 bytes.\n\nCommit 8466c2ca unintentionally introduced a performance\npenalty due to passing struct connection_entry \u0027ce\u0027\nby value to options_postprocess_mutate_le().\nfix this by passing \u0027ce\u0027 by address.\n\nChange-Id: I0542df021ae0ba9c982335fed7bbd10ed326dd0f\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"8a0f297e068b6701acceafc5af92eddd18a4151b":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2025-01-24 14:00:58.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/75/875/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/75/875/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/875/2 \u0026\u0026 git checkout -b change-875 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/875/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/875/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/875/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/75/875/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/875/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cbb0440ee884ba3c052066d915d6fd7ce86befd2","subject":"multiproto: move generic event handling code in dedicated files"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-01-24 13:00:00.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-01-24 13:58:47.000000000","tz":60},"subject":"Fix PASS_BY_VALUE issue in options_postprocess_mutate_le()","message":"Fix PASS_BY_VALUE issue in options_postprocess_mutate_le()\n\nFix issue reported by Coverity:\nCID 1641424: Performance inefficiencies (PASS_BY_VALUE)\n    Passing parameter ce of type \"struct connection_entry\"\n    (size 208 bytes) by value, which exceeds the low\n    threshold of 128 bytes.\n\nCommit 8466c2ca unintentionally introduced a performance\npenalty due to passing struct connection_entry \u0027ce\u0027\nby value to options_postprocess_mutate_le().\nfix this by passing \u0027ce\u0027 by address.\n\nChange-Id: I0542df021ae0ba9c982335fed7bbd10ed326dd0f\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250124130000.20067-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30566.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}