)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"39f5b49588dd19e351f094286332bd7f7ff56ddb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0278a8a8_e716945c","updated":"2025-01-31 10:30:36.000000000","message":"Initial testing looks generally promising, but I miss getting the ON_LINK flag for gateway addresses that are on a locally connected subnet.  Most easily tested with 127.0.0.1 ;-) - the generic code knows how to do that, and windows code does that for IPv6 (try `--show-gateway ::1`)","commit_id":"6221bba3b34bf1e047683ea72b8159075260eb42"}],"src/openvpn/route.c":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"781a38821936ecc731e2155caed8a6de7af08be8","unresolved":true,"context_lines":[{"line_number":2809,"context_line":""},{"line_number":2810,"context_line":"    /* get netmask and adapter index */"},{"line_number":2811,"context_line":"    const IP_ADAPTER_INFO *adapters \u003d get_adapter_info_list(\u0026gc);"},{"line_number":2812,"context_line":"    DWORD a_index \u003d adapter_index_of_ip(adapters, rgi-\u003egateway.addr, NULL, \u0026rgi-\u003egateway.netmask);"},{"line_number":2813,"context_line":"    if (a_index \u003d\u003d TUN_ADAPTER_INDEX_INVALID)"},{"line_number":2814,"context_line":"    {"},{"line_number":2815,"context_line":"        goto done;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a12cf014_08dcec58","line":2812,"updated":"2025-01-31 10:56:03.000000000","message":"This fails for `ON_LINK` targets, where `gateway.addr \u003d\u003d 0.0.0.0`.\n\nThe IPv6 code uses `BestRoute.InterfaceIndex`, because Windows nicely hands this to us anyway.","commit_id":"6221bba3b34bf1e047683ea72b8159075260eb42"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"3e3af5dc1df9b97bc2351a8a63fd8353eb12e933","unresolved":false,"context_lines":[{"line_number":2809,"context_line":""},{"line_number":2810,"context_line":"    /* get netmask and adapter index */"},{"line_number":2811,"context_line":"    const IP_ADAPTER_INFO *adapters \u003d get_adapter_info_list(\u0026gc);"},{"line_number":2812,"context_line":"    DWORD a_index \u003d adapter_index_of_ip(adapters, rgi-\u003egateway.addr, NULL, \u0026rgi-\u003egateway.netmask);"},{"line_number":2813,"context_line":"    if (a_index \u003d\u003d TUN_ADAPTER_INDEX_INVALID)"},{"line_number":2814,"context_line":"    {"},{"line_number":2815,"context_line":"        goto done;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a0e6aa22_44e519ff","line":2812,"in_reply_to":"a12cf014_08dcec58","updated":"2025-01-31 13:32:13.000000000","message":"Done","commit_id":"6221bba3b34bf1e047683ea72b8159075260eb42"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"781a38821936ecc731e2155caed8a6de7af08be8","unresolved":true,"context_lines":[{"line_number":2824,"context_line":"        memcpy(rgi-\u003ehwaddr, ai-\u003eAddress, 6);"},{"line_number":2825,"context_line":"        rgi-\u003eflags |\u003d RGI_HWADDR_DEFINED;"},{"line_number":2826,"context_line":"    }"},{"line_number":2827,"context_line":""},{"line_number":2828,"context_line":"done:"},{"line_number":2829,"context_line":"    gc_free(\u0026gc);"},{"line_number":2830,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"879c7db7_bf0b726d","line":2827,"updated":"2025-01-31 10:56:03.000000000","message":"the IPv6 part sets the `RGI_ON_LINK` flag when the `BestRoute.Nexthop` points to an empty IPv6 address.  Testing with v4 seems to be similar, so for an onlink-prefix (same IPv4 subnet as on the LAN interface, or just `127.0.0.1` to trigger `on-link I\u003d1`) I get \"ROUTE_GATEWAY 0.0.0.0\" - but no ON_LINK for v4, yet.","commit_id":"6221bba3b34bf1e047683ea72b8159075260eb42"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"3e3af5dc1df9b97bc2351a8a63fd8353eb12e933","unresolved":false,"context_lines":[{"line_number":2824,"context_line":"        memcpy(rgi-\u003ehwaddr, ai-\u003eAddress, 6);"},{"line_number":2825,"context_line":"        rgi-\u003eflags |\u003d RGI_HWADDR_DEFINED;"},{"line_number":2826,"context_line":"    }"},{"line_number":2827,"context_line":""},{"line_number":2828,"context_line":"done:"},{"line_number":2829,"context_line":"    gc_free(\u0026gc);"},{"line_number":2830,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"b7f7fe7b_1e60f462","line":2827,"in_reply_to":"879c7db7_bf0b726d","updated":"2025-01-31 13:32:13.000000000","message":"Done","commit_id":"6221bba3b34bf1e047683ea72b8159075260eb42"}]}
