)]}'
{"id":"openvpn~881","triplet_id":"openvpn~master~Ic438c583a782035ecb9b5ea65702a768ae2585f5","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000008":{"account":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2025-01-29 17:13:40.000000000","reason":"\u003cGERRIT_ACCOUNT_1000008\u003e replied on the change","reason_account":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-01-29 19:26:46.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-01-29 19:26:46.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-01-29 16:57:05.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}},"hashtags":[],"change_id":"Ic438c583a782035ecb9b5ea65702a768ae2585f5","subject":"options: add IPv4 support to \u0027--show-gateway \u003carg\u003e\u0027","status":"MERGED","created":"2025-01-29 11:30:55.000000000","updated":"2025-01-29 19:26:46.000000000","submitted":"2025-01-29 19:26:46.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"881","meta_rev_id":"bbb7d5db6ec0618a658c72d5e3a2d74e0f0528c8","_number":881,"virtual_id_number":881,"owner":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-29 11:30:55.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-01-29 11:30:55.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-01-29 11:30:55.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-01-29 12:16:30.000000000","updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"real_updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"state":"REVIEWER"}],"messages":[{"id":"eaa5f23465cab4118bbeed9d2d2e0155e6b47d93","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-01-29 11:30:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"aa0a1a00e9dac431d22350999d6c248595d61a7b","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-01-29 12:15:46.000000000","message":"Patch Set 1: Code-Review-2\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"45f3dd0fd86ba461c01a5860030d3cc234c41706","author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-01-29 12:16:30.000000000","message":"Patch Set 1: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e3b5261cee12f44d881dcc79bf8b769c7ef163c4","author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-01-29 12:17:19.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"cc7f8e77d22c2ef61ac2e9dc393134fea24debe3","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-01-29 12:24:22.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"143811ce00d3dac6ad7beca2e28f63fd6546220e","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-01-29 12:27:49.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1da31e4b673ef53623b9880ba07baf63d0c79ae3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-01-29 13:52:15.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"0671877a368a2b22590092d3176e6e35dbb146d9","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-01-29 16:57:05.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e957f9f3510174d8be6ade0ce41d6c98883f3827","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-01-29 17:02:31.000000000","message":"Uploaded patch set 3.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":3},{"id":"66b753dde53eb585d993bfa23cb1c62f67ee86c5","author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-01-29 17:13:40.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"bbb7d5db6ec0618a658c72d5e3a2d74e0f0528c8","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-01-29 19:26:46.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"9df51cf56e27f6103ed5becbafd1f645726d9155","revisions":{"e1a4075bb7757bfb3eed19ec4d30171f8f3fb039":{"kind":"REWORK","_number":1,"created":"2025-01-29 11:30:55.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/81/881/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/81/881/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/881/1 \u0026\u0026 git checkout -b change-881 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/881/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/881/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/881/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/81/881/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/881/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0fcfc8381f60d9f7b4a53afaea223dfee5e18835","subject":"route.c: change the signature of get_default_gateway()"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-01-29 10:14:51.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-01-29 11:27:55.000000000","tz":60},"subject":"options: add IPv4 support to \u0027--show-gateway \u003carg\u003e\u0027","message":"options: add IPv4 support to \u0027--show-gateway \u003carg\u003e\u0027\n\nThis is an old debug option, which used to print \"the default routes found\"\nfor IPv4 and IPv6, and optionally \"a route to a particular IPv6 target\"\nif passed an argument.\n\nWith the work started in commit 0fcfc8381f60d we want this to handle\nIPv4 as well, mostly to be able to easily test per-platform\nget_default_gateway() implementations.\n\nThe implementation is simplistic - if \u003carg\u003e can be parsed as an IPv4 or\nIPv6 address, that particular protocol lookup will do \"the host route\"\nand the other one will stick to \"the default route\".\n\nChange-Id: Ic438c583a782035ecb9b5ea65702a768ae2585f5\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"cafb47dec5f834dd6aeabdcea287b72a4d703633":{"kind":"REWORK","_number":2,"created":"2025-01-29 13:52:15.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/81/881/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/81/881/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/881/2 \u0026\u0026 git checkout -b change-881 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/881/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/881/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/881/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/81/881/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/881/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0fcfc8381f60d9f7b4a53afaea223dfee5e18835","subject":"route.c: change the signature of get_default_gateway()"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-01-29 10:14:51.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-01-29 13:51:49.000000000","tz":60},"subject":"options: add IPv4 support to \u0027--show-gateway \u003carg\u003e\u0027","message":"options: add IPv4 support to \u0027--show-gateway \u003carg\u003e\u0027\n\nThis is an old debug option, which used to print \"the default routes found\"\nfor IPv4 and IPv6, and optionally \"a route to a particular IPv6 target\"\nif passed an argument.\n\nWith the work started in commit 0fcfc8381f60d we want this to handle\nIPv4 as well, mostly to be able to easily test per-platform\nget_default_gateway() implementations.\n\nThe implementation is simplistic - if \u003carg\u003e can be parsed as an IPv4 or\nIPv6 address, that particular protocol lookup will do \"the host route\"\nand the other one will stick to \"the default route\".\n\nNOTE: as of this commit, there is no backend functionality for IPv4, so\nit will not actually print anything interesting.  This will be added in\nfurther platform dependent commits.\n\nv2: amend --help output\n\nChange-Id: Ic438c583a782035ecb9b5ea65702a768ae2585f5\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"9c90e0370a9e6ff226252958b9ded05ea690dbf6":{"kind":"REWORK","_number":3,"created":"2025-01-29 17:02:31.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/81/881/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/81/881/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/881/3 \u0026\u0026 git checkout -b change-881 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/881/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/881/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/881/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/81/881/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/881/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0fcfc8381f60d9f7b4a53afaea223dfee5e18835","subject":"route.c: change the signature of get_default_gateway()"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-01-29 10:14:51.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-01-29 17:01:48.000000000","tz":60},"subject":"options: add IPv4 support to \u0027--show-gateway \u003carg\u003e\u0027","message":"options: add IPv4 support to \u0027--show-gateway \u003carg\u003e\u0027\n\nThis is an old debug option, which used to print \"the default routes found\"\nfor IPv4 and IPv6, and optionally \"a route to a particular IPv6 target\"\nif passed an argument.\n\nWith the work started in commit 0fcfc8381f60d we want this to handle\nIPv4 as well, mostly to be able to easily test per-platform\nget_default_gateway() implementations.\n\nThe implementation is simplistic - if \u003carg\u003e can be parsed as an IPv4 or\nIPv6 address, that particular protocol lookup will do \"the host route\"\nand the other one will stick to \"the default route\".\n\nNOTE: as of this commit, there is no backend functionality for IPv4, so\nit will not actually print anything interesting.  This will be added in\nfurther platform dependent commits.\n\nv2: amend --help output\nv3: uncrustify (#ifdef block too long, comments at #endif required now)\n\nChange-Id: Ic438c583a782035ecb9b5ea65702a768ae2585f5\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"9df51cf56e27f6103ed5becbafd1f645726d9155":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-01-29 19:26:46.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/81/881/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/81/881/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/881/4 \u0026\u0026 git checkout -b change-881 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/881/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/881/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/881/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/81/881/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/81/881/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b6a2533a3fb29eafe78a2432eaf9adaa0e707420","subject":"Fix doxygen warnings in crypto_epoch.h"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-01-29 17:30:07.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-01-29 19:23:50.000000000","tz":60},"subject":"options: add IPv4 support to \u0027--show-gateway \u003carg\u003e\u0027","message":"options: add IPv4 support to \u0027--show-gateway \u003carg\u003e\u0027\n\nThis is an old debug option, which used to print \"the default routes found\"\nfor IPv4 and IPv6, and optionally \"a route to a particular IPv6 target\"\nif passed an argument.\n\nWith the work started in commit 0fcfc8381f60d we want this to handle\nIPv4 as well, mostly to be able to easily test per-platform\nget_default_gateway() implementations.\n\nThe implementation is simplistic - if \u003carg\u003e can be parsed as an IPv4 or\nIPv6 address, that particular protocol lookup will do \"the host route\"\nand the other one will stick to \"the default route\".\n\nNOTE: as of this commit, there is no backend functionality for IPv4, so\nit will not actually print anything interesting.  This will be added in\nfurther platform dependent commits.\n\nv2: amend --help output\nv3: uncrustify (#ifdef block too long, comments at #endif required now)\n\nChange-Id: Ic438c583a782035ecb9b5ea65702a768ae2585f5\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nAcked-by: Lev Stipakov \u003clstipakov@gmail.com\u003e\nMessage-Id: \u003c20250129173007.3280-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30728.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
