)]}'
{"id":"openvpn~884","triplet_id":"openvpn~master~I6f17140109106b37e6b0e690df1d87720ccf6f91","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-01-31 09:40:58.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-01-31 09:40:58.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-01-31 09:40:58.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I6f17140109106b37e6b0e690df1d87720ccf6f91","subject":"get_default_gateway(): implement platform support for Linux/IPROUTE2","status":"MERGED","created":"2025-01-30 18:13:15.000000000","updated":"2025-01-31 09:40:58.000000000","submitted":"2025-01-31 09:40:58.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"883","meta_rev_id":"c2e7a1effdf527cf12ebc04b99fd2ec90da1818f","_number":884,"virtual_id_number":884,"owner":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-30 18:13:16.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-01-30 18:13:16.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-01-30 18:13:16.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-01-31 08:30:23.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"}],"messages":[{"id":"79e6c087a6b95b9dc8f679e5eaa3bdf508b57c35","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-01-30 18:13:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"57cebbe903bdd3551a379544f6e8c09aa8850a94","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-01-31 08:30:23.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4b5fa336521feb2b29f6c55753209343547ae664","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-01-31 08:40:39.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"c2e7a1effdf527cf12ebc04b99fd2ec90da1818f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-01-31 09:40:58.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"d83afe0e0c878164886d83f3ffddbc63680a6310","revisions":{"c776fb7df9210ea49c32d304e8982f87f484977b":{"kind":"REWORK","_number":1,"created":"2025-01-30 18:13:15.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/84/884/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/84/884/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/884/1 \u0026\u0026 git checkout -b change-884 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/884/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/884/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/884/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/84/884/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/884/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"80356f270e37e8efea53c96115750ebec26d3104","subject":"get_default_gateway(): implement platform support for Linux/SITNL"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-01-30 18:09:11.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-01-30 18:09:11.000000000","tz":60},"subject":"get_default_gateway(): implement platform support for Linux/IPROUTE2","message":"get_default_gateway(): implement platform support for Linux/IPROUTE2\n\nRemove the old \"read /proc/net/route and try to parse it\" implementation\nand always use the sitnl/netlink implementation of net_route_v4_best_gw().\n\nThis was kept \"because we had it and it was working\" but does not really\nprovide any benefit - netlink for route queries is there for v6 anyway,\nand the main argument for keeping --enable-iproute2 is \"some users want\nto run non-standard \u0027ip\u0027 binaries to do things\" - which is not affected\nby this change.\n\nChange-Id: I6f17140109106b37e6b0e690df1d87720ccf6f91\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"881da7e69844b0dbd22f90f60f43100ff70955c3":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-01-31 08:40:39.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/84/884/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/84/884/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/884/2 \u0026\u0026 git checkout -b change-884 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/884/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/884/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/884/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/84/884/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/884/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2918c25449f939a9b97eaed77d37d3c2f847bd39","subject":"get_default_gateway(): implement platform support for Linux/SITNL"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-01-30 18:09:11.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-01-31 08:40:07.000000000","tz":60},"subject":"get_default_gateway(): implement platform support for Linux/IPROUTE2","message":"get_default_gateway(): implement platform support for Linux/IPROUTE2\n\nRemove the old \"read /proc/net/route and try to parse it\" implementation\nand always use the sitnl/netlink implementation of net_route_v4_best_gw().\n\nThis was kept \"because we had it and it was working\" but does not really\nprovide any benefit - netlink for route queries is there for v6 anyway,\nand the main argument for keeping --enable-iproute2 is \"some users want\nto run non-standard \u0027ip\u0027 binaries to do things\" - which is not affected\nby this change.\n\nChange-Id: I6f17140109106b37e6b0e690df1d87720ccf6f91\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"d83afe0e0c878164886d83f3ffddbc63680a6310":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2025-01-31 09:40:58.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/84/884/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/84/884/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/884/3 \u0026\u0026 git checkout -b change-884 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/884/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/884/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/884/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/84/884/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/84/884/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f28c254da58c7a48592c2c63c0a98b38283405e8","subject":"get_default_gateway(): implement platform support for Linux/SITNL"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-01-31 08:47:07.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-01-31 09:36:58.000000000","tz":60},"subject":"get_default_gateway(): implement platform support for Linux/IPROUTE2","message":"get_default_gateway(): implement platform support for Linux/IPROUTE2\n\nRemove the old \"read /proc/net/route and try to parse it\" implementation\nand always use the sitnl/netlink implementation of net_route_v4_best_gw().\n\nThis was kept \"because we had it and it was working\" but does not really\nprovide any benefit - netlink for route queries is there for v6 anyway,\nand the main argument for keeping --enable-iproute2 is \"some users want\nto run non-standard \u0027ip\u0027 binaries to do things\" - which is not affected\nby this change.\n\nChange-Id: I6f17140109106b37e6b0e690df1d87720ccf6f91\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nAcked-by: Antonio Quartulli \u003ca@unstable.cc\u003e\nMessage-Id: \u003c20250131084707.24905-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30748.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}