)]}'
{"id":"openvpn~898","triplet_id":"openvpn~master~I02afe6817433ca21aae76671c35151ec6a066933","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-02-14 16:03:51.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-02-14 15:34:18.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-02-14 16:03:51.000000000","reason":"Change was submitted"},"1000040":{"account":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"last_update":"2025-02-14 16:03:51.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I02afe6817433ca21aae76671c35151ec6a066933","subject":"get_default_gateway(): Prevent passing IPV4_INVALID_ADDR as a destination","status":"MERGED","created":"2025-02-14 10:08:39.000000000","updated":"2025-02-14 16:03:51.000000000","submitted":"2025-02-14 16:03:51.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"898","meta_rev_id":"c2b8d21c7052caabd1c723c3c528fbe34a0b3728","_number":898,"virtual_id_number":898,"owner":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-02-14 10:08:40.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-02-14 10:08:40.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-02-14 10:08:40.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-02-14 10:20:55.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"ffd0b5d79d291f29565f1217d3fb5b13621fed63","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-02-14 10:08:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"58c83d180b7b3b0188676da3b86f4bb8f75c2e40","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-02-14 10:20:55.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"4ff8c3e54ebb6bb8f3d7324dbdce0725da441dc7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-02-14 10:30:15.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"3649c368f0fc7dd3e6091bc94d554415b66e1354","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-02-14 10:33:51.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"ef6c81124faece2ce31a9068a92782ab8e03a38a","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-02-14 12:56:00.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"93dd934e69ce858c3135e93295b3abc8843ae21f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-02-14 15:04:13.000000000","message":"Uploaded patch set 3: Commit message was updated.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"df7649ab20594520086cb28a4cea37041f49d8fc","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-02-14 15:34:18.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"c2b8d21c7052caabd1c723c3c528fbe34a0b3728","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-02-14 16:03:51.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"75ba07d496da269b13fc368311f8a063b65d58e7","revisions":{"9d8ad6c40a3c6d6b90e8b6d0ca4e57c7a107d002":{"kind":"REWORK","_number":1,"created":"2025-02-14 10:08:39.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/98/898/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/98/898/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/898/1 \u0026\u0026 git checkout -b change-898 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/898/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/898/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/898/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/98/898/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/898/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"060ead650450553214dad3e9856c500deb672bba","subject":"Adding AWS-LC to the OpenVPN CI"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-02-14 10:02:07.000000000","tz":60},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-02-14 10:02:07.000000000","tz":60},"subject":"get_dafault_gateway(): Make sure the get_default_gateway() function never receives IPV4_INVALID_ADDR as a destination.","message":"get_dafault_gateway(): Make sure the get_default_gateway() function never receives IPV4_INVALID_ADDR as a destination.\n\nChange-Id: I02afe6817433ca21aae76671c35151ec6a066933\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"072443912f1fa05140ae941d185a24d2f828399f":{"kind":"REWORK","_number":2,"created":"2025-02-14 10:30:15.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/98/898/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/98/898/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/898/2 \u0026\u0026 git checkout -b change-898 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/898/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/898/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/898/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/98/898/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/898/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"060ead650450553214dad3e9856c500deb672bba","subject":"Adding AWS-LC to the OpenVPN CI"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-02-14 10:02:07.000000000","tz":60},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-02-14 10:27:42.000000000","tz":60},"subject":"get_default_gateway(): Make sure the get_default_gateway() function never receives IPV4_INVALID_ADDR as a destination.","message":"get_default_gateway(): Make sure the get_default_gateway() function never receives IPV4_INVALID_ADDR as a destination.\n\nChange-Id: I02afe6817433ca21aae76671c35151ec6a066933\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"cb2cca38c14b45fa6ee7aae381296949f6aa1505":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2025-02-14 15:04:13.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/98/898/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/98/898/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/898/3 \u0026\u0026 git checkout -b change-898 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/898/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/898/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/898/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/98/898/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/898/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"060ead650450553214dad3e9856c500deb672bba","subject":"Adding AWS-LC to the OpenVPN CI"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-02-14 10:02:07.000000000","tz":60},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-02-14 14:26:18.000000000","tz":60},"subject":"get_default_gateway(): Prevent passing IPV4_INVALID_ADDR as a destination","message":"get_default_gateway(): Prevent passing IPV4_INVALID_ADDR as a destination\n\nWhen using --redirect-gateway (IPv4) while connected to an IPv6 remote,\nOpenVPN still attempts to determine the IPv4 default gateway,\nso link_socket_current_remote() returns IPV4_INVALID_ADDR (0xffffffff)\nas the destination, leading to unintended behavior:\n\n- the IPv4 default gateway (rl-\u003ergi.gateway.addr) gets wiped.\n- this prevents proper restoration of the original route when needed.\n\nTo fix this, if link_socket_current_remote() returns IPV4_INVALID_ADDR,\nwe now pass INADDR_ANY (0x00000000) to get_default_gateway(),\nensuring the function behaves correctly.\n\nChange-Id: I02afe6817433ca21aae76671c35151ec6a066933\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"75ba07d496da269b13fc368311f8a063b65d58e7":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-02-14 16:03:51.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/98/898/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/98/898/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/898/4 \u0026\u0026 git checkout -b change-898 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/898/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/898/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/898/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/98/898/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/898/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6e16dc6216a9ce5a03292d64420d88582829c533","subject":"Add (fake) Android cmake building"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-02-14 15:34:34.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-02-14 16:02:33.000000000","tz":60},"subject":"get_default_gateway(): Prevent passing IPV4_INVALID_ADDR as a destination","message":"get_default_gateway(): Prevent passing IPV4_INVALID_ADDR as a destination\n\nWhen using --redirect-gateway (IPv4) while connected to an IPv6 remote,\nOpenVPN still attempts to determine the IPv4 default gateway,\nso link_socket_current_remote() returns IPV4_INVALID_ADDR (0xffffffff)\nas the destination, leading to unintended behavior:\n\n- the IPv4 default gateway (rl-\u003ergi.gateway.addr) gets wiped.\n- this prevents proper restoration of the original route when needed.\n\nTo fix this, if link_socket_current_remote() returns IPV4_INVALID_ADDR,\nwe now pass INADDR_ANY (0x00000000) to get_default_gateway(),\nensuring the function behaves correctly.\n\nChange-Id: I02afe6817433ca21aae76671c35151ec6a066933\nSigned-off-by: Marco Baffo \u003cmarco@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250214153434.18539-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30895.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}