)]}'
{"id":"openvpn~903","triplet_id":"openvpn~master~I6841e2f2a85275254a04e2d8ae3defe4420db8f6","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-11 12:51:14.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-10-11 11:44:35.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-11 12:51:14.000000000","reason":"Change was submitted"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2025-10-11 11:44:49.000000000","reason":"\u003cGERRIT_ACCOUNT_1000008\u003e replied on the change","reason_account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}}},"hashtags":[],"change_id":"I6841e2f2a85275254a04e2d8ae3defe4420db8f6","subject":"Make recursive routing check more fine-grained","status":"MERGED","created":"2025-03-06 14:37:26.000000000","updated":"2025-10-11 12:51:14.000000000","submitted":"2025-10-11 12:51:14.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":10,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"903","meta_rev_id":"85c8def9355a028b14d79b890271a10bd8b46dfe","_number":903,"virtual_id_number":903,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-03-06 14:37:27.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-03-06 14:37:27.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-03-06 14:37:27.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-03-06 14:42:34.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"d2a046a77734fdc16a70783ec99b6e77327c6535","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-03-06 14:37:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1e20a91c760215b67aa3fbbb9f65a6d29b1afc07","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-03-06 14:42:34.000000000","message":"Patch Set 1: Code-Review-2\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"3d201f97af438aa3f915fd5e73177a37426b956f","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-03-06 14:55:04.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c41e6faa83501d1d32cd0a33e9968aa67bee2614","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-03-06 15:04:30.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":2},{"id":"ba452fff37088cbca8ea7ccd6f53c10b31a97d85","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-03-06 15:05:27.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f5329501ebbffb096bf1707205a960cf8a41dd87","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-10-10 11:29:38.000000000","message":"Uploaded patch set 3.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":3},{"id":"9c5af6ee24f89ef055e371ba77dac3efbb07a134","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-11 11:01:42.000000000","message":"Patch Set 3: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"55a1ad3c9ff4fb27e42735ee3cb497a221a55ffb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-10-11 11:43:26.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4},{"id":"a7e28f6753df41a40fa581a59fd1a54a0d397861","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-11 11:44:35.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"e9116deae861d74858498e63fb32b5f402d1fdbf","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-10-11 11:44:49.000000000","message":"Patch Set 4:\n\n(3 comments)","accounts_in_message":[],"_revision_number":4},{"id":"85c8def9355a028b14d79b890271a10bd8b46dfe","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-11 12:51:14.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"cf2d18de8b9d75a235dba8e84674361cf64b1489","revisions":{"6c2f192b0da338460f7ced6cd19270fcb8f0205e":{"kind":"REWORK","_number":1,"created":"2025-03-06 14:37:26.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/03/903/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/03/903/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/1 \u0026\u0026 git checkout -b change-903 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/03/903/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"619c3e9a067255f97e129bf02914f5ada5107b51","subject":"Add support for simultaneous use of UDP and TCP sockets"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-03-06 14:10:58.000000000","tz":120},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-03-06 14:18:27.000000000","tz":120},"subject":"Make recursive routing check more fine-grained","message":"Make recursive routing check more fine-grained\n\nThe existing recursive routing check drops TUN packets\nif their address matches the remote. While this works in\nmost cases, a more fine-grained check is preferable for\ncomplex routing rules.\n\nSince we only need to drop traffic originating from OpenVPN,\nall of the following values must match between the packet\nand the link:\n\n - IP protocol\n - Transport protocol (TCP/UDP)\n - Destination address\n - Destination port\n\nGitHub: #699\n\nChange-Id: I6841e2f2a85275254a04e2d8ae3defe4420db8f6\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"6f77a6bdc21bdf28309576a16af0552f36dc7cc5":{"kind":"REWORK","_number":2,"created":"2025-03-06 15:04:30.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/03/903/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/03/903/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/2 \u0026\u0026 git checkout -b change-903 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/03/903/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"619c3e9a067255f97e129bf02914f5ada5107b51","subject":"Add support for simultaneous use of UDP and TCP sockets"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-03-06 14:10:58.000000000","tz":120},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-03-06 14:58:12.000000000","tz":120},"subject":"Make recursive routing check more fine-grained","message":"Make recursive routing check more fine-grained\n\nThe existing recursive routing check drops TUN packets\nif their address matches the remote. While this works in\nmost cases, a more fine-grained check is preferable for\ncomplex routing rules.\n\nSince we only need to drop traffic originating from OpenVPN,\nall of the following values must match between the packet\nand the link:\n\n - IP protocol\n - Transport protocol (TCP/UDP)\n - Destination address\n - Destination port\n\nGitHub: #699\n\nChange-Id: I6841e2f2a85275254a04e2d8ae3defe4420db8f6\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"aae9ce3fa62c34c1af0c7b1682b8955dd003b62d":{"kind":"REWORK","_number":3,"created":"2025-10-10 11:29:38.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/03/903/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/03/903/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/3 \u0026\u0026 git checkout -b change-903 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/03/903/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"083867b0a626b94ab93194834dddf4a38ebc8b6e","subject":"socks: Fix conversion warnings with MinGW"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-03-06 14:10:58.000000000","tz":120},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-10-10 11:18:10.000000000","tz":180},"subject":"Make recursive routing check more fine-grained","message":"Make recursive routing check more fine-grained\n\nThe existing recursive routing check drops TUN packets\nif their address matches the remote. While this works in\nmost cases, a more fine-grained check is preferable for\ncomplex routing rules.\n\nSince we only need to drop traffic originating from OpenVPN,\nall of the following values must match between the packet\nand the link:\n\n - IP protocol\n - Transport protocol (TCP/UDP)\n - Destination address\n - Destination port\n\nGitHub: #699\n\nChange-Id: I6841e2f2a85275254a04e2d8ae3defe4420db8f6\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"f8cb60170322205ab189a2550c83713312bcc1a9":{"kind":"REWORK","_number":4,"created":"2025-10-11 11:43:26.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/03/903/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/03/903/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/4 \u0026\u0026 git checkout -b change-903 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/03/903/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"083867b0a626b94ab93194834dddf4a38ebc8b6e","subject":"socks: Fix conversion warnings with MinGW"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-03-06 14:10:58.000000000","tz":120},"committer":{"name":"Lev Stipakov","email":"lstipakov@gmail.com","date":"2025-10-11 11:35:48.000000000","tz":180},"subject":"Make recursive routing check more fine-grained","message":"Make recursive routing check more fine-grained\n\nThe existing recursive routing check drops TUN packets\nif their address matches the remote. While this works in\nmost cases, a more fine-grained check is preferable for\ncomplex routing rules.\n\nSince we only need to drop traffic originating from OpenVPN,\nall of the following values must match between the packet\nand the link:\n\n - IP protocol\n - Transport protocol (TCP/UDP)\n - Destination address\n - Destination port\n\nGitHub: #699\n\nChange-Id: I6841e2f2a85275254a04e2d8ae3defe4420db8f6\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"cf2d18de8b9d75a235dba8e84674361cf64b1489":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2025-10-11 12:51:14.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/03/903/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/03/903/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/5 \u0026\u0026 git checkout -b change-903 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/03/903/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/903/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0f9ad850d4202f0efe42976b00156226df7dfa17","subject":"redirect-gateway: only redirect traffic through TUN if address families match"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-10-11 11:44:42.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-11 11:58:21.000000000","tz":120},"subject":"Make recursive routing check more fine-grained","message":"Make recursive routing check more fine-grained\n\nThe existing recursive routing check drops TUN packets\nif their address matches the remote. While this works in\nmost cases, a more fine-grained check is preferable for\ncomplex routing rules.\n\nSince we only need to drop traffic originating from OpenVPN,\nall of the following values must match between the packet\nand the link:\n\n - IP protocol\n - Transport protocol (TCP/UDP)\n - Destination address\n - Destination port\n\nGitHub: #699\n\nChange-Id: I6841e2f2a85275254a04e2d8ae3defe4420db8f6\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/903\nMessage-Id: \u003c20251011114448.14501-1-gert@greenie.muc.de\u003e\nURL: https://sourceforge.net/p/openvpn/mailman/message/59245301/\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}