)]}'
{"id":"openvpn~904","triplet_id":"openvpn~master~I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a","project":"openvpn","branch":"master","topic":"dns option","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-06-18 13:01:09.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-06-18 12:48:16.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-06-18 13:01:09.000000000","reason":"Change was submitted"},"1000006":{"account":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"last_update":"2025-06-18 13:01:09.000000000","reason":"Change was submitted"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2025-06-18 13:01:09.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a","subject":"dns: deal with --dhcp-options when --dns is active","status":"MERGED","created":"2025-03-06 22:15:08.000000000","updated":"2025-06-18 13:01:09.000000000","submitted":"2025-06-18 13:01:09.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":14,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"904-dns option","meta_rev_id":"4de68b41e43fb1ac51200b07fd4a0b8f041ed39a","_number":904,"virtual_id_number":904,"owner":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"value":0,"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-03-06 22:15:12.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-03-06 22:15:12.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-03-06 22:15:12.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-04-23 09:43:41.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"state":"REVIEWER"},{"updated":"2025-05-23 06:14:05.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"CC"},{"updated":"2025-06-18 12:48:16.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"45fcca71ce543f0cf19e6867a9121284db50fc7c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-03-06 22:15:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0b1d9572d0536a46cca1f6b061b714a4cd11bf34","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-03-07 02:39:34.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"358554e09b6936e1aed1856191afa774a0a79e84","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-03-07 11:03:22.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"00f14410ef33a0baae913e7dee0515c9abbeef2e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-03-12 04:06:32.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"3b13f348a424187276daa7022e7a95358d850428","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-03-12 11:59:17.000000000","message":"Topic set to dns option","accounts_in_message":[],"_revision_number":3},{"id":"fc3686c3123eed5b287d67b7b0c800c10c7e37df","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-03-14 04:21:29.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4},{"id":"7596311e6d58826548bc9f6339f0b771ad74e665","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-03-18 02:54:13.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"fa486e88e05b697c138e290c47b1bcebf7e2b0b8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-03-18 05:30:38.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"6aecc74f9194eba4b6f8c1224ec51609502e3bc0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-03-19 23:21:50.000000000","message":"Uploaded patch set 7: Patch Set 6 was rebased.","accounts_in_message":[],"_revision_number":7},{"id":"c706c56d1226640c0e83bf9995374d044d1ac392","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-03-20 02:51:34.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"bc40b36f2fcff0fc9dabf66d5a699bb7750f06c7","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-03-20 11:34:10.000000000","message":"Patch Set 8: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":8},{"id":"e26c46f802e8754b090a6a1ade2187890c0b7fe7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-03-20 12:09:46.000000000","message":"Uploaded patch set 9.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":9},{"id":"4ac60f6db1a4bb0d1f6283e026611a322e5e053b","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-03-20 12:10:04.000000000","message":"Patch Set 9:\n\n(1 comment)","accounts_in_message":[],"_revision_number":9},{"id":"bfcf6494501af17c8e7f741445b9041805830761","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-03-27 01:29:09.000000000","message":"Uploaded patch set 10: Patch Set 9 was rebased.","accounts_in_message":[],"_revision_number":10},{"id":"801846402674783e4828594a1e5d99b3e51c1547","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-03-29 18:48:01.000000000","message":"Uploaded patch set 11: Patch Set 10 was rebased.","accounts_in_message":[],"_revision_number":11},{"id":"ce8a15de3137852b0bfab3935605de9784f92d4c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-03-31 07:52:11.000000000","message":"Uploaded patch set 12.","accounts_in_message":[],"_revision_number":12},{"id":"8c4fa78177786c85ddfd4626c1c9b374c2d8b8b2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-04-05 04:11:42.000000000","message":"Uploaded patch set 13: Patch Set 12 was rebased.","accounts_in_message":[],"_revision_number":13},{"id":"fc8ecdbb809e5a97ec6f3c6e4df46af16d3ad6af","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-04-05 04:16:22.000000000","message":"Uploaded patch set 14: Patch Set 13 was rebased.","accounts_in_message":[],"_revision_number":14},{"id":"925d81a340716cf2a791f54378b984d6aa60de30","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-04-23 09:43:41.000000000","message":"Patch Set 14: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":14},{"id":"50b69af99f42472033b2b78efd79884e98084cbe","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-04-23 10:52:03.000000000","message":"Patch Set 14:\n\n(1 comment)","accounts_in_message":[],"_revision_number":14},{"id":"1d955e3f3461ac94160219b1347e6aaf61360b1c","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-04-28 06:12:00.000000000","message":"Patch Set 14:\n\n(2 comments)","accounts_in_message":[],"_revision_number":14},{"id":"654c1f8aceaa9ac56ac5af54b3c2acd897566e0d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-04-28 06:12:44.000000000","message":"Uploaded patch set 15.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":15},{"id":"24e3a980f0c65cabd28a0dcaef0401ef4de7457f","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-05-01 09:05:45.000000000","message":"Patch Set 15: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":15},{"id":"ac2b8202f39a4088c1df593f8e705f1f7808f19e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-05-10 12:36:29.000000000","message":"Uploaded patch set 16: Patch Set 15 was rebased.\n\nCopied Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":16},{"id":"944b686daa9538d24dfc0dc565aa9899e8efa70a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-05-13 15:26:40.000000000","message":"Uploaded patch set 17: Patch Set 16 was rebased.\n\nCopied Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":17},{"id":"94fcd57c2566814553d441a2c5f1ced5bad77522","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-05-13 22:11:31.000000000","message":"Uploaded patch set 18: Patch Set 17 was rebased.\n\nCopied Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":18},{"id":"8e016bd457c9fa53303e97e8738eb6650bdd5ce8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-05-14 12:58:39.000000000","message":"Uploaded patch set 19: New patch set was added with same tree, parent tree, and commit message as Patch Set 18.\n\nCopied Votes:\n* Code-Review+1 (copy condition: \"**changekind:NO_CHANGE** OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":19},{"id":"4aaa7dc933a79601edc7a4d9ec6e4c7bfa633d1b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-05-15 15:28:47.000000000","message":"Uploaded patch set 20: Patch Set 19 was rebased.\n\nCopied Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":20},{"id":"439000d38673f623f37687ccb7b46012013732e1","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-05-19 08:46:22.000000000","message":"Patch Set 20:\n\n(1 comment)","accounts_in_message":[],"_revision_number":20},{"id":"f7e9651708f5caf2c2a24a249551a6acbd1b69ff","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-05-19 09:19:32.000000000","message":"Uploaded patch set 21: Patch Set 20 was rebased.\n\nCopied Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":21},{"id":"5f08d08d5013665d56a0f580198773e6bd1169a8","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-05-23 06:14:05.000000000","message":"Patch Set 21:\n\n(1 comment)","accounts_in_message":[],"_revision_number":21},{"id":"05ed429c780837718e2d2817c0ddaa01b6d938f0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-06-04 23:16:14.000000000","message":"Uploaded patch set 22.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":22},{"id":"029f1a533c3147476355e1f6edb475bf9c669c58","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-06-05 10:21:24.000000000","message":"Patch Set 22:\n\n(1 comment)","accounts_in_message":[],"_revision_number":22},{"id":"d8e60cbc3cd7b9c522df0af454baef40942bf63b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-06-18 03:03:16.000000000","message":"Uploaded patch set 23: Patch Set 22 was rebased.","accounts_in_message":[],"_revision_number":23},{"id":"84a7543624d977dc56a0d76a2a70acd942bd244e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-06-18 12:47:25.000000000","message":"Uploaded patch set 24.","accounts_in_message":[],"_revision_number":24},{"id":"c0bde4906f953049ac58edeccb080d5201f348a3","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-06-18 12:48:16.000000000","message":"Patch Set 24: Code-Review+2","accounts_in_message":[],"_revision_number":24},{"id":"dbec062ebd5734c441cbc620e1885004b74a68c7","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-06-18 12:49:50.000000000","message":"Patch Set 24:\n\n(2 comments)","accounts_in_message":[],"_revision_number":24},{"id":"4de68b41e43fb1ac51200b07fd4a0b8f041ed39a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-06-18 13:01:09.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":25}],"current_revision_number":25,"current_revision":"2dfc4f82792b197dfa47d2bfe32c2af66b329611","revisions":{"213bbe8a196fae678f095663bd46c00b64c8b3a5":{"kind":"REWORK","_number":1,"created":"2025-03-06 22:15:08.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/1 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cb3cae580ee152d264838958a88f945fb12c8a58","subject":"dns: don\u0027t publish env vars to non-dns scripts"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-06 18:39:08.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-06 22:12:26.000000000","tz":60},"subject":"dns: clean up --dhcp-options when --dns is active","message":"dns: clean up --dhcp-options when --dns is active\n\nSince --dns setting overrule DNS related --dhcp-options,\nremove the latter when we got some via --dns.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"07395803f4286beeb194945f51135573dabe799d":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-03-07 02:39:34.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/2 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3d8024bd6be9f786cb633fcdeb8176afa7c669cd","subject":"dns: don\u0027t publish env vars to non-dns scripts"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-06 18:39:08.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-07 02:37:23.000000000","tz":60},"subject":"dns: clean up --dhcp-options when --dns is active","message":"dns: clean up --dhcp-options when --dns is active\n\nSince --dns setting overrule DNS related --dhcp-options,\nremove the latter when we got some via --dns.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"5ac90941b24a99bfc7c7715b178af05eb7882c7e":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-03-12 04:06:32.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/3 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6e5f33c3378acf5308303a0da3e8e17265308d9c","subject":"dns: don\u0027t publish env vars to non-dns scripts"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-06 18:39:08.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-12 04:06:10.000000000","tz":60},"subject":"dns: clean up --dhcp-options when --dns is active","message":"dns: clean up --dhcp-options when --dns is active\n\nSince --dns setting overrule DNS related --dhcp-options,\nremove the latter when we got some via --dns.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"7fa12434f09a7c3bb7d7b6579d6fb0f5e5e5b6f6":{"kind":"REWORK","_number":4,"created":"2025-03-14 04:21:29.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/4 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2d1cf23c0c69b07c61977929e4533d2480369593","subject":"dns: don\u0027t publish env vars to non-dns scripts"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-06 18:39:08.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-14 04:16:44.000000000","tz":60},"subject":"dns: clean up --dhcp-options when --dns is active","message":"dns: clean up --dhcp-options when --dns is active\n\nSince --dns settings overrule DNS related --dhcp-options,\nremove the latter when we got some via --dns.\n\nTo stay as backward compatible as possible, the --dns server addresses\nand search domains are added as foreign_options env vars, so that an\nexisting --up script can use them to set up DNS as before, without the\nimmediate need to change after an openvpn upgrade.\n\nIn case an --up script is defined, the --dns-script is not run to\nprevent potential double DNS configuration.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"ca31f6375a5e8e24e8adb80f6b050f8b17e052ab":{"kind":"REWORK","_number":5,"created":"2025-03-18 02:54:13.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/5 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2d1cf23c0c69b07c61977929e4533d2480369593","subject":"dns: don\u0027t publish env vars to non-dns scripts"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-06 18:39:08.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-18 02:52:40.000000000","tz":60},"subject":"dns: clean up --dhcp-options when --dns is active","message":"dns: clean up --dhcp-options when --dns is active\n\nSince --dns settings overrule DNS related --dhcp-options,\nremove the latter when we got some via --dns.\n\nTo stay as backward compatible as possible, the --dns server addresses\nand search domains are added as foreign_options env vars, so that an\nexisting --up script can use them to set up DNS as before, without the\nimmediate need to change after an openvpn upgrade.\n\nIn case an --up script is defined, the --dns-script is not run to\nprevent potential double DNS configuration.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"7e4117cf5b7a2f7a16c5a1015f28a7f88b48ec6a":{"kind":"REWORK","_number":6,"created":"2025-03-18 05:30:38.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/6","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/6","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/6 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/6","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7cb1d9ff276ef7558b587e184387c4441288e97a","subject":"dns: don\u0027t publish env vars to non-dns scripts"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-18 05:17:37.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-18 05:28:40.000000000","tz":60},"subject":"dns: clean up --dhcp-options when --dns is active","message":"dns: clean up --dhcp-options when --dns is active\n\nSince --dns settings overrule DNS related --dhcp-options,\nremove the latter when we got some via --dns.\n\nTo stay as backward compatible as possible, the --dns server addresses\nand search domains are added as foreign_options env vars, so that an\nexisting --up script can use them to set up DNS as before, without the\nimmediate need to change after an openvpn upgrade. Same goes for the\nDNS information in struct tuntap_options, which is used by Android.\n\nIn case an --up script is defined, the --dns-updown is not run to\nprevent potential double DNS configuration.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"1ca75adbb407037c39705e603171793de4cc1110":{"kind":"TRIVIAL_REBASE","_number":7,"created":"2025-03-19 23:21:50.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/7","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/7","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/7 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/7","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a4d6d0273c6c8fe66d505a762260646746397aaf","subject":"dns: don\u0027t publish env vars to non-dns scripts"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-18 05:17:37.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-19 22:44:15.000000000","tz":60},"subject":"dns: clean up --dhcp-options when --dns is active","message":"dns: clean up --dhcp-options when --dns is active\n\nSince --dns settings overrule DNS related --dhcp-options,\nremove the latter when we got some via --dns.\n\nTo stay as backward compatible as possible, the --dns server addresses\nand search domains are added as foreign_options env vars, so that an\nexisting --up script can use them to set up DNS as before, without the\nimmediate need to change after an openvpn upgrade. Same goes for the\nDNS information in struct tuntap_options, which is used by Android.\n\nIn case an --up script is defined, the --dns-updown is not run to\nprevent potential double DNS configuration.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"5f60fa98c7ebd85ad21437d6e4af9fdb782472c7":{"kind":"REWORK","_number":8,"created":"2025-03-20 02:51:34.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/8","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/8","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/8 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/8","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"435132ad990d705a377d874a0fc94bcde83ad8a9","subject":"dns: don\u0027t publish env vars to non-dns scripts"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-20 01:48:25.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-20 02:28:21.000000000","tz":60},"subject":"dns: deal with --dhcp-options when --dns is active","message":"dns: deal with --dhcp-options when --dns is active\n\nSince --dns settings overrule DNS related --dhcp-options,\nremove the latter when values were defined via --dns.\n\nTo stay as backward compatible as possible, we add foreign_options to\nthe script hook environment from the --dns values when a --up script\nis defined. In that case the default --dns-updown is not run, even\nwhen --dns values are present, to prevent double DNS configuration.\nThis way an existing --up script that deals with DNS can run, without\nthe immediate need to change after an openvpn upgrade and a server\npushing --dns options.\n\nIf you specify a custom --dns-updown, or force running the default\ndns-updown that comes with openvpn, those compat env vars are not set\nfor --up scripts and the dns-updown command is run, even when there\u0027s\nan --up script present.\n\nSince Android uses the DNS values from tuntap_options, we always\noverride those with --dns stuff unconditionally.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"09a8f8810444b3b8082aa713baa1436c90330ed0":{"kind":"REWORK","_number":9,"created":"2025-03-20 12:09:46.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/9","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/9","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/9 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/9","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/9 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"435132ad990d705a377d874a0fc94bcde83ad8a9","subject":"dns: don\u0027t publish env vars to non-dns scripts"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-20 01:48:25.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-20 12:08:33.000000000","tz":60},"subject":"dns: deal with --dhcp-options when --dns is active","message":"dns: deal with --dhcp-options when --dns is active\n\nSince --dns settings overrule DNS related --dhcp-options,\nremove the latter when values were defined via --dns.\n\nTo stay as backward compatible as possible, we add foreign_options to\nthe script hook environment from the --dns values when a --up script\nis defined. In that case the default --dns-updown is not run, even\nwhen --dns values are present, to prevent double DNS configuration.\nThis way an existing --up script that deals with DNS can run, without\nthe immediate need to change after an openvpn upgrade and a server\npushing --dns options.\n\nIf you specify a custom --dns-updown, or force running the default\ndns-updown that comes with openvpn, those compat env vars are not set\nfor --up scripts and the dns-updown command is run, even when there\u0027s\nan --up script present.\n\nSince Android uses the DNS values from tuntap_options, we always\noverride those with --dns stuff unconditionally.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"d0130777fd0701d37bc8a34e9beebf8fda707d69":{"kind":"TRIVIAL_REBASE","_number":10,"created":"2025-03-27 01:29:09.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/10","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/10","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/10 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/10","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/10 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d952bdf24b16ee81659e841fd347da632954ffe4","subject":"dns: don\u0027t publish env vars to non-dns scripts"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-20 01:48:25.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-27 01:23:16.000000000","tz":60},"subject":"dns: deal with --dhcp-options when --dns is active","message":"dns: deal with --dhcp-options when --dns is active\n\nSince --dns settings overrule DNS related --dhcp-options,\nremove the latter when values were defined via --dns.\n\nTo stay as backward compatible as possible, we add foreign_options to\nthe script hook environment from the --dns values when a --up script\nis defined. In that case the default --dns-updown is not run, even\nwhen --dns values are present, to prevent double DNS configuration.\nThis way an existing --up script that deals with DNS can run, without\nthe immediate need to change after an openvpn upgrade and a server\npushing --dns options.\n\nIf you specify a custom --dns-updown, or force running the default\ndns-updown that comes with openvpn, those compat env vars are not set\nfor --up scripts and the dns-updown command is run, even when there\u0027s\nan --up script present.\n\nSince Android uses the DNS values from tuntap_options, we always\noverride those with --dns stuff unconditionally.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"b6cc9bd2db91bcfafe120405e9af759c797fb393":{"kind":"TRIVIAL_REBASE","_number":11,"created":"2025-03-29 18:48:01.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/11","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/11","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/11 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/11","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/11 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dd182724c17cbea601156ffdf432886289fd6e34","subject":"dns: don\u0027t publish env vars to non-dns scripts"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-20 01:48:25.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-29 18:45:07.000000000","tz":60},"subject":"dns: deal with --dhcp-options when --dns is active","message":"dns: deal with --dhcp-options when --dns is active\n\nSince --dns settings overrule DNS related --dhcp-options,\nremove the latter when values were defined via --dns.\n\nTo stay as backward compatible as possible, we add foreign_options to\nthe script hook environment from the --dns values when a --up script\nis defined. In that case the default --dns-updown is not run, even\nwhen --dns values are present, to prevent double DNS configuration.\nThis way an existing --up script that deals with DNS can run, without\nthe immediate need to change after an openvpn upgrade and a server\npushing --dns options.\n\nIf you specify a custom --dns-updown, or force running the default\ndns-updown that comes with openvpn, those compat env vars are not set\nfor --up scripts and the dns-updown command is run, even when there\u0027s\nan --up script present.\n\nSince Android uses the DNS values from tuntap_options, we always\noverride those with --dns stuff unconditionally.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"91ad94dab5d28fb0acf43bfadf080899a0248699":{"kind":"REWORK","_number":12,"created":"2025-03-31 07:52:11.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/12","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/12","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/12 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/12 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/12 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/12 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/12","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/12 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"96ab983459225abd9911f1b6b06b1a6b70df1cb2","subject":"dns: don\u0027t publish env vars to non-dns scripts"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-20 01:48:25.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-31 07:48:44.000000000","tz":120},"subject":"dns: deal with --dhcp-options when --dns is active","message":"dns: deal with --dhcp-options when --dns is active\n\nSince --dns settings overrule DNS related --dhcp-options,\nremove the latter when values were defined via --dns.\n\nTo stay as backward compatible as possible, we add foreign_options to\nthe script hook environment from the --dns values when a --up script\nis defined. In that case the default --dns-updown is not run, even\nwhen --dns values are present, to prevent double DNS configuration.\nThis way an existing --up script that deals with DNS can run, without\nthe immediate need to change after an openvpn upgrade and a server\npushing --dns options.\n\nIf you specify a custom --dns-updown, or force running the default\ndns-updown that comes with openvpn, those compat env vars are not set\nfor --up scripts and the dns-updown command is run, even when there\u0027s\nan --up script present.\n\nSince Android uses the DNS values from tuntap_options, we always\noverride those with --dns stuff unconditionally. Also on Windows when\n--ip-win32 is dynamic or adaptive, since DHCP relies on these as well.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"c5e048dd2a8ae54fe87a902d91fe7ffabd917e04":{"kind":"TRIVIAL_REBASE","_number":13,"created":"2025-04-05 04:11:42.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/13","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/13","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/13 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/13 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/13 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/13 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/13","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/13 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f38cd4272f52282153b0a14d622ce5f570027f55","subject":"dns: don\u0027t publish env vars to non-dns scripts"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-20 01:48:25.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-04-05 04:11:04.000000000","tz":120},"subject":"dns: deal with --dhcp-options when --dns is active","message":"dns: deal with --dhcp-options when --dns is active\n\nSince --dns settings overrule DNS related --dhcp-options,\nremove the latter when values were defined via --dns.\n\nTo stay as backward compatible as possible, we add foreign_options to\nthe script hook environment from the --dns values when a --up script\nis defined. In that case the default --dns-updown is not run, even\nwhen --dns values are present, to prevent double DNS configuration.\nThis way an existing --up script that deals with DNS can run, without\nthe immediate need to change after an openvpn upgrade and a server\npushing --dns options.\n\nIf you specify a custom --dns-updown, or force running the default\ndns-updown that comes with openvpn, those compat env vars are not set\nfor --up scripts and the dns-updown command is run, even when there\u0027s\nan --up script present.\n\nSince Android uses the DNS values from tuntap_options, we always\noverride those with --dns stuff unconditionally. Also on Windows when\n--ip-win32 is dynamic or adaptive, since DHCP relies on these as well.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"20f298b09ecd76c869e46138cc16ee1e04be07ed":{"kind":"TRIVIAL_REBASE","_number":14,"created":"2025-04-05 04:16:22.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/14","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/14","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/14 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/14 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/14 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/14 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/14","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/14 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ca535398f059c76d0b5e18e1edf8ae3e347c546f","subject":"dns: don\u0027t publish env vars to non-dns scripts"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-20 01:48:25.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-04-05 04:15:49.000000000","tz":120},"subject":"dns: deal with --dhcp-options when --dns is active","message":"dns: deal with --dhcp-options when --dns is active\n\nSince --dns settings overrule DNS related --dhcp-options,\nremove the latter when values were defined via --dns.\n\nTo stay as backward compatible as possible, we add foreign_options to\nthe script hook environment from the --dns values when a --up script\nis defined. In that case the default --dns-updown is not run, even\nwhen --dns values are present, to prevent double DNS configuration.\nThis way an existing --up script that deals with DNS can run, without\nthe immediate need to change after an openvpn upgrade and a server\npushing --dns options.\n\nIf you specify a custom --dns-updown, or force running the default\ndns-updown that comes with openvpn, those compat env vars are not set\nfor --up scripts and the dns-updown command is run, even when there\u0027s\nan --up script present.\n\nSince Android uses the DNS values from tuntap_options, we always\noverride those with --dns stuff unconditionally. Also on Windows when\n--ip-win32 is dynamic or adaptive, since DHCP relies on these as well.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"ff83cbc2c3583c81c76d7b991a2a6f6232ef335e":{"kind":"REWORK","_number":15,"created":"2025-04-28 06:12:44.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/15","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/15","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/15 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/15 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/15 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/15 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/15","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/15 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"87f8ecffe083f8ffbb0d8954012ee0029846c571","subject":"dns: don\u0027t publish env vars to non-dns scripts"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-20 01:48:25.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-04-28 06:09:41.000000000","tz":120},"subject":"dns: deal with --dhcp-options when --dns is active","message":"dns: deal with --dhcp-options when --dns is active\n\nSince --dns settings overrule DNS related --dhcp-options,\nremove the latter when values were defined via --dns.\n\nTo stay as backward compatible as possible, we add foreign_options to\nthe script hook environment from the --dns values when a --up script\nis defined. In that case the default --dns-updown is not run, even\nwhen --dns values are present, to prevent double DNS configuration.\nThis way an existing --up script that deals with DNS can run, without\nthe immediate need to change after an openvpn upgrade and a server\npushing --dns options.\n\nIf you specify a custom --dns-updown, or force running the default\ndns-updown that comes with openvpn, those compat env vars are not set\nfor --up scripts and the dns-updown command is run, even when there\u0027s\nan --up script present.\n\nSince Android uses the DNS values from tuntap_options, we always\noverride those with --dns stuff unconditionally. Also on Windows when\n--ip-win32 is dynamic or adaptive, since DHCP relies on these as well.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"1210699c38464775e56b943c3603bc4431826ef6":{"kind":"TRIVIAL_REBASE","_number":16,"created":"2025-05-10 12:36:29.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/16","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/16","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/16 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/16 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/16 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/16 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/16","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/16 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"21baa5b6a3c8af54bef0c464aecda877678003bf","subject":"dns: don\u0027t publish env vars to non-dns scripts"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-20 01:48:25.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-05-10 12:36:07.000000000","tz":120},"subject":"dns: deal with --dhcp-options when --dns is active","message":"dns: deal with --dhcp-options when --dns is active\n\nSince --dns settings overrule DNS related --dhcp-options,\nremove the latter when values were defined via --dns.\n\nTo stay as backward compatible as possible, we add foreign_options to\nthe script hook environment from the --dns values when a --up script\nis defined. In that case the default --dns-updown is not run, even\nwhen --dns values are present, to prevent double DNS configuration.\nThis way an existing --up script that deals with DNS can run, without\nthe immediate need to change after an openvpn upgrade and a server\npushing --dns options.\n\nIf you specify a custom --dns-updown, or force running the default\ndns-updown that comes with openvpn, those compat env vars are not set\nfor --up scripts and the dns-updown command is run, even when there\u0027s\nan --up script present.\n\nSince Android uses the DNS values from tuntap_options, we always\noverride those with --dns stuff unconditionally. Also on Windows when\n--ip-win32 is dynamic or adaptive, since DHCP relies on these as well.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"837234ab4580e705677ab0ea5f52d4fcc015ac5f":{"kind":"TRIVIAL_REBASE","_number":17,"created":"2025-05-13 15:26:40.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/17","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/17","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/17 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/17 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/17 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/17 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/17","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/17 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"529102936743ee119ef69f380c3bd61c5fdc376b","subject":"dns: don\u0027t publish env vars to non-dns scripts"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-20 01:48:25.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-05-13 15:26:34.000000000","tz":120},"subject":"dns: deal with --dhcp-options when --dns is active","message":"dns: deal with --dhcp-options when --dns is active\n\nSince --dns settings overrule DNS related --dhcp-options,\nremove the latter when values were defined via --dns.\n\nTo stay as backward compatible as possible, we add foreign_options to\nthe script hook environment from the --dns values when a --up script\nis defined. In that case the default --dns-updown is not run, even\nwhen --dns values are present, to prevent double DNS configuration.\nThis way an existing --up script that deals with DNS can run, without\nthe immediate need to change after an openvpn upgrade and a server\npushing --dns options.\n\nIf you specify a custom --dns-updown, or force running the default\ndns-updown that comes with openvpn, those compat env vars are not set\nfor --up scripts and the dns-updown command is run, even when there\u0027s\nan --up script present.\n\nSince Android uses the DNS values from tuntap_options, we always\noverride those with --dns stuff unconditionally. Also on Windows when\n--ip-win32 is dynamic or adaptive, since DHCP relies on these as well.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"e6c1a4b2e357aba32c02df1015b84852050182b6":{"kind":"TRIVIAL_REBASE","_number":18,"created":"2025-05-13 22:11:31.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/18","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/18","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/18 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/18 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/18 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/18 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/18","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/18 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3aab8d9ad021d8dd34699b617ec2e0aca65e4df8","subject":"dns: don\u0027t publish env vars to non-dns scripts"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-20 01:48:25.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-05-13 22:11:19.000000000","tz":120},"subject":"dns: deal with --dhcp-options when --dns is active","message":"dns: deal with --dhcp-options when --dns is active\n\nSince --dns settings overrule DNS related --dhcp-options,\nremove the latter when values were defined via --dns.\n\nTo stay as backward compatible as possible, we add foreign_options to\nthe script hook environment from the --dns values when a --up script\nis defined. In that case the default --dns-updown is not run, even\nwhen --dns values are present, to prevent double DNS configuration.\nThis way an existing --up script that deals with DNS can run, without\nthe immediate need to change after an openvpn upgrade and a server\npushing --dns options.\n\nIf you specify a custom --dns-updown, or force running the default\ndns-updown that comes with openvpn, those compat env vars are not set\nfor --up scripts and the dns-updown command is run, even when there\u0027s\nan --up script present.\n\nSince Android uses the DNS values from tuntap_options, we always\noverride those with --dns stuff unconditionally. Also on Windows when\n--ip-win32 is dynamic or adaptive, since DHCP relies on these as well.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"5d9750f3d002fee427e6f121a8a2b0434e2bba87":{"kind":"NO_CHANGE","_number":19,"created":"2025-05-14 12:58:39.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/19","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/19","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/19 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/19 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/19 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/19 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/19","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/19 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b64383630501c4295cf24f5e6c0e8953ebb187c7","subject":"dns: don\u0027t publish env vars to non-dns scripts"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-20 01:48:25.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-05-14 12:57:44.000000000","tz":120},"subject":"dns: deal with --dhcp-options when --dns is active","message":"dns: deal with --dhcp-options when --dns is active\n\nSince --dns settings overrule DNS related --dhcp-options,\nremove the latter when values were defined via --dns.\n\nTo stay as backward compatible as possible, we add foreign_options to\nthe script hook environment from the --dns values when a --up script\nis defined. In that case the default --dns-updown is not run, even\nwhen --dns values are present, to prevent double DNS configuration.\nThis way an existing --up script that deals with DNS can run, without\nthe immediate need to change after an openvpn upgrade and a server\npushing --dns options.\n\nIf you specify a custom --dns-updown, or force running the default\ndns-updown that comes with openvpn, those compat env vars are not set\nfor --up scripts and the dns-updown command is run, even when there\u0027s\nan --up script present.\n\nSince Android uses the DNS values from tuntap_options, we always\noverride those with --dns stuff unconditionally. Also on Windows when\n--ip-win32 is dynamic or adaptive, since DHCP relies on these as well.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"d1e8192c6beeaf0949aa8e0e7ec72cacc027ff48":{"kind":"TRIVIAL_REBASE","_number":20,"created":"2025-05-15 15:28:47.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/20","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/20","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/20 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/20 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/20 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/20 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/20","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/20 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"93373d89bd56afb4ae281742b70760a4a469c011","subject":"dns: don\u0027t publish env vars to non-dns scripts"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-20 01:48:25.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-05-15 15:28:36.000000000","tz":120},"subject":"dns: deal with --dhcp-options when --dns is active","message":"dns: deal with --dhcp-options when --dns is active\n\nSince --dns settings overrule DNS related --dhcp-options,\nremove the latter when values were defined via --dns.\n\nTo stay as backward compatible as possible, we add foreign_options to\nthe script hook environment from the --dns values when a --up script\nis defined. In that case the default --dns-updown is not run, even\nwhen --dns values are present, to prevent double DNS configuration.\nThis way an existing --up script that deals with DNS can run, without\nthe immediate need to change after an openvpn upgrade and a server\npushing --dns options.\n\nIf you specify a custom --dns-updown, or force running the default\ndns-updown that comes with openvpn, those compat env vars are not set\nfor --up scripts and the dns-updown command is run, even when there\u0027s\nan --up script present.\n\nSince Android uses the DNS values from tuntap_options, we always\noverride those with --dns stuff unconditionally. Also on Windows when\n--ip-win32 is dynamic or adaptive, since DHCP relies on these as well.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"0f65f8e8296b2514bed1c65b0c65e5a738477dd1":{"kind":"TRIVIAL_REBASE","_number":21,"created":"2025-05-19 09:19:32.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/21","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/21","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/21 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/21 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/21 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/21 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/21","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/21 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"565d7cf48120d4394258fc3f2aa1b710315cd4e9","subject":"Explicit-exit-notify and multisocket interaction"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-20 01:48:25.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-05-19 09:19:29.000000000","tz":120},"subject":"dns: deal with --dhcp-options when --dns is active","message":"dns: deal with --dhcp-options when --dns is active\n\nSince --dns settings overrule DNS related --dhcp-options,\nremove the latter when values were defined via --dns.\n\nTo stay as backward compatible as possible, we add foreign_options to\nthe script hook environment from the --dns values when a --up script\nis defined. In that case the default --dns-updown is not run, even\nwhen --dns values are present, to prevent double DNS configuration.\nThis way an existing --up script that deals with DNS can run, without\nthe immediate need to change after an openvpn upgrade and a server\npushing --dns options.\n\nIf you specify a custom --dns-updown, or force running the default\ndns-updown that comes with openvpn, those compat env vars are not set\nfor --up scripts and the dns-updown command is run, even when there\u0027s\nan --up script present.\n\nSince Android uses the DNS values from tuntap_options, we always\noverride those with --dns stuff unconditionally. Also on Windows when\n--ip-win32 is dynamic or adaptive, since DHCP relies on these as well.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"e29d2285ed704db4974b4dcd705112cbb1552b4e":{"kind":"REWORK","_number":22,"created":"2025-06-04 23:16:14.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/22","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/22","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/22 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/22 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/22 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/22 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/22","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/22 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9cc7c68bd8d42b9e1c02fd3f069d404b5c056b57","subject":"Fix various badly placed comments in preparation for reformat"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-20 01:48:25.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-06-04 23:15:42.000000000","tz":120},"subject":"dns: deal with --dhcp-options when --dns is active","message":"dns: deal with --dhcp-options when --dns is active\n\nSince --dns settings overrule DNS related --dhcp-options,\nremove the latter when values were defined via --dns.\n\nTo stay as backward compatible as possible, we add foreign_options to\nthe script hook environment from the --dns values when a --up script\nis defined. In that case the default --dns-updown is not run, even\nwhen --dns values are present, to prevent double DNS configuration.\nThis way an existing --up script that deals with DNS can run, without\nthe immediate need to change after an openvpn upgrade and a server\npushing --dns options.\n\nIf you specify a custom --dns-updown, or force running the default\ndns-updown that comes with openvpn, those compat env vars are not set\nfor --up scripts and the dns-updown command is run, even when there\u0027s\nan --up script present.\n\nSince Android uses the DNS values from tuntap_options, we always\noverride those with --dns stuff unconditionally. Also on Windows when\n--ip-win32 is dynamic or adaptive, since DHCP relies on these as well.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"69dbb541f04f0902b8f607d1b2adbc234e85589a":{"kind":"TRIVIAL_REBASE","_number":23,"created":"2025-06-18 03:03:16.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/23","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/23","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/23 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/23 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/23 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/23 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/23","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/23 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"db9632f7f976a5e0b810d76173a38f76879d99c0","subject":"Preserve socket protocol during float processing"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-20 01:48:25.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-06-18 03:03:12.000000000","tz":120},"subject":"dns: deal with --dhcp-options when --dns is active","message":"dns: deal with --dhcp-options when --dns is active\n\nSince --dns settings overrule DNS related --dhcp-options,\nremove the latter when values were defined via --dns.\n\nTo stay as backward compatible as possible, we add foreign_options to\nthe script hook environment from the --dns values when a --up script\nis defined. In that case the default --dns-updown is not run, even\nwhen --dns values are present, to prevent double DNS configuration.\nThis way an existing --up script that deals with DNS can run, without\nthe immediate need to change after an openvpn upgrade and a server\npushing --dns options.\n\nIf you specify a custom --dns-updown, or force running the default\ndns-updown that comes with openvpn, those compat env vars are not set\nfor --up scripts and the dns-updown command is run, even when there\u0027s\nan --up script present.\n\nSince Android uses the DNS values from tuntap_options, we always\noverride those with --dns stuff unconditionally. Also on Windows when\n--ip-win32 is dynamic or adaptive, since DHCP relies on these as well.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"494c87939d93b24005429439760c963ef2223d37":{"kind":"REWORK","_number":24,"created":"2025-06-18 12:47:25.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/04/904/24","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/24","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/24 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/24 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/24 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/24 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/24","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/24 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"51b7dc5c1093b6df82aefd464873acb9ffc93882","subject":"fix typo in haikuos dns-updown script"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-03-20 01:48:25.000000000","tz":60},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-06-18 12:47:12.000000000","tz":120},"subject":"dns: deal with --dhcp-options when --dns is active","message":"dns: deal with --dhcp-options when --dns is active\n\nSince --dns settings overrule DNS related --dhcp-options,\nremove the latter when values were defined via --dns.\n\nTo stay as backward compatible as possible, we add foreign_options to\nthe script hook environment from the --dns values when a --up script\nis defined. In that case the default --dns-updown is not run, even\nwhen --dns values are present, to prevent double DNS configuration.\nThis way an existing --up script that deals with DNS can run, without\nthe immediate need to change after an openvpn upgrade and a server\npushing --dns options.\n\nIf you specify a custom --dns-updown, or force running the default\ndns-updown that comes with openvpn, those compat env vars are not set\nfor --up scripts and the dns-updown command is run, even when there\u0027s\nan --up script present.\n\nSince Android uses the DNS values from tuntap_options, we always\noverride those with --dns stuff unconditionally. Also on Windows when\n--ip-win32 is dynamic or adaptive, since DHCP relies on these as well.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"2dfc4f82792b197dfa47d2bfe32c2af66b329611":{"kind":"NO_CODE_CHANGE","_number":25,"created":"2025-06-18 13:01:09.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/04/904/25","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/904/25","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/25 \u0026\u0026 git checkout -b change-904 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/25 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/25 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/25 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/904/25","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/904/25 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"51b7dc5c1093b6df82aefd464873acb9ffc93882","subject":"fix typo in haikuos dns-updown script"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-06-18 12:48:29.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-06-18 12:51:10.000000000","tz":120},"subject":"dns: deal with --dhcp-options when --dns is active","message":"dns: deal with --dhcp-options when --dns is active\n\nSince --dns settings overrule DNS related --dhcp-options,\nremove the latter when values were defined via --dns.\n\nTo stay as backward compatible as possible, we add foreign_options to\nthe script hook environment from the --dns values when a --up script\nis defined. In that case the default --dns-updown is not run, even\nwhen --dns values are present, to prevent double DNS configuration.\nThis way an existing --up script that deals with DNS can run, without\nthe immediate need to change after an openvpn upgrade and a server\npushing --dns options.\n\nIf you specify a custom --dns-updown, or force running the default\ndns-updown that comes with openvpn, those compat env vars are not set\nfor --up scripts and the dns-updown command is run, even when there\u0027s\nan --up script present.\n\nSince Android uses the DNS values from tuntap_options, we always\noverride those with --dns stuff unconditionally. Also on Windows when\n--ip-win32 is dynamic or adaptive, since DHCP relies on these as well.\n\nChange-Id: I635c4018fb43b5976a39b6a90cb2e9cb2570cd6a\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250618124835.24737-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31922.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
