)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"f2fe87019ec06ae2deb978d65e61d46328eb7f71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"8c43aea8_c875b547","updated":"2025-05-19 14:55:29.000000000","message":"Let\u0027s wait before https://github.com/OpenVPN/openvpn/issues/747 is resolved.","commit_id":"ca8a4497f28dce3c59c5b721e7eaf8a85333985a"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"75db7e14faff78e26c801519a0bd41792778dd5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"08ead8dc_ac99596d","updated":"2025-05-20 10:35:43.000000000","message":"With #1005, this works as expected - when server pushes\n\n  push \"dns search-domains panoulu.local\"\n  push \"dns server 1 address 1.1.1.1\"\n  \nand \"panoulu.local\" is a connection-specific suffix in, say, Wi-Fi adapter,\nwe do not create an exclusion rule for panoulu.local.\n\nThis has revealed an issue with SearchList implementation, but this is out of scope of this change.","commit_id":"ca8a4497f28dce3c59c5b721e7eaf8a85333985a"}],"src/openvpnserv/interactive.c":[{"author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"change_message_id":"24c7815a1535b59bca2d3d625d1679acf9c2e9a6","unresolved":true,"context_lines":[{"line_number":2215,"context_line":"                /* Ignore itf domains which match pushed search domains */"},{"line_number":2216,"context_line":"                size_t domain_len \u003d wcslen(pos);"},{"line_number":2217,"context_line":"                PCWSTR match \u003d wcsstr(search_domains, pos);"},{"line_number":2218,"context_line":"                if (match \u0026\u0026 (match \u003d\u003d search_domains || *(match - 1) \u003d\u003d \u0027,\u0027)"},{"line_number":2219,"context_line":"                    \u0026\u0026 (*(match + domain_len) \u003d\u003d \u0027,\u0027 || *(match + domain_len) \u003d\u003d \u0027\\0\u0027))"},{"line_number":2220,"context_line":"                {"},{"line_number":2221,"context_line":"                    if (comma)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"d70b6712_811e8c80","line":2218,"updated":"2025-03-13 03:27:59.000000000","message":"The code doesn\u0027t deal with partial matches in the list, before a full match could be made. Instead of repeating the search from the point of the partial match, it gives up the search.","commit_id":"f9efafbb3868bd6a3d0f33deaad935dcdb1bdf22"},{"author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"change_message_id":"5fe30a5d8123549065217a72a70bf2aabdbcff48","unresolved":false,"context_lines":[{"line_number":2215,"context_line":"                /* Ignore itf domains which match pushed search domains */"},{"line_number":2216,"context_line":"                size_t domain_len \u003d wcslen(pos);"},{"line_number":2217,"context_line":"                PCWSTR match \u003d wcsstr(search_domains, pos);"},{"line_number":2218,"context_line":"                if (match \u0026\u0026 (match \u003d\u003d search_domains || *(match - 1) \u003d\u003d \u0027,\u0027)"},{"line_number":2219,"context_line":"                    \u0026\u0026 (*(match + domain_len) \u003d\u003d \u0027,\u0027 || *(match + domain_len) \u003d\u003d \u0027\\0\u0027))"},{"line_number":2220,"context_line":"                {"},{"line_number":2221,"context_line":"                    if (comma)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"90f6b889_929da8d7","line":2218,"in_reply_to":"d70b6712_811e8c80","updated":"2025-03-14 04:23:21.000000000","message":"Done","commit_id":"f9efafbb3868bd6a3d0f33deaad935dcdb1bdf22"}]}
