)]}'
{"id":"openvpn~912","triplet_id":"openvpn~master~I28a8abd0ee3fa9168a716171b0a405476089c4a1","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-03-24 07:20:32.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-03-24 07:20:32.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I28a8abd0ee3fa9168a716171b0a405476089c4a1","subject":"Fix incorrect condition for checking password related check","status":"MERGED","created":"2025-03-23 12:06:39.000000000","updated":"2025-03-24 07:20:32.000000000","submitted":"2025-03-24 07:20:32.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"912","meta_rev_id":"3cddf1d0c22b0df5763cff2053df0e8952032609","_number":912,"virtual_id_number":912,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-03-23 12:06:40.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-03-23 12:06:40.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-03-23 20:40:07.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"}],"messages":[{"id":"ca4951882ebad2bbdc5a8a811888ad245914214e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-03-23 12:06:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4eafccd2b478513f85c7c24f57289cd7afa68b5c","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-03-23 20:40:07.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3cddf1d0c22b0df5763cff2053df0e8952032609","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-03-24 07:20:32.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"15e663c898fe7a2350c35f5263cbad116cd5b61a","revisions":{"ca2f496faa8947a625b0bd958fb80f49cd30dc00":{"kind":"REWORK","_number":1,"created":"2025-03-23 12:06:39.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/12/912/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/12/912/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/912/1 \u0026\u0026 git checkout -b change-912 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/912/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/912/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/912/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/12/912/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/912/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6bb20fa8bebc29d8b3103662ffba4904d03e852d","subject":"Post tchar.h removal cleanup"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-03-23 12:01:55.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-03-23 12:06:15.000000000","tz":60},"subject":"Fix incorrect condition for checking password related check","message":"Fix incorrect condition for checking password related check\n\nCommit db48cea chagned logic to move logic from a variable and repeated\nchecks to an if clause.\n\nThe old code had\n\n            const bool ccnr \u003d (options-\u003eauth_user_pass_verify_script\n                                || PLUGIN_OPTION_LIST(options)\n                                || MAN_CLIENT_AUTH_ENABLED(options));\n\nfollowed by several condition that checked !ccnr\n\nThis commit fixes the if clause by correctly applying De Margan\u0027s law.\n\nChange-Id: I28a8abd0ee3fa9168a716171b0a405476089c4a1\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"15e663c898fe7a2350c35f5263cbad116cd5b61a":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-03-24 07:20:32.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/12/912/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/12/912/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/912/2 \u0026\u0026 git checkout -b change-912 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/912/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/912/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/912/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/12/912/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/12/912/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6bb20fa8bebc29d8b3103662ffba4904d03e852d","subject":"Post tchar.h removal cleanup"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-03-23 21:13:53.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-03-24 07:13:58.000000000","tz":60},"subject":"Fix incorrect condition for checking password related check","message":"Fix incorrect condition for checking password related check\n\nCommit db48cea chagned logic to move logic from a variable and repeated\nchecks to an if clause.\n\nThe old code had\n\n            const bool ccnr \u003d (options-\u003eauth_user_pass_verify_script\n                                || PLUGIN_OPTION_LIST(options)\n                                || MAN_CLIENT_AUTH_ENABLED(options));\n\nfollowed by several condition that checked !ccnr\n\nThis commit fixes the if clause by correctly applying De Morgan\u0027s law.\n\nGithub: closes OpenVPN/openvpn#706\n\nChange-Id: I28a8abd0ee3fa9168a716171b0a405476089c4a1\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nMessage-Id: \u003c20250323211359.14117-1-gert@greenie.muc.de\u003e\nURL: https://sourceforge.net/p/openvpn/mailman/message/59164222/\nURL: http://gerrit.openvpn.net/c/openvpn/+/912\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}