)]}'
{"id":"openvpn~913","triplet_id":"openvpn~master~I1c2c050dd160746a0f8d9c234abe1e258bc8e48d","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-04-09 09:34:26.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-03-24 14:03:49.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}},"hashtags":[],"change_id":"I1c2c050dd160746a0f8d9c234abe1e258bc8e48d","subject":"Use USER_PASS_LEN instead of TLS_USERNAME_LEN for override-username","status":"MERGED","created":"2025-03-24 11:31:16.000000000","updated":"2025-04-09 09:34:26.000000000","submitted":"2025-04-09 09:34:26.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"913","meta_rev_id":"5beeb503aac8dccde4b1c1b172fcf19663a6e0d3","_number":913,"virtual_id_number":913,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-03-24 11:31:16.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-03-24 11:31:16.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-04-02 13:45:28.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"940c53f4c20348575b5064764efb2beff39232df","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-03-24 11:31:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3f027f52ee5d3414a8db91cd03886b81b56c5635","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-03-24 12:59:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2557486a233cb745d6d1ea91066564f80c577cae","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-03-24 13:38:56.000000000","message":"Patch Set 2: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"4638a52d16615334868704965b18e8980448dabb","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-03-24 13:42:29.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"5c2710e400608c963958fbf6aab1ca93205bae21","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-03-24 13:43:40.000000000","message":"Uploaded patch set 3.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":3},{"id":"e429ed6f516488a4dbf4251cdc013221c55fd413","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-03-24 14:03:49.000000000","message":"Patch Set 3: -Code-Review","accounts_in_message":[],"_revision_number":3},{"id":"ee3dc4e2ad17fa9de4a75abdcc2bcba7abed30ff","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-04-02 13:45:28.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"5beeb503aac8dccde4b1c1b172fcf19663a6e0d3","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-04-09 09:34:26.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"bb8f2e373cf5d6c4d4320694ddd14bb61d5756b3","revisions":{"63338b396d2e90493e62eb5b2aa64529b9a13854":{"kind":"REWORK","_number":1,"created":"2025-03-24 11:31:16.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/13/913/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/13/913/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/913/1 \u0026\u0026 git checkout -b change-913 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/913/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/913/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/913/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/13/913/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/913/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8ea5debaea01da5fee56fbad56b50820c1beee92","subject":"win: calculate address string buffer size"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-03-23 12:05:48.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-03-24 11:01:01.000000000","tz":60},"subject":"Use USER_PASS_LEN instead of TLS_USERNAME_LEN for override-username","message":"Use USER_PASS_LEN instead of TLS_USERNAME_LEN for override-username\n\nChange-Id: I1c2c050dd160746a0f8d9c234abe1e258bc8e48d\n"},"branch":"refs/heads/master"},"3b1837e2adfeeb1b472a3c1273ff2f61432a168a":{"kind":"REWORK","_number":2,"created":"2025-03-24 12:59:52.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/13/913/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/13/913/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/913/2 \u0026\u0026 git checkout -b change-913 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/913/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/913/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/913/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/13/913/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/913/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8ea5debaea01da5fee56fbad56b50820c1beee92","subject":"win: calculate address string buffer size"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-03-23 12:05:48.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-03-24 12:59:26.000000000","tz":60},"subject":"Use USER_PASS_LEN instead of TLS_USERNAME_LEN for override-username","message":"Use USER_PASS_LEN instead of TLS_USERNAME_LEN for override-username\n\nCurrently override-username is artificially restricted to the length of\nTLS common-name for the corner case of using username-as-common-name, which\nwe explicitly do not recommend.\n\nDo away with that limitation and only error out on longer usernames when\nusername-as-common-name is actually in effect.\n\nChange-Id: I1c2c050dd160746a0f8d9c234abe1e258bc8e48d\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"8fb5c4f8685f9b837f7e23f3bf3b248682b10e64":{"kind":"REWORK","_number":3,"created":"2025-03-24 13:43:40.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/13/913/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/13/913/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/913/3 \u0026\u0026 git checkout -b change-913 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/913/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/913/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/913/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/13/913/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/913/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8ea5debaea01da5fee56fbad56b50820c1beee92","subject":"win: calculate address string buffer size"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-03-23 12:05:48.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-03-24 13:42:47.000000000","tz":60},"subject":"Use USER_PASS_LEN instead of TLS_USERNAME_LEN for override-username","message":"Use USER_PASS_LEN instead of TLS_USERNAME_LEN for override-username\n\nCurrently override-username is artificially restricted to the length of\nTLS common-name (64) for the corner case of using username-as-common-name,\nwhich we explicitly do not recommend to use.\n\nDo away with that limitation and only error out on longer usernames when\nusername-as-common-name is actually in effect.\n\nChange-Id: I1c2c050dd160746a0f8d9c234abe1e258bc8e48d\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"bb8f2e373cf5d6c4d4320694ddd14bb61d5756b3":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-04-09 09:34:26.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/13/913/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/13/913/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/913/4 \u0026\u0026 git checkout -b change-913 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/913/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/913/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/913/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/13/913/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/13/913/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b60d2bb98c77d5836b7e3e2d21eeeb17aa55d3f2","subject":"Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-04-02 13:45:39.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-04-09 09:26:24.000000000","tz":120},"subject":"Use USER_PASS_LEN instead of TLS_USERNAME_LEN for override-username","message":"Use USER_PASS_LEN instead of TLS_USERNAME_LEN for override-username\n\nCurrently override-username is artificially restricted to the length of\nTLS common-name (64) for the corner case of using username-as-common-name,\nwhich we explicitly do not recommend to use.\n\nDo away with that limitation and only error out on longer usernames when\nusername-as-common-name is actually in effect.\n\nChange-Id: I1c2c050dd160746a0f8d9c234abe1e258bc8e48d\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250402134546.3504-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31323.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
