)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"07a3278f05e54f0079240da8bc894b23cbe56539","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix mbed TLS key exporter functionality in 3.6.x and cmake"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Cmake did not check for the mbedtls_ssl_set_export_keys_cb symbol"},{"line_number":10,"context_line":"when generating an mbed TLS configuration. This cause no actual"},{"line_number":11,"context_line":"working key exporter to be in the binary."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also add an explicit #error to catch this situation during compilation."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"efbbf0b6_3e858402","line":10,"updated":"2025-04-25 11:42:42.000000000","message":"\"causes\"","commit_id":"d84ecb20edf47842f208983cec2702198465c0fd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"1b6c84cad12ab6a160b901dfc24ff0956fa029d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5077a5e1_f4b4267f","updated":"2025-03-27 15:43:08.000000000","message":"Tiny bug in the error message, but the change makes sense.\n\nWhat I don\u0027t understand is how this gets triggered. I looked at configure.ac again and as far as I understand it, it does the following (starting from line 1041):\n\nSet have_export_keying_material to \"yes\".\nCheck if mbedtls_ssl_conf_export_keys_ext_cb exists.\nIf not, check if mbedtls_ssl_set_export_keys_cb exists.\nIf that doesn\u0027t exist either, set have_export_keying_material to \"no\".","commit_id":"89f885475ce1d355d4355e7c1aedbc686647ef11"},{"author":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"c559da175e326d921664c4698ee2e599e99dce14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4c83d686_af56bcc6","in_reply_to":"5077a5e1_f4b4267f","updated":"2025-03-27 15:45:55.000000000","message":"Disregard that, I forgot that we also build with cmake.","commit_id":"89f885475ce1d355d4355e7c1aedbc686647ef11"}],"src/openvpn/ssl_mbedtls.c":[{"author":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"1b6c84cad12ab6a160b901dfc24ff0956fa029d7","unresolved":true,"context_lines":[{"line_number":254,"context_line":"    cache-\u003etls_prf_type \u003d tls_prf_type;"},{"line_number":255,"context_line":"}"},{"line_number":256,"context_line":"#else  /* if HAVE_MBEDTLS_SSL_CONF_EXPORT_KEYS_EXT_CB */"},{"line_number":257,"context_line":"#error either HAVE_MBEDTLS_SSL_CONF_EXPORT_KEYS_EXT_CB or HAVE_MBEDTLS_SSL_CONF_EXPORT_KEYS_EXT_CB must be defined when HAVE_EXPORT_KEYING_MATERIAL is defined"},{"line_number":258,"context_line":"#endif /* HAVE_MBEDTLS_SSL_CONF_EXPORT_KEYS_EXT_CB */"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"bool"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1220b775_cb2a77f6","line":257,"range":{"start_line":257,"start_character":58,"end_line":257,"end_character":98},"updated":"2025-03-27 15:43:08.000000000","message":"The second one should be HAVE_MBEDTLS_SSL_SET_EXPORT_KEYS_CB","commit_id":"89f885475ce1d355d4355e7c1aedbc686647ef11"}]}
