)]}'
{"id":"openvpn~920","triplet_id":"openvpn~master~If38e80e268dc0ee7e57de2c175c5b4db0ce55ed0","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-04-25 13:22:07.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-04-25 11:42:42.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}},"hashtags":[],"change_id":"If38e80e268dc0ee7e57de2c175c5b4db0ce55ed0","subject":"Fix mbed TLS key exporter functionality in 3.6.x and cmake","status":"MERGED","created":"2025-03-26 13:44:38.000000000","updated":"2025-04-25 13:22:07.000000000","submitted":"2025-04-25 13:22:07.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":4,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"920","meta_rev_id":"f64724aac3a9bbfb6a93883dbbe68d2ae6ee1fdc","_number":920,"virtual_id_number":920,"owner":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-03-26 13:44:39.000000000","updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-03-26 13:44:39.000000000","updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-03-27 15:43:08.000000000","updated_by":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"real_updated_by":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"reviewer":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"state":"CC"}],"messages":[{"id":"3abc5d0ee7424821662cf58fe98d89b95c4c793f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-03-26 13:44:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1b6c84cad12ab6a160b901dfc24ff0956fa029d7","author":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"date":"2025-03-27 15:43:08.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"c559da175e326d921664c4698ee2e599e99dce14","author":{"_account_id":1000030,"name":"Max Fillinger","email":"max@max-fillinger.net","username":"MaxF"},"date":"2025-03-27 15:45:55.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8f04c98cb4ed9d5c40a4850dd37137becc5aec99","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-04-08 16:16:53.000000000","message":"Patch Set 2: Patch Set 1 was rebased on behalf of \u003cGERRIT_ACCOUNT_1000003\u003e","accounts_in_message":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"_revision_number":2},{"id":"099fcc1c59a17b194ce027ed7bfecd215c7d9be0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-04-16 14:11:42.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"07a3278f05e54f0079240da8bc894b23cbe56539","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-04-25 11:42:42.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"f64724aac3a9bbfb6a93883dbbe68d2ae6ee1fdc","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-04-25 13:22:07.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"f563556bbfee729053d5c123ebc1bad6277f4c65","revisions":{"89f885475ce1d355d4355e7c1aedbc686647ef11":{"kind":"REWORK","_number":1,"created":"2025-03-26 13:44:38.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/20/920/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/20/920/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/920/1 \u0026\u0026 git checkout -b change-920 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/920/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/920/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/920/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/20/920/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/920/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d16781531898b4c5a76cfe6cba02fccce9afb8ad","subject":"Mention address if not unspecific on DNS failure"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-03-26 13:37:21.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-03-26 13:44:13.000000000","tz":60},"subject":"Fix mbed TLS key exporter functionality in 3.6.x and cmake","message":"Fix mbed TLS key exporter functionality in 3.6.x and cmake\n\nCmake did not check for the mbedtls_ssl_set_export_keys_cb symbol\nwhen generating an mbed TLS configuration. This cause no actual\nworking key exporter to be in the binary.\n\nAlso add an explicit #error to catch this situation during compilation.\n\nChange-Id: If38e80e268dc0ee7e57de2c175c5b4db0ce55ed0\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"559951a449bc35e9c6daf7c4e0e44714af3b7a91":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-04-08 16:16:53.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/20/920/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/20/920/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/920/2 \u0026\u0026 git checkout -b change-920 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/920/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/920/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/920/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/20/920/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/920/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b60d2bb98c77d5836b7e3e2d21eeeb17aa55d3f2","subject":"Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-03-26 13:37:21.000000000","tz":60},"committer":{"name":"plaisthos","email":"arne-openvpn@rfc2549.org","date":"2025-04-08 16:16:53.000000000","tz":0},"subject":"Fix mbed TLS key exporter functionality in 3.6.x and cmake","message":"Fix mbed TLS key exporter functionality in 3.6.x and cmake\n\nCmake did not check for the mbedtls_ssl_set_export_keys_cb symbol\nwhen generating an mbed TLS configuration. This cause no actual\nworking key exporter to be in the binary.\n\nAlso add an explicit #error to catch this situation during compilation.\n\nChange-Id: If38e80e268dc0ee7e57de2c175c5b4db0ce55ed0\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master","description":"Rebase"},"d84ecb20edf47842f208983cec2702198465c0fd":{"kind":"REWORK","_number":3,"created":"2025-04-16 14:11:42.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/20/920/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/20/920/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/920/3 \u0026\u0026 git checkout -b change-920 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/920/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/920/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/920/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/20/920/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/920/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7846055717d138e6b1130cec67412acf127e9b78","subject":"win: allow OpenVPN service account to use any command-line options"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-03-26 13:37:21.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-04-16 14:11:31.000000000","tz":120},"subject":"Fix mbed TLS key exporter functionality in 3.6.x and cmake","message":"Fix mbed TLS key exporter functionality in 3.6.x and cmake\n\nCmake did not check for the mbedtls_ssl_set_export_keys_cb symbol\nwhen generating an mbed TLS configuration. This cause no actual\nworking key exporter to be in the binary.\n\nAlso add an explicit #error to catch this situation during compilation.\n\nChange-Id: If38e80e268dc0ee7e57de2c175c5b4db0ce55ed0\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"f563556bbfee729053d5c123ebc1bad6277f4c65":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-04-25 13:22:07.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/20/920/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/20/920/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/920/4 \u0026\u0026 git checkout -b change-920 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/920/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/920/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/920/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/20/920/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/920/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f7aedca70e24e9a35f0cbd33d1aa708b4daf0055","subject":"ssl_openssl.c: Prevent potential double-free"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-04-25 13:09:54.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-04-25 13:19:01.000000000","tz":120},"subject":"Fix mbed TLS key exporter functionality in 3.6.x and cmake","message":"Fix mbed TLS key exporter functionality in 3.6.x and cmake\n\nCmake did not check for the mbedtls_ssl_set_export_keys_cb symbol\nwhen generating an mbed TLS configuration. This causes no actual\nworking key exporter to be in the binary.\n\nAlso add an explicit #error to catch this situation during compilation.\n\nChange-Id: If38e80e268dc0ee7e57de2c175c5b4db0ce55ed0\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20250425131002.21772-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31510.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
