)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"1d7c5223805ac5d9c2e620ecced6d88181227f41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b6295e77_d8aa89b9","updated":"2025-03-28 21:34:30.000000000","message":"questions...","commit_id":"6a8af0e432d22001c3896bf45461c00ba22d79a7"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"4ee29fd67fdb50bc583826ea697d8e666d4a99e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e03f0e43_f02a9a49","updated":"2025-04-02 13:20:39.000000000","message":"seems windows does not need it (because we currently support only 1 socket for server \u0026\u0026 DCO, so the 1 socket-check works) - so let\u0027s proceed this.","commit_id":"6a8af0e432d22001c3896bf45461c00ba22d79a7"}],"src/openvpn/dco.c":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"1d7c5223805ac5d9c2e620ecced6d88181227f41","unresolved":true,"context_lines":[{"line_number":260,"context_line":"    }"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"#if defined(TARGET_FREEBSD)"},{"line_number":263,"context_line":"    if (ce-\u003elocal_list)"},{"line_number":264,"context_line":"    {"},{"line_number":265,"context_line":"        for (int i \u003d 0; i \u003c ce-\u003elocal_list-\u003elen; i++)"},{"line_number":266,"context_line":"        {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9d655d2e_4fc29dc7","line":263,"updated":"2025-03-28 21:34:30.000000000","message":"will this also catch clients that have no `--local` at all, just `--remote ... tcp`?  FreeBSD DCO also needs to be disabled for TCP clients.","commit_id":"6a8af0e432d22001c3896bf45461c00ba22d79a7"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"4ee29fd67fdb50bc583826ea697d8e666d4a99e1","unresolved":false,"context_lines":[{"line_number":260,"context_line":"    }"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"#if defined(TARGET_FREEBSD)"},{"line_number":263,"context_line":"    if (ce-\u003elocal_list)"},{"line_number":264,"context_line":"    {"},{"line_number":265,"context_line":"        for (int i \u003d 0; i \u003c ce-\u003elocal_list-\u003elen; i++)"},{"line_number":266,"context_line":"        {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b1c9e52b_61c0c566","line":263,"in_reply_to":"9d655d2e_4fc29dc7","updated":"2025-04-02 13:20:39.000000000","message":"Done","commit_id":"6a8af0e432d22001c3896bf45461c00ba22d79a7"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"1d7c5223805ac5d9c2e620ecced6d88181227f41","unresolved":true,"context_lines":[{"line_number":274,"context_line":"#endif"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"#if defined(_WIN32)"},{"line_number":277,"context_line":"    if (!proto_is_udp(ce-\u003eproto) \u0026\u0026 mode \u003d\u003d MODE_SERVER)"},{"line_number":278,"context_line":"    {"},{"line_number":279,"context_line":"        msg(msglevel, \"NOTE: TCP transport disables data channel offload on Windows in server mode.\");"},{"line_number":280,"context_line":"        return false;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"95331584_9525203f","line":277,"updated":"2025-03-28 21:34:30.000000000","message":"this looks as if we need the fix for windows too...  maybe keep \u0026 use the has_tcp_in_local_list() for this?","commit_id":"6a8af0e432d22001c3896bf45461c00ba22d79a7"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"4ee29fd67fdb50bc583826ea697d8e666d4a99e1","unresolved":false,"context_lines":[{"line_number":274,"context_line":"#endif"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"#if defined(_WIN32)"},{"line_number":277,"context_line":"    if (!proto_is_udp(ce-\u003eproto) \u0026\u0026 mode \u003d\u003d MODE_SERVER)"},{"line_number":278,"context_line":"    {"},{"line_number":279,"context_line":"        msg(msglevel, \"NOTE: TCP transport disables data channel offload on Windows in server mode.\");"},{"line_number":280,"context_line":"        return false;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"b50916b0_8d184b77","line":277,"in_reply_to":"95331584_9525203f","updated":"2025-04-02 13:20:39.000000000","message":"Done","commit_id":"6a8af0e432d22001c3896bf45461c00ba22d79a7"}]}
