)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"13f140cbb14dd3ee2a994ff97b45743d51ad9a7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"de3dcbb8_ffe70b1a","updated":"2025-04-02 13:50:58.000000000","message":"patch makes sense and does what it says.\nOur openssl-ifdef-foomble-moomble is already a bit out of control and nothing this patch can do about...","commit_id":"ec2b1d68450cdc19bf610d24b2ebf0bd6d993198"}],"src/openvpn/ssl_openssl.c":[{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"e6dc6fcb48f84cd855550a950b5c9a3fef496714","unresolved":true,"context_lines":[{"line_number":2459,"context_line":"    const char *peer_sig \u003d peer_sig_unknown;"},{"line_number":2460,"context_line":"    const char *peer_sig_type \u003d \"unknown type\";"},{"line_number":2461,"context_line":""},{"line_number":2462,"context_line":"    const char *signame \u003d NULL;"},{"line_number":2463,"context_line":"    SSL_get0_peer_signature_name(ssl, \u0026signame);"},{"line_number":2464,"context_line":"    if (signame)"},{"line_number":2465,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"7f90eb24_00ca004f","line":2462,"updated":"2025-04-01 11:41:52.000000000","message":"I presume you added the empty line on the wrong side?\nIt should be below and not above?","commit_id":"ec2b1d68450cdc19bf610d24b2ebf0bd6d993198"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"13f140cbb14dd3ee2a994ff97b45743d51ad9a7b","unresolved":false,"context_lines":[{"line_number":2459,"context_line":"    const char *peer_sig \u003d peer_sig_unknown;"},{"line_number":2460,"context_line":"    const char *peer_sig_type \u003d \"unknown type\";"},{"line_number":2461,"context_line":""},{"line_number":2462,"context_line":"    const char *signame \u003d NULL;"},{"line_number":2463,"context_line":"    SSL_get0_peer_signature_name(ssl, \u0026signame);"},{"line_number":2464,"context_line":"    if (signame)"},{"line_number":2465,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"648cca6f_9030f9dc","line":2462,"in_reply_to":"2c6e0983_be364558","updated":"2025-04-02 13:50:58.000000000","message":"Acknowledged","commit_id":"ec2b1d68450cdc19bf610d24b2ebf0bd6d993198"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"5257f54f370a8578035ff0fbb573c79c3b690f1d","unresolved":true,"context_lines":[{"line_number":2459,"context_line":"    const char *peer_sig \u003d peer_sig_unknown;"},{"line_number":2460,"context_line":"    const char *peer_sig_type \u003d \"unknown type\";"},{"line_number":2461,"context_line":""},{"line_number":2462,"context_line":"    const char *signame \u003d NULL;"},{"line_number":2463,"context_line":"    SSL_get0_peer_signature_name(ssl, \u0026signame);"},{"line_number":2464,"context_line":"    if (signame)"},{"line_number":2465,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"2c6e0983_be364558","line":2462,"in_reply_to":"7f90eb24_00ca004f","updated":"2025-04-01 11:44:12.000000000","message":"No. As signame belongs to the block below as helper variable while the other are valid for the whole function.","commit_id":"ec2b1d68450cdc19bf610d24b2ebf0bd6d993198"}]}