)]}'
{"id":"openvpn~927","triplet_id":"openvpn~master~I2bc782ceebcc91a8dc8ada0bb72ac042be46cad6","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-04-08 11:31:02.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-04-08 11:31:02.000000000","reason":"Change was submitted"},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2025-04-02 13:50:58.000000000","reason":"\u003cGERRIT_ACCOUNT_1000007\u003e replied on the change","reason_account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}}},"hashtags":[],"change_id":"I2bc782ceebcc91a8dc8ada0bb72ac042be46cad6","subject":"Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid","status":"MERGED","created":"2025-04-01 08:29:05.000000000","updated":"2025-04-08 11:31:02.000000000","submitted":"2025-04-08 11:31:02.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"927","meta_rev_id":"79e74015b4a75f6cee035531eeab549c5c2807aa","_number":927,"virtual_id_number":927,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-04-01 08:29:07.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-04-01 08:29:07.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-04-01 11:41:52.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"CC"},{"updated":"2025-04-02 13:50:58.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"}],"messages":[{"id":"14f51b756574c5f6d88ca6f64dc2f750fb0707f0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-04-01 08:29:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c2764165f4f46486827dc329706803a0d0a4fa4b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-04-01 11:33:58.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"4ab536d09d8e6eb46990599e7a673ff1367e448d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-04-01 11:38:18.000000000","message":"Patch Set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"655df886266bb310d17226d3d23911d42cd9e4d3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-04-01 11:38:51.000000000","message":"Patch Set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"e6dc6fcb48f84cd855550a950b5c9a3fef496714","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-04-01 11:41:52.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"5257f54f370a8578035ff0fbb573c79c3b690f1d","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-04-01 11:44:12.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"13f140cbb14dd3ee2a994ff97b45743d51ad9a7b","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-04-02 13:50:58.000000000","message":"Patch Set 4: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"79e74015b4a75f6cee035531eeab549c5c2807aa","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-04-08 11:31:02.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"b60d2bb98c77d5836b7e3e2d21eeeb17aa55d3f2","revisions":{"5cacad0a69ef5881d3d1c4925ebce9282258f5f9":{"kind":"REWORK","_number":1,"created":"2025-04-01 08:29:05.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/27/927/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/27/927/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/1 \u0026\u0026 git checkout -b change-927 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/27/927/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7825a8c586a8beba209370f1594cd0987b653ab7","subject":"Do not leave half-initialised key wrap struct when dynamic tls-crypt fails"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-04-01 07:41:55.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-04-01 08:28:48.000000000","tz":120},"subject":"Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid","message":"Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid\n\nSSL_get0_peer_signature_name return a string instead of hardcoded NIDs that\ndo not work with provider provided signatures or the new PQ signatures\nintroduced in OpenSSL 3.5.\n\nRemove also the comment that was added earlier that says that there no\nproper API replacement for SSL_get_peer_signature_nid yet as OpenSSL\n3.5.0 has now introduced it.\n\nChange-Id: I2bc782ceebcc91a8dc8ada0bb72ac042be46cad6\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"48d8ad5578b30e4754066ec0cc95e62a7f85ba1d":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-04-01 11:33:58.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/27/927/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/27/927/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/2 \u0026\u0026 git checkout -b change-927 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/27/927/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7825a8c586a8beba209370f1594cd0987b653ab7","subject":"Do not leave half-initialised key wrap struct when dynamic tls-crypt fails"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-04-01 07:41:55.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-04-01 11:33:41.000000000","tz":120},"subject":"Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid","message":"Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid\n\nSSL_get0_peer_signature_name returns a string instead of hardcoded NIDs.\nNIDS do not work with provider provided signatures or the new PQ\nsignatures introduced in OpenSSL 3.5.\n\nRemove also the comment that was added earlier that says that there no\nproper API replacement for SSL_get_peer_signature_nid yet as OpenSSL\n3.5.0 has now introduced it.\n\nChange-Id: I2bc782ceebcc91a8dc8ada0bb72ac042be46cad6\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"65e0cb11cf457416d44b060aafe86c490d13106e":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2025-04-01 11:38:18.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/27/927/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/27/927/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/3 \u0026\u0026 git checkout -b change-927 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/27/927/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7825a8c586a8beba209370f1594cd0987b653ab7","subject":"Do not leave half-initialised key wrap struct when dynamic tls-crypt fails"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-04-01 07:41:55.000000000","tz":120},"committer":{"name":"ordex","email":"antonio@mandelbit.com","date":"2025-04-01 11:38:18.000000000","tz":0},"subject":"Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid","message":"Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid\n\nSSL_get0_peer_signature_name returns a string instead of hardcoded NIDs.\nNIDS do not work with provider provided signatures or the new PQ\nsignatures introduced in OpenSSL 3.5.\n\nRemove also the comment that was added earlier that says that there\nis no proper API replacement for SSL_get_peer_signature_nid yet as OpenSSL\n3.5.0 has now introduced it.\n\nChange-Id: I2bc782ceebcc91a8dc8ada0bb72ac042be46cad6\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master","description":"Edit commit message"},"ec2b1d68450cdc19bf610d24b2ebf0bd6d993198":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2025-04-01 11:38:51.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/27/927/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/27/927/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/4 \u0026\u0026 git checkout -b change-927 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/27/927/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7825a8c586a8beba209370f1594cd0987b653ab7","subject":"Do not leave half-initialised key wrap struct when dynamic tls-crypt fails"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-04-01 07:41:55.000000000","tz":120},"committer":{"name":"ordex","email":"antonio@mandelbit.com","date":"2025-04-01 11:38:51.000000000","tz":0},"subject":"Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid","message":"Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid\n\nSSL_get0_peer_signature_name returns a string instead of hardcoded NIDs.\nNIDS do not work with provider provided signatures or the new PQ\nsignatures introduced in OpenSSL 3.5.\n\nRemove also the comment that was added earlier that says that there\nis no proper API replacement for SSL_get_peer_signature_nid yet as\nOpenSSL 3.5.0 has now introduced it.\n\nChange-Id: I2bc782ceebcc91a8dc8ada0bb72ac042be46cad6\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master","description":"Edit commit message"},"b60d2bb98c77d5836b7e3e2d21eeeb17aa55d3f2":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2025-04-08 11:31:02.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/27/927/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/27/927/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/5 \u0026\u0026 git checkout -b change-927 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/27/927/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/927/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a51fb119d7e9a9db9173a10f9e20a4035ca76bbe","subject":"manpage: fix HTML format for --local"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-04-02 15:33:28.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-04-08 11:28:36.000000000","tz":120},"subject":"Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid","message":"Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid\n\nSSL_get0_peer_signature_name returns a string instead of hardcoded NIDs.\nNIDS do not work with provider provided signatures or the new PQ\nsignatures introduced in OpenSSL 3.5.\n\nRemove also the comment that was added earlier that says that there\nis no proper API replacement for SSL_get_peer_signature_nid yet as\nOpenSSL 3.5.0 has now introduced it.\n\nChange-Id: I2bc782ceebcc91a8dc8ada0bb72ac042be46cad6\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nMessage-Id: \u003c20250402153337.5262-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31336.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}