)]}'
{"id":"openvpn~928","triplet_id":"openvpn~master~Ib1db457c42a80f6b8fc0e3ceb4a895d4cf7f0155","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-04-01 20:53:39.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-04-01 20:53:39.000000000","reason":"Change was submitted"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2025-04-01 20:53:39.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ib1db457c42a80f6b8fc0e3ceb4a895d4cf7f0155","subject":"dco-win: Fix crash when cancelling pending operation","status":"MERGED","created":"2025-04-01 13:51:37.000000000","updated":"2025-04-01 20:53:39.000000000","submitted":"2025-04-01 20:53:39.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"928","meta_rev_id":"216cd5e5058336330d341078e688efd1a4855911","_number":928,"virtual_id_number":928,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-04-01 13:51:38.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-04-01 13:51:38.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-04-01 13:51:38.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-04-01 18:15:15.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"6511f895ab88dbf627c759666eace2410244953c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-04-01 13:51:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"518b3d2a9063c636932ad703b570032444dad39b","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-04-01 18:15:15.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"216cd5e5058336330d341078e688efd1a4855911","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-04-01 20:53:39.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f60a49362515a87ccf8db406ef422499adf34eb7","revisions":{"b23be3e832d0c0763b9e5707b8857f4b155dbbe5":{"kind":"REWORK","_number":1,"created":"2025-04-01 13:51:37.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/28/928/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/28/928/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/28/928/1 \u0026\u0026 git checkout -b change-928 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/28/928/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/28/928/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/28/928/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/28/928/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/28/928/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7825a8c586a8beba209370f1594cd0987b653ab7","subject":"Do not leave half-initialised key wrap struct when dynamic tls-crypt fails"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-04-01 13:45:50.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-04-01 13:49:20.000000000","tz":180},"subject":"dco-win: Fix crash when cancelling pending operation","message":"dco-win: Fix crash when cancelling pending operation\n\nThe OVERLAPPED structure must remain valid for the entire duration of an\nasynchronous operation. Previously, when a TCP connection was pending\ninside the NEW_PEER call, the OVERLAPPED structure was defined as a\nlocal variable within dco_p2p_new_peer().\n\nWhen CancelIo() was called later from close_tun_handle(), the OVERLAPPED\nstructure was already out of scope, resulting in undefined behavior and\nstack corruption.\n\nThis fix moves the OVERLAPPED structure to the tuntap struct, ensuring\nit remains valid throughout the operation\u0027s lifetime.\n\nGitHub: #715\n\nChange-Id: Ib1db457c42a80f6b8fc0e3ceb4a895d4cf7f0155\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"f60a49362515a87ccf8db406ef422499adf34eb7":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2025-04-01 20:53:39.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/28/928/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/28/928/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/28/928/2 \u0026\u0026 git checkout -b change-928 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/28/928/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/28/928/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/28/928/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/28/928/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/28/928/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0ffa7b57fdfb2658ae326baea0871ccca2c01b7d","subject":"GHA: Dependency and Actions update April 2025"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-04-01 18:15:30.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-04-01 18:37:50.000000000","tz":120},"subject":"dco-win: Fix crash when cancelling pending operation","message":"dco-win: Fix crash when cancelling pending operation\n\nThe OVERLAPPED structure must remain valid for the entire duration of an\nasynchronous operation. Previously, when a TCP connection was pending\ninside the NEW_PEER call, the OVERLAPPED structure was defined as a\nlocal variable within dco_p2p_new_peer().\n\nWhen CancelIo() was called later from close_tun_handle(), the OVERLAPPED\nstructure was already out of scope, resulting in undefined behavior and\nstack corruption.\n\nThis fix moves the OVERLAPPED structure to the tuntap struct, ensuring\nit remains valid throughout the operation\u0027s lifetime.\n\nGithub: closes OpenVPN/openvpn#715\n\nChange-Id: Ib1db457c42a80f6b8fc0e3ceb4a895d4cf7f0155\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250401181535.7854-1-gert@greenie.muc.de\u003e\nURL: https://sourceforge.net/p/openvpn/mailman/message/59168247/\nURL: https://gerrit.openvpn.net/c/openvpn/+/928\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}