)]}'
{"id":"openvpn~933","triplet_id":"openvpn~release%2F2.6~I44a73f06c0672c1d288bf46e9424dc0dc2abe054","project":"openvpn","branch":"release/2.6","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-04-02 14:33:34.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-04-02 14:33:34.000000000","reason":"Change was submitted"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2025-04-02 14:33:34.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I44a73f06c0672c1d288bf46e9424dc0dc2abe054","subject":"dco-win: Ensure correct OVERLAPPED scope","status":"MERGED","created":"2025-04-02 11:11:32.000000000","updated":"2025-04-02 14:33:34.000000000","submitted":"2025-04-02 14:33:34.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"933","meta_rev_id":"fa42fa26960e0efd78356ff2b066939487ea4b87","_number":933,"virtual_id_number":933,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-04-02 11:11:32.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-04-02 11:11:32.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-04-02 11:11:32.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-04-02 11:30:03.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"26b23d83b6c23dd4571dcb15f36646355b4af405","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-04-02 11:11:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d267bd75a85e49d9a13c1448b4fa8302f89c89d0","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-04-02 11:30:03.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"fa42fa26960e0efd78356ff2b066939487ea4b87","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-04-02 14:33:34.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"9c888671832041febf9284ca66fb163ab9d54a93","revisions":{"70fb0c6e7ef0ec0b2c86ee1f30b8fedfb8e2ac61":{"kind":"REWORK","_number":1,"created":"2025-04-02 11:11:32.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/33/933/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/33/933/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/933/1 \u0026\u0026 git checkout -b change-933 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/933/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/933/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/933/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/33/933/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/933/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4913628022f5d9d33bac656082a2ec279d8d1222","subject":"Fix compatibility with mbedTLS 2.28.10+ and 3.6.3+"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-04-02 10:51:15.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-04-02 10:51:15.000000000","tz":180},"subject":"dco-win: Ensure correct OVERLAPPED scope","message":"dco-win: Ensure correct OVERLAPPED scope\n\nThis is a backport of the master commit\n\n   f60a493 (\"dco-win: Fix crash when cancelling pending operation\")\n\nAlthough I am unable to reproduce this issue on release branch,\nthe code is clearly wrong and has to be fixed.\n\nThe OVERLAPPED structure must remain valid for the entire duration of an\nasynchronous operation. Previously, when a TCP connection was pending\ninside the NEW_PEER call, the OVERLAPPED structure was defined as a\nlocal variable within dco_p2p_new_peer().\n\nWhen CancelIo() was called later from close_tun_handle(), the OVERLAPPED\nstructure was already out of scope, resulting in undefined behavior and\nstack corruption.\n\nThis fix moves the OVERLAPPED structure to the tuntap struct, ensuring\nit remains valid throughout the operation\u0027s lifetime.\n\nChange-Id: I44a73f06c0672c1d288bf46e9424dc0dc2abe054\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/release/2.6"},"9c888671832041febf9284ca66fb163ab9d54a93":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2025-04-02 14:33:34.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/33/933/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/33/933/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/933/2 \u0026\u0026 git checkout -b change-933 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/933/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/933/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/933/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/33/933/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/33/933/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f588592ee6c6323b9674f470054e1638182c5b71","subject":"preparing release 2.6.14"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-04-02 11:30:11.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-04-02 14:27:27.000000000","tz":120},"subject":"dco-win: Ensure correct OVERLAPPED scope","message":"dco-win: Ensure correct OVERLAPPED scope\n\nThis is a backport of the master commit\n\n   f60a493 (\"dco-win: Fix crash when cancelling pending operation\")\n\nAlthough I am unable to reproduce this issue on release branch,\nthe code is clearly wrong and has to be fixed.\n\nThe OVERLAPPED structure must remain valid for the entire duration of an\nasynchronous operation. Previously, when a TCP connection was pending\ninside the NEW_PEER call, the OVERLAPPED structure was defined as a\nlocal variable within dco_p2p_new_peer().\n\nWhen CancelIo() was called later from close_tun_handle(), the OVERLAPPED\nstructure was already out of scope, resulting in undefined behavior and\nstack corruption.\n\nThis fix moves the OVERLAPPED structure to the tuntap struct, ensuring\nit remains valid throughout the operation\u0027s lifetime.\n\nChange-Id: I44a73f06c0672c1d288bf46e9424dc0dc2abe054\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250402113016.14980-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31316.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/release/2.6"}},"requirements":[],"submit_records":[],"submit_requirements":[]}