)]}'
{"id":"openvpn~938","triplet_id":"openvpn~master~I90d54853fe1b1d820661cc2c099e07ec5d31ed05","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-04-09 12:48:33.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-04-09 12:48:33.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I90d54853fe1b1d820661cc2c099e07ec5d31ed05","subject":"Also print key agreement when printing negotiated details","status":"MERGED","created":"2025-04-09 11:23:24.000000000","updated":"2025-04-09 12:48:33.000000000","submitted":"2025-04-09 12:48:33.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"938","meta_rev_id":"05a1d7bb435bcb9bd41263aa23e399d1c19874c3","_number":938,"virtual_id_number":938,"owner":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-04-09 11:23:25.000000000","updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-04-09 11:23:25.000000000","updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-04-09 11:51:35.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"801d922754e4d9b2d9197d97301ef3c27a631b91","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-04-09 11:23:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d3ddf805224ce5d5cb075bdd3e383a66a8b3d817","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-04-09 11:51:35.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"05a1d7bb435bcb9bd41263aa23e399d1c19874c3","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-04-09 12:48:33.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5b7a1bc34c8a3f86dfcc91b7a1aa520b1c549390","revisions":{"1c8dc21eb00f1bf7f98981874ffb466735946181":{"kind":"REWORK","_number":1,"created":"2025-04-09 11:23:24.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/38/938/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/38/938/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/938/1 \u0026\u0026 git checkout -b change-938 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/938/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/938/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/938/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/38/938/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/938/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bb8f2e373cf5d6c4d4320694ddd14bb61d5756b3","subject":"Use USER_PASS_LEN instead of TLS_USERNAME_LEN for override-username"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-04-09 10:37:11.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-04-09 11:13:18.000000000","tz":120},"subject":"Also print key agreement when printing negotiated details","message":"Also print key agreement when printing negotiated details\n\nWith TLS 1.0 to 1.2, the used key agreement was depended on the certificates\nthemselves. With TLS 1.3 is no longer the case but basically always X25519\nwas used. So this information has been very interesting so far. But with\nOpenSSL 3.5.0 and the new X25519MLKEM768 hybrid key agreement, the used\nkey agreement group actually becomes interesting information.\n\nThis commit adds printing this information for OpenSSL 3.0.0+ and uses\na compat version for OpenSSL 3.0-3.1 to avoid an additional ifdef in the\ncode itself.\n\nExample output with ML-DSA-65 certificates on the server (client output):\n\n   Control Channel: TLSv1.3, cipher\n   TLSv1.3 TLS_AES_256_GCM_SHA384, peer certificate: 15616\n   bits ML-DSA-65, signature: id-ml-dsa-65, peer signing\n   digest/type: mldsa65 id-ml-dsa-65,\n   key agreement: X25519MLKEM768\n\nwith an secp384r1 certificate:\n\n  Control Channel: TLSv1.3, cipher\n  TLSv1.3 TLS_AES_256_GCM_SHA384, peer certificate: 384\n  bits ECsecp384r1, signature: ecdsa-with-SHA256, peer signing\n  digest/type: ecdsa_secp384r1_sha384 ECDSA,\n  key agreement: X25519MLKEM768\n\nChange-Id: I90d54853fe1b1d820661cc2c099e07ec5d31ed05\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"5b7a1bc34c8a3f86dfcc91b7a1aa520b1c549390":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-04-09 12:48:33.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/38/938/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/38/938/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/938/2 \u0026\u0026 git checkout -b change-938 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/938/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/938/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/938/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/38/938/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/38/938/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bb8f2e373cf5d6c4d4320694ddd14bb61d5756b3","subject":"Use USER_PASS_LEN instead of TLS_USERNAME_LEN for override-username"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2025-04-09 12:24:03.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-04-09 12:45:17.000000000","tz":120},"subject":"Also print key agreement when printing negotiated details","message":"Also print key agreement when printing negotiated details\n\nWith TLS 1.0 to 1.2, the used key agreement was depended on the certificates\nthemselves. With TLS 1.3 this is no longer the case but basically always\nX25519 was used.  So this information has not been very interesting so far.\n\nWith OpenSSL 3.5.0 and the new X25519MLKEM768 hybrid key agreement, the used\nkey agreement group actually becomes interesting information.\n\nThis commit adds printing this information for OpenSSL 3.0.0+ and uses\na compat version for OpenSSL 3.0-3.1 to avoid an additional ifdef in the\ncode itself.\n\nExample output with ML-DSA-65 certificates on the server (client output):\n\n   Control Channel: TLSv1.3, cipher\n   TLSv1.3 TLS_AES_256_GCM_SHA384, peer certificate: 15616\n   bits ML-DSA-65, signature: id-ml-dsa-65, peer signing\n   digest/type: mldsa65 id-ml-dsa-65,\n   key agreement: X25519MLKEM768\n\nwith an secp384r1 certificate:\n\n  Control Channel: TLSv1.3, cipher\n  TLSv1.3 TLS_AES_256_GCM_SHA384, peer certificate: 384\n  bits ECsecp384r1, signature: ecdsa-with-SHA256, peer signing\n  digest/type: ecdsa_secp384r1_sha384 ECDSA,\n  key agreement: X25519MLKEM768\n\nChange-Id: I90d54853fe1b1d820661cc2c099e07ec5d31ed05\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250409122409.17616-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31393.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
