)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"40edf4c6b58ab508bae73edf9c85b52e078e39ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"28ef1d78_b1ef715f","updated":"2025-04-17 11:52:33.000000000","message":"Thanks for the fixes.","commit_id":"05ef208eec10f8312def5afbb5e7c6a483011e38"}],"src/openvpn/ssl_openssl.c":[{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"cc26770440fd0bdd797a0f0523201824103a69bf","unresolved":true,"context_lines":[{"line_number":1155,"context_line":"    info \u003d NULL;"},{"line_number":1156,"context_line":""},{"line_number":1157,"context_line":"    /* iterate through the store and add extra certificates if any to the chain */"},{"line_number":1158,"context_line":"    while (!OSSL_STORE_eof(store_ctx))"},{"line_number":1159,"context_line":"    {"},{"line_number":1160,"context_line":"        info \u003d OSSL_STORE_load(store_ctx);"},{"line_number":1161,"context_line":"        if (!info)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6a126931_2a8bc5d9","line":1158,"updated":"2025-04-17 11:35:13.000000000","message":"what you describe if possible only if this check if false immediately, right?\nSo we skip the while loop and go to cleanup right away.","commit_id":"4dca8ddadf8615e8c894c098f1c5a777decc822b"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"97e067a3913c7d3b1b5e37e349a4d0e3bf77407a","unresolved":true,"context_lines":[{"line_number":1155,"context_line":"    info \u003d NULL;"},{"line_number":1156,"context_line":""},{"line_number":1157,"context_line":"    /* iterate through the store and add extra certificates if any to the chain */"},{"line_number":1158,"context_line":"    while (!OSSL_STORE_eof(store_ctx))"},{"line_number":1159,"context_line":"    {"},{"line_number":1160,"context_line":"        info \u003d OSSL_STORE_load(store_ctx);"},{"line_number":1161,"context_line":"        if (!info)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"765fe0e2_13dcd7b5","line":1158,"in_reply_to":"6a126931_2a8bc5d9","updated":"2025-04-17 11:36:32.000000000","message":"Yes, this is what happened with mattock\u0027s certs.","commit_id":"4dca8ddadf8615e8c894c098f1c5a777decc822b"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"133790d4a540b681ef9043d27d6ba8f3d7ebd8a3","unresolved":false,"context_lines":[{"line_number":1155,"context_line":"    info \u003d NULL;"},{"line_number":1156,"context_line":""},{"line_number":1157,"context_line":"    /* iterate through the store and add extra certificates if any to the chain */"},{"line_number":1158,"context_line":"    while (!OSSL_STORE_eof(store_ctx))"},{"line_number":1159,"context_line":"    {"},{"line_number":1160,"context_line":"        info \u003d OSSL_STORE_load(store_ctx);"},{"line_number":1161,"context_line":"        if (!info)"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"44b20348_cad4db27","line":1158,"in_reply_to":"765fe0e2_13dcd7b5","updated":"2025-04-17 11:39:09.000000000","message":"Done","commit_id":"4dca8ddadf8615e8c894c098f1c5a777decc822b"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"133790d4a540b681ef9043d27d6ba8f3d7ebd8a3","unresolved":true,"context_lines":[{"line_number":1186,"context_line":"    }"},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"    UI_destroy_method(ui_method);"},{"line_number":1189,"context_line":"    if (info)"},{"line_number":1190,"context_line":"    {"},{"line_number":1191,"context_line":"        OSSL_STORE_INFO_free(info);"},{"line_number":1192,"context_line":"        info \u003d NULL;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"94540f39_f171d755","line":1189,"updated":"2025-04-17 11:39:09.000000000","message":"there is no need for this check. Like most free() methods, passing NULL leads to nothing.\n\nFrom the manpage:\n\n       OSSL_STORE_INFO_free() frees a OSSL_STORE_INFO and its contained type.  If the argument is NULL, nothing is done.","commit_id":"4dca8ddadf8615e8c894c098f1c5a777decc822b"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"f90894ca35f1f7907a53efba9a46b721f5272f99","unresolved":false,"context_lines":[{"line_number":1186,"context_line":"    }"},{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"    UI_destroy_method(ui_method);"},{"line_number":1189,"context_line":"    if (info)"},{"line_number":1190,"context_line":"    {"},{"line_number":1191,"context_line":"        OSSL_STORE_INFO_free(info);"},{"line_number":1192,"context_line":"        info \u003d NULL;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6db32f5d_f59632ce","line":1189,"in_reply_to":"94540f39_f171d755","updated":"2025-04-17 11:48:56.000000000","message":"Done","commit_id":"4dca8ddadf8615e8c894c098f1c5a777decc822b"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"f90894ca35f1f7907a53efba9a46b721f5272f99","unresolved":true,"context_lines":[{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"    UI_destroy_method(ui_method);"},{"line_number":1189,"context_line":"    OSSL_STORE_INFO_free(info);"},{"line_number":1190,"context_line":"    info \u003d NULL;"},{"line_number":1191,"context_line":"    OSSL_STORE_close(store_ctx);"},{"line_number":1192,"context_line":"#else /* defined(HAVE_OPENSSL_STORE_API */"},{"line_number":1193,"context_line":"    ASSERT(0);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"8c265995_42864120","line":1190,"updated":"2025-04-17 11:48:56.000000000","message":"what is this for? the variable is going out of scope at this point.","commit_id":"58abf8d4dc763f21811563d594ceb338bf7262bb"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"08e877df11e9ac99fee555a95b086059db14b2e7","unresolved":false,"context_lines":[{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"    UI_destroy_method(ui_method);"},{"line_number":1189,"context_line":"    OSSL_STORE_INFO_free(info);"},{"line_number":1190,"context_line":"    info \u003d NULL;"},{"line_number":1191,"context_line":"    OSSL_STORE_close(store_ctx);"},{"line_number":1192,"context_line":"#else /* defined(HAVE_OPENSSL_STORE_API */"},{"line_number":1193,"context_line":"    ASSERT(0);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"11a0580f_b354ffa1","line":1190,"in_reply_to":"8c265995_42864120","updated":"2025-04-17 11:52:17.000000000","message":"Done","commit_id":"58abf8d4dc763f21811563d594ceb338bf7262bb"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"40edf4c6b58ab508bae73edf9c85b52e078e39ca","unresolved":false,"context_lines":[{"line_number":1187,"context_line":""},{"line_number":1188,"context_line":"    UI_destroy_method(ui_method);"},{"line_number":1189,"context_line":"    OSSL_STORE_INFO_free(info);"},{"line_number":1190,"context_line":"    info \u003d NULL;"},{"line_number":1191,"context_line":"    OSSL_STORE_close(store_ctx);"},{"line_number":1192,"context_line":"#else /* defined(HAVE_OPENSSL_STORE_API */"},{"line_number":1193,"context_line":"    ASSERT(0);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"99b45415_23d79600","line":1190,"in_reply_to":"8c265995_42864120","updated":"2025-04-17 11:52:33.000000000","message":"Done","commit_id":"58abf8d4dc763f21811563d594ceb338bf7262bb"}]}