)]}'
{"id":"openvpn~944","triplet_id":"openvpn~master~I39d660ebeec76280e4d4357192b74bf2c0980615","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-05-05 16:27:08.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-05-05 16:27:08.000000000","reason":"Change was submitted"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2025-05-05 16:27:08.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I39d660ebeec76280e4d4357192b74bf2c0980615","subject":"win: refactor get_windows_version()","status":"MERGED","created":"2025-04-18 13:06:38.000000000","updated":"2025-05-05 16:27:08.000000000","submitted":"2025-05-05 16:27:08.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"944","meta_rev_id":"4d8507e3f3cc3295093216757d80228f3eddea00","_number":944,"virtual_id_number":944,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-04-18 13:06:39.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-04-18 13:06:39.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-04-18 13:06:39.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-05-05 12:26:55.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"9be5149758791199ed82c45f3f2c1d8299aa1cb2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-04-18 13:06:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b13e835f63b996b3e3a426be0fe6bdc1084e45be","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-04-18 13:23:39.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"36ae0a157c057c5ca58e89b0e8d274d995027163","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-04-18 13:25:37.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"0c40ebacf672d1b0d06e05c4e6ad74a81073bfd1","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-05-05 12:26:55.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"4d8507e3f3cc3295093216757d80228f3eddea00","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-05-05 16:27:08.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"45a4f4e5f6c3552a27a8064ab6a857c465efc2f0","revisions":{"65783890bf24ca941c9a175e310c71619d0781ce":{"kind":"REWORK","_number":1,"created":"2025-04-18 13:06:38.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/44/944/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/44/944/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/944/1 \u0026\u0026 git checkout -b change-944 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/944/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/944/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/944/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/44/944/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/944/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f7aedca70e24e9a35f0cbd33d1aa708b4daf0055","subject":"ssl_openssl.c: Prevent potential double-free"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-04-18 12:57:46.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-04-18 12:57:46.000000000","tz":180},"subject":"win: refactor get_windows_version()","message":"win: refactor get_windows_version()\n\nIt\u0027s 2025, and almost all clients now run on Windows 10 or newer.\nInstead of displaying:\n\n  \"Windows version 10.0 (Windows 10 or greater)\"\n\nwe now show the exact build number, e.g.:\n\n  \"Windows version: 10.0.22631\"\n\nRemove \"pre-Win7\" checks in a few places.\n\nFor IV_PLAT_VER, we now provide only the version number without\nbinary architecture info. Previously:\n\n  IV_PLAT_VER\u003d10.0,_amd64_executable\n\nNow:\n\n  IV_PLAT_VER\u003d10.0.22631\n\nChange-Id: I39d660ebeec76280e4d4357192b74bf2c0980615\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"a6ef9aaec00140f217196063c06e0d7f04a0dbb5":{"kind":"REWORK","_number":2,"created":"2025-04-18 13:23:39.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/44/944/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/44/944/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/944/2 \u0026\u0026 git checkout -b change-944 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/944/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/944/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/944/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/44/944/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/944/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f7aedca70e24e9a35f0cbd33d1aa708b4daf0055","subject":"ssl_openssl.c: Prevent potential double-free"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-04-18 12:57:46.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-04-18 13:22:14.000000000","tz":180},"subject":"win: refactor get_windows_version()","message":"win: refactor get_windows_version()\n\nIt\u0027s 2025, and almost all clients now run on Windows 10 or newer.\nInstead of displaying:\n\n  \"Windows version 10.0 (Windows 10 or greater), amd64 executable\"\n\nwe now show the exact build number, e.g.:\n\n  \"Windows version: 10.0.22631,amd64\"\n\nRemove \"pre-Win7\" checks in a few places.\n\nChange-Id: I39d660ebeec76280e4d4357192b74bf2c0980615\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"40afa68992adea7adcef47f4d737e4fbc1e2a677":{"kind":"REWORK","_number":3,"created":"2025-04-18 13:25:37.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/44/944/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/44/944/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/944/3 \u0026\u0026 git checkout -b change-944 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/944/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/944/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/944/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/44/944/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/944/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f7aedca70e24e9a35f0cbd33d1aa708b4daf0055","subject":"ssl_openssl.c: Prevent potential double-free"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-04-18 12:57:46.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-04-18 13:25:15.000000000","tz":180},"subject":"win: refactor get_windows_version()","message":"win: refactor get_windows_version()\n\nIt\u0027s 2025, and almost all clients now run on Windows 10 or newer.\nInstead of displaying:\n\n  \"Windows version 10.0 (Windows 10 or greater), amd64 executable\"\n\nwe now show the exact build number, e.g.:\n\n  \"Windows version: 10.0.22631,amd64\"\n\nRemove \"pre-Win7\" checks in a few places.\n\nChange-Id: I39d660ebeec76280e4d4357192b74bf2c0980615\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"45a4f4e5f6c3552a27a8064ab6a857c465efc2f0":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-05-05 16:27:08.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/44/944/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/44/944/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/944/4 \u0026\u0026 git checkout -b change-944 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/944/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/944/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/944/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/44/944/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/44/944/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b4e31e57bc69819e6ea61ea1bc08ad199b2be272","subject":"Add information-gathering about DNS resolvers configured to t_client.sh(.in)"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-05-05 12:27:06.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-05-05 16:10:52.000000000","tz":120},"subject":"win: refactor get_windows_version()","message":"win: refactor get_windows_version()\n\nIt\u0027s 2025, and almost all clients now run on Windows 10 or newer.\nInstead of displaying:\n\n  \"Windows version 10.0 (Windows 10 or greater), amd64 executable\"\n\nwe now show the exact build number, e.g.:\n\n  \"Windows version: 10.0.22631,amd64\"\n\nRemove \"pre-Win7\" checks in a few places.\n\nChange-Id: I39d660ebeec76280e4d4357192b74bf2c0980615\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250505122712.5214-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31566.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}