)]}'
{"id":"openvpn~961","triplet_id":"openvpn~master~I9cae7314203424e4a604073c5445559260172477","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-05-05 15:00:55.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-05-05 15:00:55.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-05-05 13:45:37.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I9cae7314203424e4a604073c5445559260172477","subject":"Add information-gathering about DNS resolvers configured to t_client.sh(.in)","status":"MERGED","created":"2025-05-05 10:15:38.000000000","updated":"2025-05-05 15:00:55.000000000","submitted":"2025-05-05 15:00:55.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"961","meta_rev_id":"c9697f5bf159407cb5a2bd42821510282ee66b03","_number":961,"virtual_id_number":961,"owner":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}],"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-05-05 10:15:39.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-05-05 10:15:39.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-05-05 10:15:39.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"ca6b3cc3a2c934dec9af156b7c087f3cf4cf026f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-05-05 10:15:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"38bb4240d490ca7d411ab8858a3b3748debd9553","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-05-05 13:12:34.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent tree, and commit message as Patch Set 1.","accounts_in_message":[],"_revision_number":2},{"id":"a1297e2c1a1734edd50a6f1c34176061ea58e2aa","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-05-05 13:45:37.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"caf7114e67ab656f0208a10205e3f2c156ed93ef","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-05-05 13:47:56.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"c9697f5bf159407cb5a2bd42821510282ee66b03","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-05-05 15:00:55.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"b4e31e57bc69819e6ea61ea1bc08ad199b2be272","revisions":{"9da9f4ba0339b474eb053712620218299dca9eb5":{"kind":"REWORK","_number":1,"created":"2025-05-05 10:15:38.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/61/961/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/61/961/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/961/1 \u0026\u0026 git checkout -b change-961 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/961/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/961/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/961/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/61/961/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/961/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d16781531898b4c5a76cfe6cba02fccce9afb8ad","subject":"Mention address if not unspecific on DNS failure"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-05-05 10:02:25.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-05-05 10:15:28.000000000","tz":120},"subject":"Add information-gathering about DNS resolvers configured to t_client.sh(.in)","message":"Add information-gathering about DNS resolvers configured to t_client.sh(.in)\n\nWith the patchsets to add DNS configuration on Unix+MacOS systems, and\nthe addition of test stanzas to excercise and verify the OS specific\n\"dns-updown\" script, it becomes important to trace test failures\n(\"did it not ping because the DNS was not installed, or did something\nelse fail?\") and also verify that DNS config is properly restored at\nthe end of each test.\n\nLinux is probed with \"resolvectl status\", if available, and\n\"cat resolv.conf\" if not.  MacOS uses scutil --dns.\n\nAll other platforms use \"cat resolv.conf\" for now (because even if\n\"a tool to maintain DNS config\" is available, in the end resolv.conf\nis always where the final config lands).\n\nInclude a bit of restructuring to handle linux iproute2 testing in the\n\"Linux\" branch, and make the control flow more amenable to having a\nsecond case / esac block.\n\nChange-Id: I9cae7314203424e4a604073c5445559260172477\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"05558f142f438cafe3e13ae135f9df094c099f2c":{"kind":"NO_CHANGE","_number":2,"created":"2025-05-05 13:12:34.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/61/961/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/61/961/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/961/2 \u0026\u0026 git checkout -b change-961 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/961/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/961/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/961/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/61/961/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/961/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d16781531898b4c5a76cfe6cba02fccce9afb8ad","subject":"Mention address if not unspecific on DNS failure"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-05-05 10:02:25.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-05-05 13:12:24.000000000","tz":120},"subject":"Add information-gathering about DNS resolvers configured to t_client.sh(.in)","message":"Add information-gathering about DNS resolvers configured to t_client.sh(.in)\n\nWith the patchsets to add DNS configuration on Unix+MacOS systems, and\nthe addition of test stanzas to excercise and verify the OS specific\n\"dns-updown\" script, it becomes important to trace test failures\n(\"did it not ping because the DNS was not installed, or did something\nelse fail?\") and also verify that DNS config is properly restored at\nthe end of each test.\n\nLinux is probed with \"resolvectl status\", if available, and\n\"cat resolv.conf\" if not.  MacOS uses scutil --dns.\n\nAll other platforms use \"cat resolv.conf\" for now (because even if\n\"a tool to maintain DNS config\" is available, in the end resolv.conf\nis always where the final config lands).\n\nInclude a bit of restructuring to handle linux iproute2 testing in the\n\"Linux\" branch, and make the control flow more amenable to having a\nsecond case / esac block.\n\nChange-Id: I9cae7314203424e4a604073c5445559260172477\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"8b6646c9a00cdcafa003c9f7b97d64891337aff2":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-05-05 13:47:56.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/61/961/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/61/961/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/961/3 \u0026\u0026 git checkout -b change-961 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/961/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/961/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/961/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/61/961/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/961/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"eef30e6e72d6bb36c0c0ec29a1219e7d54c866eb","subject":"Manually reformat some long trailing comments"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-05-05 10:02:25.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-05-05 13:47:51.000000000","tz":120},"subject":"Add information-gathering about DNS resolvers configured to t_client.sh(.in)","message":"Add information-gathering about DNS resolvers configured to t_client.sh(.in)\n\nWith the patchsets to add DNS configuration on Unix+MacOS systems, and\nthe addition of test stanzas to excercise and verify the OS specific\n\"dns-updown\" script, it becomes important to trace test failures\n(\"did it not ping because the DNS was not installed, or did something\nelse fail?\") and also verify that DNS config is properly restored at\nthe end of each test.\n\nLinux is probed with \"resolvectl status\", if available, and\n\"cat resolv.conf\" if not.  MacOS uses scutil --dns.\n\nAll other platforms use \"cat resolv.conf\" for now (because even if\n\"a tool to maintain DNS config\" is available, in the end resolv.conf\nis always where the final config lands).\n\nInclude a bit of restructuring to handle linux iproute2 testing in the\n\"Linux\" branch, and make the control flow more amenable to having a\nsecond case / esac block.\n\nChange-Id: I9cae7314203424e4a604073c5445559260172477\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"b4e31e57bc69819e6ea61ea1bc08ad199b2be272":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2025-05-05 15:00:55.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/61/961/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/61/961/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/961/4 \u0026\u0026 git checkout -b change-961 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/961/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/961/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/961/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/61/961/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/61/961/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"eef30e6e72d6bb36c0c0ec29a1219e7d54c866eb","subject":"Manually reformat some long trailing comments"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-05-05 14:22:16.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-05-05 14:54:07.000000000","tz":120},"subject":"Add information-gathering about DNS resolvers configured to t_client.sh(.in)","message":"Add information-gathering about DNS resolvers configured to t_client.sh(.in)\n\nWith the patchsets to add DNS configuration on Unix+MacOS systems, and\nthe addition of test stanzas to excercise and verify the OS specific\n\"dns-updown\" script, it becomes important to trace test failures\n(\"did it not ping because the DNS was not installed, or did something\nelse fail?\") and also verify that DNS config is properly restored at\nthe end of each test.\n\nLinux is probed with \"resolvectl status\", if available, and\n\"cat resolv.conf\" if not.  MacOS uses scutil --dns.\n\nAll other platforms use \"cat resolv.conf\" for now (because even if\n\"a tool to maintain DNS config\" is available, in the end resolv.conf\nis always where the final config lands).\n\nInclude a bit of restructuring to handle linux iproute2 testing in the\n\"Linux\" branch, and make the control flow more amenable to having a\nsecond case / esac block.\n\nChange-Id: I9cae7314203424e4a604073c5445559260172477\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20250505142224.24935-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31568.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}